mstrong
7870384875
updated fs.isDir to always return an error even if the directory is not found
2017-07-10 10:05:03 -04:00
Carolyn Van Slyck
c300e1cdb5
Interpret strings as branches > semver constraints
...
When a user supplied string in an imported config file, or specified to
dep ensure, can be interpreted multiple ways, prefer the branch over a
semver constraint.
In #710 , glide.yaml specified v2 for https://github.com/go-mgo/mgo .
When we assume that is a semver constraint, solve fails because the
hinted revision in the lock (a commit on the v2 branch) doesn't satisfy
the assumed constraint of ^2.0.0.
The new preferred match order for the user string is:
* revision
* branch
* semver constraint
* tag
I am giving preference of a semver constraint over a tag so that a bare
version, 1.0.0, is interpreted more loosely with an implied caret,
^1.0.0, instead of the stricter exact match.
2017-07-06 18:29:03 -05:00
marwan-at-work
6f32508ff2
pr fixes
2017-07-06 11:49:11 -04:00
marwan-at-work
5bfa12ee00
move deduceConstraint to SourceManager
2017-07-06 11:28:04 -04:00
Milutin Jovanović
f8d56fafd5
Removed unused ProjectConstraints.merge()
2017-06-26 20:21:22 -04:00
Milutin Jovanović
64c6cbcf3a
Removed stale comments.
2017-06-23 07:07:17 -04:00
Milutin Jovanović
1ce62ca834
Fixes #429 . Removed Manifest.TestDependencyConstraints() and all usage.
...
As per the issue description, speficying dependency now does not imply
requirement. Therefore, there is no point in differentiating normal
and test dependencies.
2017-06-19 07:02:41 -04:00
sam boyer
24c37f5f33
Merge pull request #634 from davecheney/fixedbugs/632
...
internal/fs: IsRegular returns an error on any non regular file
2017-06-14 21:43:20 -04:00
sam boyer
235878aa6b
Merge pull request #753 from jmank88/project_analyzer_info
...
gps: add new ProjectAnalyzerInfo type to return from ProjectAnalyzer.Info
2017-06-14 20:23:35 -04:00
Jordan Krage
478afad8fe
add new ProjectAnalyzerInfo type to return from ProjectAnalyzer.Info
2017-06-14 18:31:47 -05:00
Jordan Krage
d85a7ef672
add sourceCachePath helper func
2017-06-14 13:28:00 -05:00
Carolyn Van Slyck
3d286c9148
Fix funky merge after refactoring
...
* Underlying() was renamed to Revision()
* Is() was renamed to Pair()
2017-06-14 11:26:26 -05:00
sam boyer
75cb241a0e
Merge pull request #750 from jmank88/version_api
...
Version API Method Names
2017-06-14 12:03:34 -04:00
sam boyer
564e00605d
Touch up feedback docs a bit
2017-06-14 11:59:06 -04:00
Jordan Krage
cb7df4a61c
rename UnpairedVersion.Is() to Pair()
2017-06-14 09:44:59 -05:00
Jordan Krage
7a73e5ddad
rename PairedVersion.Underlying() to Revision()
2017-06-14 09:40:36 -05:00
Carolyn Van Slyck
cc112746e4
Add constructors for feedback logs
...
The feedback system was originally designed for reporting feedback as GOPATH
was scanned, which didn’t work well for logging from the importers. This moves
more of the logic around what should be logged back onto the caller and simplifies
the ConstraintFeedback.LogFeedback function to print what it is given.
2017-06-13 11:56:46 -05:00
sam boyer
b6f216a50b
Use pointer to versionUnifier in solver
...
Using a value caused the versionUnifier attached to the selection queue
to be without a metrics object, resulting in panics on constraint
conflicts. What's odd is that these panics *should* happen all the time,
but seem to actually happen in only a subset of cases.
2017-06-05 22:36:29 -04:00
sam boyer
6b75d6b4c7
Merge pull request #704 from mikijov/issue675-old
...
Fixes #675 . Changes to HasFilepathPrefix to handle Windows better.
2017-06-04 07:32:32 -04:00
Carolyn Van Slyck
caf7855f77
Fix failing test build
...
No clue why this didn't cause #643 to bomb out?
2017-06-03 10:06:08 -05:00
sam boyer
556d3ad006
Merge pull request #643 from davecheney/setup-inaccessible-dir
...
internal/fs: clean up setupInaccessibleDir helper
2017-06-02 15:06:00 -04:00
Milutin Jovanović
5a7783f7a8
Added comments explaining need for special Windows behaviour.
2017-06-01 23:03:28 -04:00
Carolyn Van Slyck
1ef8181394
Suppress logging from importers during solve
2017-06-01 20:26:26 -05:00
Carolyn Van Slyck
cbc263f23a
Support importing glide configuration
...
* init imports by default unless -skip-tools is specified
* glide config in dependencies is taken into account during solve
2017-06-01 16:22:46 -05:00
Milutin Jovanović
1cf15a6ca0
Fixes #675 . Changes to HasFilepathPrefix to handle Windows better.
...
Old logic lost the drive letter hence subsequent comparisons
were often wrong. New code adds logic to handle volume name
separately. Test changed to always have mismatching case on
windows.
2017-06-01 17:07:24 -04:00
sam boyer
4871d2f749
Guard against possibly stale local git repos
2017-05-31 21:03:46 -04:00
sam boyer
94e95d2104
Merge pull request #596 from marwan-at-work/local-recovery
...
recover from corrupt repos
2017-05-30 23:28:29 -04:00
sam boyer
37fe793f0d
Merge pull request #657 from ibrasho-forks/fix-symlink-copying
...
internal/fs: handle symlinks in copyFile()
2017-05-30 08:58:50 -04:00
Ibrahim AshShohail
4d224bd556
internal/fs: more nits
...
Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
2017-05-30 09:43:56 +03:00
sam boyer
07b4de8c68
Merge pull request #670 from gregory-m/compare-vendor-paths-order
...
Fixed order in test output
2017-05-29 23:35:16 -04:00
sam boyer
6d355e0592
Merge pull request #653 from jmank88/mkbridge
...
de-globalize mkBridge function var
2017-05-29 23:29:14 -04:00
sam boyer
8021755918
Merge pull request #665 from jmank88/test_case_serialization
...
DRY up integration tests; remove 'Cleanup' testcase.json rewrite
2017-05-29 23:25:25 -04:00
Gregory Man
0088f3d8c7
Fixed wrong order in test output
...
CompareVendorPaths was output got instead want and vice versa
2017-05-28 13:22:45 +03:00
Jordan Krage
9249f903a3
DRY up integration tests; remove 'Cleanup' testcase.json rewrite
2017-05-27 09:44:56 -05:00
Ibrahim AshShohail
e568774268
internal/fs: nits here and there
...
Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
2017-05-27 16:14:39 +03:00
Dave Cheney
86b5fa6c60
internal/fs: clean up setupInaccessibleDir helper
...
Updates #632
setupInaccessibleDir returns an error which must be checked by the
caller, which always invoked t.Fatal on error.
This change refactors setupInaccessibleDir to call t.Fatal internally
and handle any clean up if necessary.
2017-05-27 23:12:07 +10:00
sam boyer
05c40eba7f
Merge meta-PR to stabilize Gopkg metadata files
2017-05-26 23:52:34 -04:00
marwan-at-work
ce46ed080e
change tmepdir name for TestNewCtxRepoHappyPath
2017-05-26 13:34:46 -04:00
Ibrahim AshShohail
f82ed6b4e9
internal/fs: rename var in copyFile
...
Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
2017-05-26 17:06:27 +03:00
Ibrahim AshShohail
4af778024f
internal/fs: skip inaccessible file tests on windows
...
Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
2017-05-26 16:35:19 +03:00
Ibrahim AshShohail
fc0c4b79f4
internal/fs: simplify statement
...
Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
2017-05-26 15:00:07 +03:00
Ibrahim AshShohail
e8fb51dc88
internal/fs: add tests for IsSymlink()
...
Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
2017-05-26 14:58:49 +03:00
Ibrahim AshShohail
b614fbf7f1
internal/fs: add IsSymlink() and copySymlink() to fix copyFile()
...
Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
2017-05-26 14:31:48 +03:00
Ibrahim AshShohail
1dd2d585ff
internal/fs: add tests for fs.copyFile() on symlinks
...
Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
2017-05-26 14:27:55 +03:00
Ibrahim AshShohail
e6b1a5fee1
internal/fs: wrap CopyDir and copyFile errors
...
Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
2017-05-26 01:38:57 +03:00
Ibrahim AshShohail
d009e3b896
internal/fs: update error message when rename fallback fails
...
Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
2017-05-26 01:31:00 +03:00
Carolyn Van Slyck
9a203ea21a
Merge pull request #627 from gregory-m/fix-double-usage-message-626
...
Fix double usage message
2017-05-25 15:03:21 -05:00
Jordan Krage
b91b9c90ca
de-globalize mkBridge function var
2017-05-25 08:54:58 -05:00
Jordan Krage
9f9a32e145
spelling
2017-05-25 08:12:56 -05:00
marwan-at-work
a0db261760
add happy path test + readme
2017-05-24 22:44:43 -04:00