4 Коммитов

Автор	SHA1	Сообщение	Дата
Tamir Duberstein	a374f1cebd	gps: DRY	2017-09-18 19:47:43 -04:00
Tamir Duberstein	9e660334de	gps: remove arbitrary command timeouts ... Use better context plumbing while I'm here.	2017-09-12 23:46:46 -04:00
sam boyer	74efbb1aae	Update sig of killProcess() for windows	2017-07-21 10:53:21 -04:00
sam boyer	cd11da188c	Split proc termination paths for UNIX vs. Windows ... This allows us to rely on gentler termination semantics (os.Interrupt) for UNIX-y systems, as such interrupts do not work on Windows. Terminations are triggered by e.g. ctrl-C interrupts. Relying generally on Process.Kill() for such purposes was causing git to often exit in unclean ways, resulting in a dirty cache dir and putting users in an awkward position. We maintain the invariant that we ensure the process IS either exited, or forcibly Process.Kill()ed, before exiting monitoredCmd.run(). This allows us to ensure we do not have orphan subprocesses that exist beyond the lifetime of the parent sourceMgr.	2017-07-19 22:20:54 -04:00