Change-Id: I22ead42deebb9bb5146581f261a22e854517ceef
Reviewed-on: https://go-review.googlesource.com/c/dl/+/520578
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
All supported versions of Go can download golang.org/dl/... commands
via the new go install path@latest syntax. Update their documentation
accordingly.
Also update the golang.org/dl/internal/genv generator template for
future commands that will be added when new Go releases are made.
Fixesgolang/go#48080.
Change-Id: I0abf80e944322f3e30f7eb1b03b5d8d3be25554d
Reviewed-on: https://go-review.googlesource.com/c/dl/+/346091
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Also corrected the code in case of unrecognized version.
According to the docs, nil is returned when the regex does not match.
And in case of a partial or full match, the length of the slice
is always equal to the no. of subexpressions.
For the subexpressions that did not match, the string will be empty.
So the length check was logically wrong. It's just that since the length
of a nil slice is 0, it accidentally turned out to be correct.
Fixesgolang/go#26976
Change-Id: Ic9e43d13877d747df20c15949436e355d2fd448d
Reviewed-on: https://go-review.googlesource.com/c/160920
Reviewed-by: Filippo Valsorda <filippo@golang.org>
cui fliter
Dmitri Shuralyov
Agniva De Sarker
Brad Fitzpatrick