bind/java, bind/objc: do not use module for reverse binding
Reverse binding is not available with Go module, and some tests fail due to this. This CL suppresses the errors by disabling Go modules explicitly. Updates golang/go#27234 Change-Id: I7483c1dab468548a2efa05ca426addf5c3d97b6e Reviewed-on: https://go-review.googlesource.com/c/mobile/+/192599 Run-TryBot: Hajime Hoshi <hajimehoshi@gmail.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Родитель
cafc553e1a
Коммит
c6da959549
|
@ -140,7 +140,11 @@ func runTest(t *testing.T, pkgNames []string, javaPkg, javaCls string) {
|
|||
args = append(args, "-javapkg", javaPkg)
|
||||
}
|
||||
args = append(args, pkgNames...)
|
||||
buf, err := exec.Command(gomobileBin, args...).CombinedOutput()
|
||||
cmd := exec.Command(gomobileBin, args...)
|
||||
// Reverse binding doesn't work with Go module since imports starting with Java or ObjC are not valid FQDNs.
|
||||
// Disable Go module explicitly until this problem is solved. See golang/go#27234.
|
||||
cmd.Env = append(os.Environ(), "GO111MODULE=off")
|
||||
buf, err := cmd.CombinedOutput()
|
||||
if err != nil {
|
||||
t.Logf("%s", buf)
|
||||
t.Fatalf("failed to run gomobile bind: %v", err)
|
||||
|
|
|
@ -129,6 +129,9 @@ func runTest(t *testing.T, pkgNames []string, prefix, testfile, framework string
|
|||
}
|
||||
cmd.Args = append(cmd.Args, pkgNames...)
|
||||
cmd.Dir = filepath.Join(tmpdir, "xcodetest")
|
||||
// Reverse binding doesn't work with Go module since imports starting with Java or ObjC are not valid FQDNs.
|
||||
// Disable Go module explicitly until this problem is solved. See golang/go#27234.
|
||||
cmd.Env = append(os.Environ(), "GO111MODULE=off")
|
||||
buf, err := cmd.CombinedOutput()
|
||||
if err != nil {
|
||||
t.Logf("%s", buf)
|
||||
|
|
Загрузка…
Ссылка в новой задаче