Change-Id: I6838338ebb8d2130f1442fc844ac787eeb9c8c1f
Reviewed-on: https://go-review.googlesource.com/c/playground/+/625755
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The playground's dependencies were quite stale, causing trybot failures
due to an old version of x/sys.
Update them.
Also fix a stale link to play.golang.org in the README.
Fixesgolang/go#59218
Change-Id: I8b672883681c25f03375e9abaee189ca2b7c334b
Reviewed-on: https://go-review.googlesource.com/c/playground/+/478959
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
Auto-Submit: Robert Findley <rfindley@google.com>
Attempt to clearly label the Go tip playground as a development build,
and surface the version string.
For some reason I had to install git in the build-playground phase of
the Docker build, to avoid errors from the Go command. I'm not sure why
this is, but it seems harmless.
For golang/go#48517
Change-Id: I35b150686c9f177d76024cc38ff62cb8785525e0
Reviewed-on: https://go-review.googlesource.com/c/playground/+/363980
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
The GCP UI is nicer for editing triggers, and the gcloud command now has
beta support for import/export. It wants YAML format, though. Delete the
json versions and replace them with freshly pulled versions, including
the change to trigger from GCR.
Change-Id: I3a20951d94b9a9522f28b07cc772d097679fb5a2
Reviewed-on: https://go-review.googlesource.com/c/playground/+/327349
Trust: Heschi Kreinick <heschi@google.com>
Trust: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Don't share a cache namespace between clients wanting vet (new) and
not wanting vet (old).
This was causing issues like:
https://github.com/golang/go/issues/31944#issuecomment-493094932
And unrelated: a README deploy fix, broken from my earlier Makefile
cleanup.
Change-Id: Ibed7f91c739ac65e33ee8d73eed066a7a81f938c
Reviewed-on: https://go-review.googlesource.com/c/playground/+/177617
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
This change adds configuration to trigger a playground deploy when
master is updated. Configuration for deploying a build with the latest
release of go is shared in deploy/deploy.json. Cloud Build
configurations have been moved to the deploy directory.
In order to help share configurations, the build triggers will create a
separate deployment build asynchronously.
The README is updated to help describe common deployment scenarios.
Tested deploy steps with README instructions.
Updates golang/go#32606
Change-Id: I6eced05d3aa2904135e95e8b40e5a30a5b0b0488
Reviewed-on: https://go-review.googlesource.com/c/playground/+/185341
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This change includes configuration to build and deploy new releases of
the Go playground when a new tag of Go is released to Github. The
trigger is configured to filter tags to new, non-rc, non-beta releases
of Go.
This first commit simply implements releasing the current version of Go
configured for the playground. Changes to the build process to ensure
we're releasing the latest version of Go will be in a follow-up commit.
Updates golang/go#32606
Change-Id: I3b518fd3f02efcd8f510fd865f3370bea19f0e9b
Reviewed-on: https://go-review.googlesource.com/c/playground/+/183037
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Also, move the tests to their own file and extend them a bit, give
them names, and make the test step more verbose (only visible in
docker build anyway). They were hogging up the sandbox file.
Updates golang/go#31970
Change-Id: Id710ea613c77a5b16cc5e79545c0812d0f4650e3
Reviewed-on: https://go-review.googlesource.com/c/playground/+/176598
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Yury Smolsky <yury@smolsky.by>
It's unfortunate to introduce an extra step of setting a global
configuration value to the deploy process. It would be better if
this could be an application-scoped setting specified in the app.yaml
configuration. However, that doesn't seem to be possible, and after
reading through documentation and waiting to hear any suggestions at
golang/go#28046, I have not become aware of a better solution.
Document this approach for now, and if we learn of a better solution
in the future, this can be improved then.
Fixesgolang/go#28046
Change-Id: I2e9b7bbd38aa8313ff6eab0bf99dd2fe48f57544
Reviewed-on: https://go-review.googlesource.com/c/playground/+/164577
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
1. Pass the payload to `/compile` using `curl --upload` instead of
`curl --data`.
With the `--data` flag, curl encodes the data in a way that triggers
the call to `(*http.Request).FormValue` (sandbox.go:56) to consume the
request body. When we then attempt to decode the body as JSON
(sandbox.go:58), we then fail the request with `io.EOF`.
If we use the `--upload` flag instead, curl does not set the content
type to the problematic `application/x-www-form-urlencoded` value, and
the call to `FormValue` does not consume the body.
2. Add a name to the `docker run` command line.
(That makes it easier to kill the container when we're done with it.)
3. Remove a redundant copy of the “To submit changes…” sentence.
Change-Id: I314d904f626029306fecbfd25b166927dfa01029
Reviewed-on: https://go-review.googlesource.com/106215
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Since frontend was moved to the flex runtime, there is no longer
a reason to keep the two separate. Consolidate the two into one
service to reduce deployment complexity.
Change-Id: Ie64c17e1833ed94ac8bff7381963f683d824ca5d
Reviewed-on: https://go-review.googlesource.com/85456
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
+ Remove reliance on GAE-specific API calls
+ Adds instructions to do local dev using the datastore emulator
+ Small golint fixes
Update golang/go#21645
Change-Id: Icc7679fab4c166a3d8fef3043414d6069865661d
Reviewed-on: https://go-review.googlesource.com/84815
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Ian Lance Taylor
Robert Findley
Heschi Kreinick
Julie Qiu
John McCabe
Brad Fitzpatrick
Alexander Rakoczy
Dmitri Shuralyov
Bryan C. Mills
Andrew Bonventre
Chris Broadfoot
Johan Euphrosine