All functionality has been re-written to either wrap v2 directly
(e.g., binary serialization) or written to use v2 protobuf reflection
(e.g., text and json serialization). This is to done to reduce the
technical debt of maintaining the v1 module.
Change-Id: I6749fa58a465df991c8fcf89e8d7077d64a2cfdb
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/213901
Reviewed-by: Damien Neil <dneil@google.com>
Local changes were made to account for the following upstream changes:
* Internal fields are now unexported:
XXX_sizecache -> sizeCache
XXX_unrecognized -> unknownFields
XXX_InternalExtensions -> extensionFields
* Every message has a *protoimpl.MessageState as the first field
* Well-known types no longer have an XXX_WellKnownType method
* MessageSets now lack the protobuf_messageset tag
* Extensions of MessageSets now use their real name
* Messages no longer have a XXX_OneofWrappers method
Change-Id: Iec13a8b113d523ed11493fa713e7c6df8895b9ed
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/186538
Reviewed-by: Damien Neil <dneil@google.com>
CL/177619 adds scaffolding to support lazy extensions.
This CL changes the v1 logic to call the equivalent opaque methods.
This CL does not add lazy extension support.
Change-Id: I7954f87a6ec59b06ad2e034f625bb4fc40c8aefd
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/177620
Reviewed-by: Damien Neil <dneil@google.com>
Temporarily remove go.mod, since we can't generate an accurate one until
the corresponding v2 change is submitted.
Change-Id: I183cb0dde8d01065b955cf4b70e76ae43ac88885
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/176999
Reviewed-by: Joe Tsai <thebrokentoaster@gmail.com>
This CL implements v1 registration in terms of v2 registration,
unifying the two global states.
Change-Id: I1c28e5f3392dcfa7cd7b2933f2c0974456a182a9
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/168350
Reviewed-by: Herbie Ong <herbie@google.com>
Using the proto_reimpl build tag, we can control whether we go through
the current logic or the re-implemented logic. This allows us to re-use
all of the current tests with little to no modification to test the
new implementation.
Change-Id: I6d6beec05b859014f63193bf2c7530afa49eccd4
Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/167767
Reviewed-by: Herbie Ong <herbie@google.com>
Create a new package protoapi that contains the minimum set of types depended
upon by generated messages so that a generated message implemented the v2
APIs do not need to import the v1 proto runtime.
Some types like proto.Buffer are not included here since those dependencies
are going away with PR#760.
Explicitly document that no one should import this package directly,
so we have the flexibility to remove this package if necessary.
Change-Id: Iddd0c697c9170b809a587bee626347e4ffdddbc7
Reviewed-on: https://go-review.googlesource.com/c/151347
Reviewed-by: Damien Neil <dneil@google.com>
Consistently use the short license header for all Go source files in a manner
similar to all the other golang.org/x projects. Some source files were entirely
missing the license header.
In the mean time, fix the package docstring for most packages to consistently
use "//" notation instead of "/*".
Change-Id: I2848ede6fb6ffdfc2ee7992e0d71d79b52bb61e3
Reviewed-on: https://go-review.googlesource.com/c/151405
Reviewed-by: Herbie Ong <herbie@google.com>
Not all proto.Message implementations will be updated to be
using the most recent protoc-gen-go. Thus, they will lack an
XXX_DiscardUnknown method. Add logic to handle older protobufs.
Found with honnef.co/go/tools/cmd/gosimple.
proto/all_test.go:522:12: should use !strings.Contains(err.Error(), "Kind") instead (S1003)
proto/all_test.go:1170:3: should merge variable declaration with assignment on next line (S1021)
proto/all_test.go:1857:5: should use !strings.Contains(err.Error(), "RequiredField.Label") instead (S1003)
proto/all_test.go:1873:5: should use !strings.Contains(err.Error(), "RequiredField.{Unknown}") instead (S1003)
proto/all_test.go:1882:5: should use !strings.Contains(err.Error(), "RequiredField.Label") instead (S1003)
proto/equal.go:149:2: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008)
proto/message_set.go:97:2: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (S1008)
proto/properties.go:386:4: redundant break statement (S1023)
proto/properties.go:434:4: redundant break statement (S1023)
proto/properties.go:510:5: redundant break statement (S1023)
proto/properties.go:520:5: redundant break statement (S1023)
proto/properties.go:539:5: redundant break statement (S1023)
proto/text.go:482:2: 'if err != nil { return err }; return nil' can be simplified to 'return err' (S1013)
proto/text_parser.go:891:2: 'if pe != nil { return pe }; return nil' can be simplified to 'return pe' (S1013)
protoc-gen-go/generator/generator.go:137:22: should use make([]string, n) instead (S1019)
Major changes:
* New table-driven optimization for marshal, unmarshal, and merge
* Unknown field preservation for Proto3
* Generated source-file annotation for Kythe
* Various bug fixes
Joe Tsai
Damien Neil
Tamir Duberstein