sys/unix
Tobias Klauser 3249cb6984 unix: drop incorrect Fsetxattr size return value
Fsetxattr should just return an error (like Setxattr and like Fsetxattr
is already doing on FreeBSD).

Fix for CL 128176

Updates golang/go#26832

Change-Id: Id1c1315d9eb6952128e0c0ce44b19060e0403cc0
Reviewed-on: https://go-review.googlesource.com/128495
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
2018-08-08 14:12:55 +00:00
..
linux unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
.gitignore unix: add unix.test to .gitignore 2017-12-13 15:44:37 +00:00
README.md unix: generate all Linux go files from source 2017-04-21 00:52:44 +00:00
affinity_linux.go unix: fix cpuset size argument in sched_affinity syscall 2018-02-01 15:31:26 +00:00
aliases.go unix, windows: add type aliases to std syscall for Signal, Errno, SysProcAttr 2018-08-02 20:32:16 +00:00
asm_darwin_386.s unix: add gccgo support 2015-05-07 23:38:20 +00:00
asm_darwin_amd64.s unix: add gccgo support 2015-05-07 23:38:20 +00:00
asm_darwin_arm.s unix: add darwin/arm support 2015-05-18 19:16:10 +00:00
asm_darwin_arm64.s unix: add darwin/arm64 support 2015-05-18 19:16:22 +00:00
asm_dragonfly_amd64.s unix: address vet's finding of wrong argument size 2018-05-09 20:58:23 +00:00
asm_freebsd_386.s unix: add gccgo support 2015-05-07 23:38:20 +00:00
asm_freebsd_amd64.s unix: add gccgo support 2015-05-07 23:38:20 +00:00
asm_freebsd_arm.s unix: add gccgo support 2015-05-07 23:38:20 +00:00
asm_linux_386.s unix: add SyscallNoError and RawSyscallNoError on Linux 2018-01-03 16:03:02 +00:00
asm_linux_amd64.s unix: add SyscallNoError and RawSyscallNoError on Linux 2018-01-03 16:03:02 +00:00
asm_linux_arm.s unix: match seek argument size to signature on linux/arm 2018-01-10 07:17:38 +00:00
asm_linux_arm64.s unix: fix typo in unix/asm_linux_arm64.s made in 28a7276 2018-01-04 16:29:08 +00:00
asm_linux_mips64x.s unix: add SyscallNoError and RawSyscallNoError on Linux 2018-01-03 16:03:02 +00:00
asm_linux_mipsx.s unix: add SyscallNoError and RawSyscallNoError on Linux 2018-01-03 16:03:02 +00:00
asm_linux_ppc64x.s unix: add SyscallNoError and RawSyscallNoError on Linux 2018-01-03 16:03:02 +00:00
asm_linux_s390x.s unix: add SyscallNoError and RawSyscallNoError on Linux 2018-01-03 16:03:02 +00:00
asm_netbsd_386.s unix: add gccgo support 2015-05-07 23:38:20 +00:00
asm_netbsd_amd64.s unix: add gccgo support 2015-05-07 23:38:20 +00:00
asm_netbsd_arm.s unix: add gccgo support 2015-05-07 23:38:20 +00:00
asm_openbsd_386.s unix: add gccgo support 2015-05-07 23:38:20 +00:00
asm_openbsd_amd64.s unix: add gccgo support 2015-05-07 23:38:20 +00:00
asm_openbsd_arm.s unix: add openbsd/arm support (in theory) 2017-08-09 03:45:07 +00:00
asm_solaris_amd64.s unix: fix vet warnings on solaris 2017-05-11 21:48:19 +00:00
bluetooth_linux.go syscall: add bluetooth constants for linux 2016-04-08 01:02:42 +00:00
cap_freebsd.go unix: add ErrnoName and SignalName 2018-05-04 06:42:12 +00:00
constants.go unix: Add [RWX]_OK constants for Access 2015-03-20 06:12:11 +00:00
creds_test.go unix: fix TestSCMCredentials to not fail when root 2018-05-11 16:50:53 +00:00
dev_darwin.go unix: convert major/minor to uint64 before shifting in Mkdev on Darwin/*BSD 2017-09-12 19:57:40 +00:00
dev_dragonfly.go unix: convert major/minor to uint64 before shifting in Mkdev on Darwin/*BSD 2017-09-12 19:57:40 +00:00
dev_freebsd.go unix: convert major/minor to uint64 before shifting in Mkdev on Darwin/*BSD 2017-09-12 19:57:40 +00:00
dev_linux.go unix: fix potential overflow in Mkdev on Linux 2017-09-12 14:41:02 +00:00
dev_linux_test.go unix: fix or skip failing tests on android and iOS 2018-05-24 13:58:53 +00:00
dev_netbsd.go unix: convert major/minor to uint64 before shifting in Mkdev on Darwin/*BSD 2017-09-12 19:57:40 +00:00
dev_openbsd.go unix: add Major, Minor and Mkdev functions on OpenBSD 2017-09-12 22:26:33 +00:00
dirent.go unix: use ParseDirent from syscall 2018-01-22 08:19:59 +00:00
endian_big.go unix: add mips and mipsle to endian files 2017-04-06 17:19:08 +00:00
endian_little.go unix: add mips and mipsle to endian files 2017-04-06 17:19:08 +00:00
env_unix.go unix: move Unsetenv into env_unix.go 2018-01-07 21:14:47 +00:00
errors_freebsd_386.go unix: re-enable Capsicum on FreeBSD 386 2017-07-28 17:44:21 +00:00
errors_freebsd_amd64.go unix: re-enable Capsicum on FreeBSD 386 2017-07-28 17:44:21 +00:00
errors_freebsd_arm.go unix: fix freebsd/arm build, fix freebsd/{386,arm} tests 2017-08-08 15:06:51 +00:00
example_test.go unix: fix example 2018-03-19 15:33:14 +00:00
export_test.go all: single space after period 2017-10-25 20:39:07 +00:00
fcntl.go unix: do not return non-nil error for 0 errno in FcntlInt 2018-06-27 14:26:11 +00:00
fcntl_linux_32bit.go unix: add FcntlInt 2018-04-04 20:37:33 +00:00
gccgo.go unix: restore gccgo support 2018-01-09 00:06:53 +00:00
gccgo_c.c unix: drop use function stub for gccgo 2018-06-10 12:29:00 +00:00
gccgo_linux_amd64.go all: single space after period 2017-10-25 20:39:07 +00:00
ioctl.go unix: document IoctlSetWinsize and IoctlSetTermios and fix pointer lifetime 2018-07-24 21:28:12 +00:00
mkall.sh unix: remove dragonfly/386 from mkall.sh 2017-11-23 18:29:49 +00:00
mkerrors.sh unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
mkpost.go unix: add tpacket types and constants on Linux 2018-05-14 14:36:08 +00:00
mksyscall.pl unix: use SyscallNoError and RawSyscallNoError on Linux only 2018-01-30 06:43:25 +00:00
mksyscall_solaris.pl unix: generate all Linux go files from source 2017-04-21 00:52:44 +00:00
mksysctl_openbsd.pl unix: follow convention for generated code comment 2018-06-14 13:37:17 +00:00
mksysnum_darwin.pl unix: generate all Linux go files from source 2017-04-21 00:52:44 +00:00
mksysnum_dragonfly.pl unix: generate all Linux go files from source 2017-04-21 00:52:44 +00:00
mksysnum_freebsd.pl unix: add some FreeBSD Capsicum support. 2017-07-19 20:48:12 +00:00
mksysnum_netbsd.pl unix: unify memory functions on BSD 2017-08-17 23:46:08 +00:00
mksysnum_openbsd.pl unix: generate all Linux go files from source 2017-04-21 00:52:44 +00:00
mmap_unix_test.go unix: fix TestMmap crash on openbsd/386 2017-09-21 19:16:43 +00:00
openbsd_pledge.go unix: update openbsd/amd64 to OpenBSD 6.3 2018-05-22 14:59:51 +00:00
openbsd_test.go unix: add support for OpenBSD pledge 2017-03-22 23:48:10 +00:00
pagesize_unix.go all: single space after period 2017-10-25 20:39:07 +00:00
race.go all: single space after period 2017-10-25 20:39:07 +00:00
race0.go all: single space after period 2017-10-25 20:39:07 +00:00
sockcmsg_linux.go all: single space after period 2017-10-25 20:39:07 +00:00
sockcmsg_unix.go unix: fix Send{msg,msgN}, Recvmsg and control message handling on solaris 2017-05-11 21:48:29 +00:00
str.go unix: fix infinite recursion in itoa 2015-05-13 20:12:53 +00:00
syscall.go unix: use strings.IndexByte instead of for loops 2018-03-22 16:54:03 +00:00
syscall_bsd.go unix: implement RFCOMM sockets on Linux 2018-07-09 06:02:33 +00:00
syscall_bsd_test.go unix: add TestSelect for *BSD 2017-12-22 14:35:20 +00:00
syscall_darwin.go unix: document IoctlSetWinsize and IoctlSetTermios and fix pointer lifetime 2018-07-24 21:28:12 +00:00
syscall_darwin_386.go all: single space after period 2017-10-25 20:39:07 +00:00
syscall_darwin_amd64.go all: single space after period 2017-10-25 20:39:07 +00:00
syscall_darwin_arm.go unix: add SYS___SYSCTL on darwin/arm 2017-11-21 20:27:57 +00:00
syscall_darwin_arm64.go all: single space after period 2017-10-25 20:39:07 +00:00
syscall_darwin_test.go unix: add tests for *xattr functions 2018-05-22 22:42:04 +00:00
syscall_dragonfly.go unix: document IoctlSetWinsize and IoctlSetTermios and fix pointer lifetime 2018-07-24 21:28:12 +00:00
syscall_dragonfly_amd64.go unix: unify NsecToTime{spec,val}, fix for times < 1970 2017-10-25 08:56:33 +00:00
syscall_freebsd.go unix: remove *xattr from list of unimplemented syscalls on FreeBSD 2018-08-07 14:11:23 +00:00
syscall_freebsd_386.go unix: unify NsecToTime{spec,val}, fix for times < 1970 2017-10-25 08:56:33 +00:00
syscall_freebsd_amd64.go unix: unify NsecToTime{spec,val}, fix for times < 1970 2017-10-25 08:56:33 +00:00
syscall_freebsd_arm.go unix: unify NsecToTime{spec,val}, fix for times < 1970 2017-10-25 08:56:33 +00:00
syscall_freebsd_test.go unix: add tests for *xattr functions 2018-05-22 22:42:04 +00:00
syscall_linux.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
syscall_linux_386.go unix: don't use deprecated syscalls on linux/arm64 2018-06-19 16:09:47 +00:00
syscall_linux_amd64.go unix: don't use deprecated syscalls on linux/arm64 2018-06-19 16:09:47 +00:00
syscall_linux_amd64_gc.go x/sys/unix: move gccgo redeclared functions to separate files 2016-12-14 19:05:18 +00:00
syscall_linux_arm.go unix: don't use deprecated syscalls on linux/arm64 2018-06-19 16:09:47 +00:00
syscall_linux_arm64.go unix: don't use deprecated syscalls on linux/arm64 2018-06-19 16:09:47 +00:00
syscall_linux_gc.go unix: move gccgo redeclared *SyscallNoError functions to a separate file 2018-02-02 13:58:01 +00:00
syscall_linux_gc_386.go unix: support compiling with gccgo on linux/386 2018-06-11 07:33:41 +00:00
syscall_linux_gccgo_386.go unix: support compiling with gccgo on linux/386 2018-06-11 07:33:41 +00:00
syscall_linux_gccgo_arm.go unix: support compiling with gccgo on linux/386 2018-06-11 07:33:41 +00:00
syscall_linux_mips64x.go unix: don't use deprecated syscalls on linux/arm64 2018-06-19 16:09:47 +00:00
syscall_linux_mipsx.go unix: implement pipe() on linux/mips 2018-07-27 19:22:02 +00:00
syscall_linux_ppc64x.go unix: don't use deprecated syscalls on linux/arm64 2018-06-19 16:09:47 +00:00
syscall_linux_s390x.go unix: don't use deprecated syscalls on linux/arm64 2018-06-19 16:09:47 +00:00
syscall_linux_sparc64.go unix: don't use deprecated syscalls on linux/arm64 2018-06-19 16:09:47 +00:00
syscall_linux_test.go unix: support Faccessat flags argument 2018-07-27 23:04:15 +00:00
syscall_netbsd.go unix: document IoctlSetWinsize and IoctlSetTermios and fix pointer lifetime 2018-07-24 21:28:12 +00:00
syscall_netbsd_386.go unix: unify NsecToTime{spec,val}, fix for times < 1970 2017-10-25 08:56:33 +00:00
syscall_netbsd_amd64.go unix: unify NsecToTime{spec,val}, fix for times < 1970 2017-10-25 08:56:33 +00:00
syscall_netbsd_arm.go unix: unify NsecToTime{spec,val}, fix for times < 1970 2017-10-25 08:56:33 +00:00
syscall_openbsd.go unix: document IoctlSetWinsize and IoctlSetTermios and fix pointer lifetime 2018-07-24 21:28:12 +00:00
syscall_openbsd_386.go unix: unify NsecToTime{spec,val}, fix for times < 1970 2017-10-25 08:56:33 +00:00
syscall_openbsd_amd64.go unix: update openbsd/amd64 to OpenBSD 6.3 2018-05-22 14:59:51 +00:00
syscall_openbsd_arm.go unix: unify NsecToTime{spec,val}, fix for times < 1970 2017-10-25 08:56:33 +00:00
syscall_solaris.go unix: document IoctlSetWinsize and IoctlSetTermios and fix pointer lifetime 2018-07-24 21:28:12 +00:00
syscall_solaris_amd64.go unix: add sendfile support on Solaris 2018-03-29 13:14:28 +00:00
syscall_solaris_test.go unix: add Select on Solaris 2017-12-22 14:35:06 +00:00
syscall_test.go unix: enable TestUname for all GOOSes 2017-12-08 15:33:48 +00:00
syscall_unix.go unix: implement RFCOMM sockets on Linux 2018-07-09 06:02:33 +00:00
syscall_unix_gc.go x/sys/unix: move gccgo redeclared functions to separate files 2016-12-14 19:05:18 +00:00
syscall_unix_test.go unix: do not return non-nil error for 0 errno in FcntlInt 2018-06-27 14:26:11 +00:00
timestruct.go unix: add function for converting time.Time to Timespec 2017-12-13 16:20:35 +00:00
timestruct_test.go unix: add function for converting time.Time to Timespec 2017-12-13 16:20:35 +00:00
types_darwin.go unix: add Uname on Darwin 2017-11-13 20:21:12 +00:00
types_dragonfly.go unix: add Getcwd to support Getwd on all BSDs 2017-12-14 07:29:55 +00:00
types_freebsd.go unix: add S_IRWXG and S_IRWXO to FreeBSD types 2018-08-08 13:53:31 +00:00
types_netbsd.go unix: add Fadvise on NetBSD 2018-03-21 18:38:08 +00:00
types_openbsd.go unix: add Getcwd to support Getwd on all BSDs 2017-12-14 07:29:55 +00:00
types_solaris.go unix: add Poll function on Solaris 2017-10-28 10:13:51 +00:00
xattr_test.go unix: fix TestXattr on android 2018-05-24 22:17:17 +00:00
zerrors_darwin_386.go unix: add symlink-safe *xattr functions on darwin 2018-05-23 21:11:48 +00:00
zerrors_darwin_amd64.go unix: add symlink-safe *xattr functions on darwin 2018-05-23 21:11:48 +00:00
zerrors_darwin_arm.go unix: add symlink-safe *xattr functions on darwin 2018-05-23 21:11:48 +00:00
zerrors_darwin_arm64.go unix: add symlink-safe *xattr functions on darwin 2018-05-23 21:11:48 +00:00
zerrors_dragonfly_amd64.go unix: add ErrnoName and SignalName 2018-05-04 06:42:12 +00:00
zerrors_freebsd_386.go unix: add ErrnoName and SignalName 2018-05-04 06:42:12 +00:00
zerrors_freebsd_amd64.go unix: add ErrnoName and SignalName 2018-05-04 06:42:12 +00:00
zerrors_freebsd_arm.go unix: add ErrnoName and SignalName 2018-05-04 06:42:12 +00:00
zerrors_linux_386.go unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
zerrors_linux_amd64.go unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
zerrors_linux_arm.go unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
zerrors_linux_arm64.go unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
zerrors_linux_mips.go unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
zerrors_linux_mips64.go unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
zerrors_linux_mips64le.go unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
zerrors_linux_mipsle.go unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
zerrors_linux_ppc64.go unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
zerrors_linux_ppc64le.go unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
zerrors_linux_s390x.go unix: add Renameat2 on Linux 2018-08-06 19:25:00 +00:00
zerrors_linux_sparc64.go unix: follow convention for generated code comment 2018-06-14 13:37:17 +00:00
zerrors_netbsd_386.go unix: add ErrnoName and SignalName 2018-05-04 06:42:12 +00:00
zerrors_netbsd_amd64.go unix: add ErrnoName and SignalName 2018-05-04 06:42:12 +00:00
zerrors_netbsd_arm.go unix: add ErrnoName and SignalName 2018-05-04 06:42:12 +00:00
zerrors_openbsd_386.go unix: add ErrnoName and SignalName 2018-05-04 06:42:12 +00:00
zerrors_openbsd_amd64.go unix: fix OpenBSD codegen to include F_OK 2018-08-06 08:24:29 +00:00
zerrors_openbsd_arm.go unix: add ErrnoName and SignalName 2018-05-04 06:42:12 +00:00
zerrors_solaris_amd64.go unix: add ErrnoName and SignalName 2018-05-04 06:42:12 +00:00
zptrace386_linux.go unix: single space after period in generated zptrace header 2017-10-27 12:34:53 +00:00
zptracearm_linux.go unix: single space after period in generated zptrace header 2017-10-27 12:34:53 +00:00
zptracemips_linux.go unix: single space after period in generated zptrace header 2017-10-27 12:34:53 +00:00
zptracemipsle_linux.go unix: single space after period in generated zptrace header 2017-10-27 12:34:53 +00:00
zsyscall_darwin_386.go unix: add {get,set,remove,list}xattr on darwin 2018-05-22 21:16:09 +00:00
zsyscall_darwin_amd64.go unix: add {get,set,remove,list}xattr on darwin 2018-05-22 21:16:09 +00:00
zsyscall_darwin_arm.go unix: add {get,set,remove,list}xattr on darwin 2018-05-22 21:16:09 +00:00
zsyscall_darwin_arm64.go unix: add {get,set,remove,list}xattr on darwin 2018-05-22 21:16:09 +00:00
zsyscall_dragonfly_amd64.go unix: add Fchmodat on DragonflyBSD 2018-03-20 10:47:26 +00:00
zsyscall_freebsd_386.go unix: add Fstatat on FreeBSD 2018-03-14 13:43:48 +00:00
zsyscall_freebsd_amd64.go unix: add Fstatat on FreeBSD 2018-03-14 13:43:48 +00:00
zsyscall_freebsd_arm.go unix: add Fstatat on FreeBSD 2018-03-14 13:43:48 +00:00
zsyscall_linux_386.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
zsyscall_linux_amd64.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
zsyscall_linux_arm.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
zsyscall_linux_arm64.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
zsyscall_linux_mips.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
zsyscall_linux_mips64.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
zsyscall_linux_mips64le.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
zsyscall_linux_mipsle.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
zsyscall_linux_ppc64.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
zsyscall_linux_ppc64le.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
zsyscall_linux_s390x.go unix: drop incorrect Fsetxattr size return value 2018-08-08 14:12:55 +00:00
zsyscall_linux_sparc64.go unix: don't use deprecated syscalls on linux/arm64 2018-06-19 16:09:47 +00:00
zsyscall_netbsd_386.go unix: add Faccessat on NetBSD 2018-06-13 14:54:33 +00:00
zsyscall_netbsd_amd64.go unix: add Faccessat on NetBSD 2018-06-13 14:54:33 +00:00
zsyscall_netbsd_arm.go unix: add Faccessat on NetBSD 2018-06-13 14:54:33 +00:00
zsyscall_openbsd_386.go unix: add Faccessat on OpenBSD 2018-06-13 14:36:30 +00:00
zsyscall_openbsd_amd64.go unix: add Faccessat on OpenBSD 2018-06-13 14:36:30 +00:00
zsyscall_openbsd_arm.go unix: add Faccessat on OpenBSD 2018-06-13 14:36:30 +00:00
zsyscall_solaris_amd64.go unix: add Faccessat on Solaris 2018-06-19 13:15:59 +00:00
zsysctl_openbsd_386.go unix: follow convention for generated code comment 2018-06-14 13:37:17 +00:00
zsysctl_openbsd_amd64.go unix: follow convention for generated code comment 2018-06-14 13:37:17 +00:00
zsysctl_openbsd_arm.go unix: follow convention for generated code comment 2018-06-14 13:37:17 +00:00
zsysnum_darwin_386.go unix: regenerate for macOS 10.13/iOS 11.1 2017-11-06 15:14:41 +00:00
zsysnum_darwin_amd64.go unix: regenerate for macOS 10.13/iOS 11.1 2017-11-06 15:14:41 +00:00
zsysnum_darwin_arm.go unix: regenerate for macOS 10.13/iOS 11.1 2017-11-06 15:14:41 +00:00
zsysnum_darwin_arm64.go unix: regenerate for macOS 10.13/iOS 11.1 2017-11-06 15:14:41 +00:00
zsysnum_dragonfly_amd64.go unix: sync with DragonFly BSD 4.8 kernel 2017-04-27 04:18:56 +00:00
zsysnum_freebsd_386.go unix: re-enable Capsicum on FreeBSD 386 2017-07-28 17:44:21 +00:00
zsysnum_freebsd_amd64.go unix: add some FreeBSD Capsicum support. 2017-07-19 20:48:12 +00:00
zsysnum_freebsd_arm.go unix: fix freebsd/arm build, fix freebsd/{386,arm} tests 2017-08-08 15:06:51 +00:00
zsysnum_linux_386.go unix: update Linux to v4.13 kernel and v2.26 glibc 2017-09-07 22:07:22 +00:00
zsysnum_linux_amd64.go unix: update Linux to v4.13 kernel and v2.26 glibc 2017-09-07 22:07:22 +00:00
zsysnum_linux_arm.go unix: update Linux to v4.13 kernel and v2.26 glibc 2017-09-07 22:07:22 +00:00
zsysnum_linux_arm64.go unix: update Linux to v4.13 kernel and v2.26 glibc 2017-09-07 22:07:22 +00:00
zsysnum_linux_mips.go unix: update Linux to v4.13 kernel and v2.26 glibc 2017-09-07 22:07:22 +00:00
zsysnum_linux_mips64.go unix: update Linux to v4.13 kernel and v2.26 glibc 2017-09-07 22:07:22 +00:00
zsysnum_linux_mips64le.go unix: update Linux to v4.13 kernel and v2.26 glibc 2017-09-07 22:07:22 +00:00
zsysnum_linux_mipsle.go unix: update Linux to v4.13 kernel and v2.26 glibc 2017-09-07 22:07:22 +00:00
zsysnum_linux_ppc64.go unix: update Dockerfile to Linux 4.16 and Go 1.10.1 2018-04-06 13:57:29 +00:00
zsysnum_linux_ppc64le.go unix: update Dockerfile to Linux 4.16 and Go 1.10.1 2018-04-06 13:57:29 +00:00
zsysnum_linux_s390x.go unix: update Dockerfile to Ubuntu 18.04, Linux 4.17, and Go 1.10.3 2018-06-12 14:22:14 +00:00
zsysnum_linux_sparc64.go unix: follow convention for generated code comment 2018-06-14 13:37:17 +00:00
zsysnum_netbsd_386.go unix: follow convention for generated code comment 2018-06-14 13:37:17 +00:00
zsysnum_netbsd_amd64.go unix: follow convention for generated code comment 2018-06-14 13:37:17 +00:00
zsysnum_netbsd_arm.go unix: follow convention for generated code comment 2018-06-14 13:37:17 +00:00
zsysnum_openbsd_386.go unix: follow convention for generated code comment 2018-06-14 13:37:17 +00:00
zsysnum_openbsd_amd64.go unix: fix OpenBSD codegen to include F_OK 2018-08-06 08:24:29 +00:00
zsysnum_openbsd_arm.go unix: follow convention for generated code comment 2018-06-14 13:37:17 +00:00
ztypes_darwin_386.go unix: don't export padding fields on Darwin 2018-03-22 15:36:57 +00:00
ztypes_darwin_amd64.go unix: don't export padding fields on Darwin 2018-03-22 15:36:57 +00:00
ztypes_darwin_arm.go unix: don't export padding fields on Darwin 2018-03-22 15:36:57 +00:00
ztypes_darwin_arm64.go unix: don't export padding fields on Darwin 2018-03-22 15:36:57 +00:00
ztypes_dragonfly_amd64.go unix: don't export padding fields on DragonflyBSD 2018-03-14 12:53:57 +00:00
ztypes_freebsd_386.go unix: add S_IRWXG and S_IRWXO to FreeBSD types 2018-08-08 13:53:31 +00:00
ztypes_freebsd_amd64.go unix: add S_IRWXG and S_IRWXO to FreeBSD types 2018-08-08 13:53:31 +00:00
ztypes_freebsd_arm.go unix: add S_IRWXG and S_IRWXO to FreeBSD types 2018-08-08 13:53:31 +00:00
ztypes_linux_386.go unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
ztypes_linux_amd64.go unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
ztypes_linux_arm.go unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
ztypes_linux_arm64.go unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
ztypes_linux_mips.go unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
ztypes_linux_mips64.go unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
ztypes_linux_mips64le.go unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
ztypes_linux_mipsle.go unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
ztypes_linux_ppc64.go unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
ztypes_linux_ppc64le.go unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
ztypes_linux_s390x.go unix: add IFLA_INFO_KIND on Linux 2018-08-07 15:54:10 +00:00
ztypes_linux_sparc64.go unix: add IFLA attributes on linux/sparc64 2018-03-16 20:22:16 +00:00
ztypes_netbsd_386.go unix: add Fadvise on NetBSD 2018-03-21 18:38:08 +00:00
ztypes_netbsd_amd64.go unix: add Fadvise on NetBSD 2018-03-21 18:38:08 +00:00
ztypes_netbsd_arm.go unix: add Fadvise on NetBSD 2018-03-21 18:38:08 +00:00
ztypes_openbsd_386.go unix: add Getcwd to support Getwd on all BSDs 2017-12-14 07:29:55 +00:00
ztypes_openbsd_amd64.go unix: update openbsd/amd64 to OpenBSD 6.3 2018-05-22 14:59:51 +00:00
ztypes_openbsd_arm.go unix: add Getcwd to support Getwd on all BSDs 2017-12-14 07:29:55 +00:00
ztypes_solaris_amd64.go unix: don't export padding fields on Solaris 2018-03-14 12:41:14 +00:00

README.md

Building sys/unix

The sys/unix package provides access to the raw system call interface of the underlying operating system. See: https://godoc.org/golang.org/x/sys/unix

Porting Go to a new architecture/OS combination or adding syscalls, types, or constants to an existing architecture/OS pair requires some manual effort; however, there are tools that automate much of the process.

Build Systems

There are currently two ways we generate the necessary files. We are currently migrating the build system to use containers so the builds are reproducible. This is being done on an OS-by-OS basis. Please update this documentation as components of the build system change.

Old Build System (currently for GOOS != "Linux" || GOARCH == "sparc64")

The old build system generates the Go files based on the C header files present on your system. This means that files for a given GOOS/GOARCH pair must be generated on a system with that OS and architecture. This also means that the generated code can differ from system to system, based on differences in the header files.

To avoid this, if you are using the old build system, only generate the Go files on an installation with unmodified header files. It is also important to keep track of which version of the OS the files were generated from (ex. Darwin 14 vs Darwin 15). This makes it easier to track the progress of changes and have each OS upgrade correspond to a single change.

To build the files for your current OS and architecture, make sure GOOS and GOARCH are set correctly and run mkall.sh. This will generate the files for your specific system. Running mkall.sh -n shows the commands that will be run.

Requirements: bash, perl, go

New Build System (currently for GOOS == "Linux" && GOARCH != "sparc64")

The new build system uses a Docker container to generate the go files directly from source checkouts of the kernel and various system libraries. This means that on any platform that supports Docker, all the files using the new build system can be generated at once, and generated files will not change based on what the person running the scripts has installed on their computer.

The OS specific files for the new build system are located in the ${GOOS} directory, and the build is coordinated by the ${GOOS}/mkall.go program. When the kernel or system library updates, modify the Dockerfile at ${GOOS}/Dockerfile to checkout the new release of the source.

To build all the files under the new build system, you must be on an amd64/Linux system and have your GOOS and GOARCH set accordingly. Running mkall.sh will then generate all of the files for all of the GOOS/GOARCH pairs in the new build system. Running mkall.sh -n shows the commands that will be run.

Requirements: bash, perl, go, docker

Component files

This section describes the various files used in the code generation process. It also contains instructions on how to modify these files to add a new architecture/OS or to add additional syscalls, types, or constants. Note that if you are using the new build system, the scripts cannot be called normally. They must be called from within the docker container.

asm files

The hand-written assembly file at asm_${GOOS}_${GOARCH}.s implements system call dispatch. There are three entry points:

  func Syscall(trap, a1, a2, a3 uintptr) (r1, r2, err uintptr)
  func Syscall6(trap, a1, a2, a3, a4, a5, a6 uintptr) (r1, r2, err uintptr)
  func RawSyscall(trap, a1, a2, a3 uintptr) (r1, r2, err uintptr)

The first and second are the standard ones; they differ only in how many arguments can be passed to the kernel. The third is for low-level use by the ForkExec wrapper. Unlike the first two, it does not call into the scheduler to let it know that a system call is running.

When porting Go to an new architecture/OS, this file must be implemented for each GOOS/GOARCH pair.

mksysnum

Mksysnum is a script located at ${GOOS}/mksysnum.pl (or mksysnum_${GOOS}.pl for the old system). This script takes in a list of header files containing the syscall number declarations and parses them to produce the corresponding list of Go numeric constants. See zsysnum_${GOOS}_${GOARCH}.go for the generated constants.

Adding new syscall numbers is mostly done by running the build on a sufficiently new installation of the target OS (or updating the source checkouts for the new build system). However, depending on the OS, you make need to update the parsing in mksysnum.

mksyscall.pl

The syscall.go, syscall_${GOOS}.go, syscall_${GOOS}_${GOARCH}.go are hand-written Go files which implement system calls (for unix, the specific OS, or the specific OS/Architecture pair respectively) that need special handling and list //sys comments giving prototypes for ones that can be generated.

The mksyscall.pl script takes the //sys and //sysnb comments and converts them into syscalls. This requires the name of the prototype in the comment to match a syscall number in the zsysnum_${GOOS}_${GOARCH}.go file. The function prototype can be exported (capitalized) or not.

Adding a new syscall often just requires adding a new //sys function prototype with the desired arguments and a capitalized name so it is exported. However, if you want the interface to the syscall to be different, often one will make an unexported //sys prototype, an then write a custom wrapper in syscall_${GOOS}.go.

types files

For each OS, there is a hand-written Go file at ${GOOS}/types.go (or types_${GOOS}.go on the old system). This file includes standard C headers and creates Go type aliases to the corresponding C types. The file is then fed through godef to get the Go compatible definitions. Finally, the generated code is fed though mkpost.go to format the code correctly and remove any hidden or private identifiers. This cleaned-up code is written to ztypes_${GOOS}_${GOARCH}.go.

The hardest part about preparing this file is figuring out which headers to include and which symbols need to be #defined to get the actual data structures that pass through to the kernel system calls. Some C libraries preset alternate versions for binary compatibility and translate them on the way in and out of system calls, but there is almost always a #define that can get the real ones. See types_darwin.go and linux/types.go for examples.

To add a new type, add in the necessary include statement at the top of the file (if it is not already there) and add in a type alias line. Note that if your type is significantly different on different architectures, you may need some #if/#elif macros in your include statements.

mkerrors.sh

This script is used to generate the system's various constants. This doesn't just include the error numbers and error strings, but also the signal numbers an a wide variety of miscellaneous constants. The constants come from the list of include files in the includes_${uname} variable. A regex then picks out the desired #define statements, and generates the corresponding Go constants. The error numbers and strings are generated from #include <errno.h>, and the signal numbers and strings are generated from #include <signal.h>. All of these constants are written to zerrors_${GOOS}_${GOARCH}.go via a C program, _errors.c, which prints out all the constants.

To add a constant, add the header that includes it to the appropriate variable. Then, edit the regex (if necessary) to match the desired constant. Avoid making the regex too broad to avoid matching unintended constants.

Generated files

zerror_${GOOS}_${GOARCH}.go

A file containing all of the system's generated error numbers, error strings, signal numbers, and constants. Generated by mkerrors.sh (see above).

zsyscall_${GOOS}_${GOARCH}.go

A file containing all the generated syscalls for a specific GOOS and GOARCH. Generated by mksyscall.pl (see above).

zsysnum_${GOOS}_${GOARCH}.go

A list of numeric constants for all the syscall number of the specific GOOS and GOARCH. Generated by mksysnum (see above).

ztypes_${GOOS}_${GOARCH}.go

A file containing Go types for passing into (or returning from) syscalls. Generated by godefs and the types file (see above).