From 198986d2ddbacf9079af2ab61e6e24fda15631a1 Mon Sep 17 00:00:00 2001
From: Tim King <taking@google.com>
Date: Thu, 12 Sep 2024 12:40:51 -0700
Subject: [PATCH] go/ssa: go/ssa: disable TestTypeparamTest on wasm

watchflakes reported additional test cases for TestTypeparamTest on
wasm. Skipping the test when on wasm.

Fixes golang/go#69410
Fixes golang/go#69409

Change-Id: Icfe5da007bf7411e9875313bc1b190751f1c1a15
Reviewed-on: https://go-review.googlesource.com/c/tools/+/612855
Commit-Queue: Tim King <taking@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Tim King <taking@google.com>
---
 go/ssa/builder_test.go       | 10 +++++++---
 go/ssa/interp/interp_test.go |  5 +++++
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/go/ssa/builder_test.go b/go/ssa/builder_test.go
index 921fe51aa..6ef8a86d7 100644
--- a/go/ssa/builder_test.go
+++ b/go/ssa/builder_test.go
@@ -777,6 +777,13 @@ func TestTypeparamTest(t *testing.T) {
 	// Tests use a fake goroot to stub out standard libraries with declarations in
 	// testdata/src. Decreases runtime from ~80s to ~1s.
 
+	if runtime.GOARCH == "wasm" {
+		// Consistent flakes on wasm (#64726, #69409, #69410).
+		// Needs more investigation, but more likely a wasm issue
+		// Disabling for now.
+		t.Skip("Consistent flakes on wasm (e.g. https://go.dev/issues/64726)")
+	}
+
 	dir := filepath.Join(build.Default.GOROOT, "test", "typeparam")
 
 	// Collect all of the .go files in
@@ -786,9 +793,6 @@ func TestTypeparamTest(t *testing.T) {
 	}
 
 	for _, entry := range list {
-		if entry.Name() == "chans.go" && runtime.GOARCH == "wasm" {
-			continue // https://go.dev/issues/64726 runtime: found bad pointer
-		}
 		if entry.IsDir() || !strings.HasSuffix(entry.Name(), ".go") {
 			continue // Consider standalone go files.
 		}
diff --git a/go/ssa/interp/interp_test.go b/go/ssa/interp/interp_test.go
index c55fe36c4..52270f78b 100644
--- a/go/ssa/interp/interp_test.go
+++ b/go/ssa/interp/interp_test.go
@@ -307,6 +307,11 @@ func TestGorootTest(t *testing.T) {
 // in $GOROOT/test/typeparam/*.go.
 
 func TestTypeparamTest(t *testing.T) {
+	if runtime.GOARCH == "wasm" {
+		// See ssa/TestTypeparamTest.
+		t.Skip("Consistent flakes on wasm (e.g. https://go.dev/issues/64726)")
+	}
+
 	goroot := makeGoroot(t)
 
 	// Skip known failures for the given reason.