From ac02106e04bdb66a2db0413d931012bea165d7e0 Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Mon, 22 Feb 2016 15:26:12 -0500 Subject: [PATCH] refactor/importgraph: document that graphs are cyclic Change-Id: I195656b523488433945b3215558c3442cf45b2bd Reviewed-on: https://go-review.googlesource.com/19831 Reviewed-by: Robert Griesemer --- refactor/importgraph/graph.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/refactor/importgraph/graph.go b/refactor/importgraph/graph.go index 1fc078115..d2d8f098b 100644 --- a/refactor/importgraph/graph.go +++ b/refactor/importgraph/graph.go @@ -20,6 +20,8 @@ import ( // imported packages (prerequisites); for a reverse graph, it is the set // of importing packages (clients). // +// Graph construction inspects all imports in each package's directory, +// including those in _test.go files, so the resulting graph may be cyclic. type Graph map[string]map[string]bool func (g Graph) addEdge(from, to string) {