Prior to this, the line identified as the start of a command by the test
for a leading dot was dropped. This behaviour is not documented in the
present package documentation.
Change-Id: Ib7354f0f4a661fccc65be5f92d487fe7f627302f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/260899
Run-TryBot: Ian Lance Taylor <iant@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Cherry Zhang <cherryyz@google.com>
Her near-official site is now on Instagram; she doesn't use
Twitter much. Might as well give a useful link.
She doesn't use the acute accent either, so drop that as well.
Change-Id: I84d6fe34277c19763004c8d18d1f0b745f3d3adb
Reviewed-on: https://go-review.googlesource.com/c/tools/+/226285
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Consider this input:
This is preformatted:
line 1
line 2
line 3 after blank line
Before, this would split into two different <pre> sections
in Markdown mode. Now it matches legacy mode and doesn't.
Fixesgolang/go#37972.
Change-Id: I6bf156c76ef9c63b6c3ffe6cce431d9589def867
Reviewed-on: https://go-review.googlesource.com/c/tools/+/224958
Reviewed-by: Andrew Bonventre <andybons@golang.org>
See testdata/README for test format.
This will make it easier to fix problems and not regress.
Markdown tests in followup CL (with bug fixes).
Change-Id: I5dedca26d3c29fd428066ffb38c6605343784a19
Reviewed-on: https://go-review.googlesource.com/c/tools/+/224957
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
The handling of subsubsections was not completely right,
causing unexpected subsubsubsections (#### inside ##)
to go into an infinite loop. Handle that.
Also, my usage of goldmark's (not completely documented)
SetAttributeString was wrong. Need []byte, not string.
Change-Id: Ib127a72b94b5a46adc9047fdb88dd2a8d03e73fe
Reviewed-on: https://go-review.googlesource.com/c/tools/+/223601
Reviewed-by: Andrew Bonventre <andybons@golang.org>
This will allow renaming blog pages to have shorter,
more easily typed URLs, while keeping the old links working.
Change-Id: I2cd6733eaaf02a4b8e73afc773173c655d317ee6
Reviewed-on: https://go-review.googlesource.com/c/tools/+/223603
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Markdown is enabled by starting the title with "# ".
See the new documentation in present/doc.go for details.
For golang/go#33955.
Change-Id: I04ef2aa2cf253bdf48910c5674d679a482ffa33f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/222846
Reviewed-by: Rob Pike <r@golang.org>
Commands like .code now have a TemplateCmd method
that returns the original command.
The Text struct now has a Raw field set when Pre==true.
It contains the original indented text, without the tab "fixing".
This helps building tooling that reformats or rewrites present files.
For golang/go#33955.
Change-Id: Ieb036e8b509a4531d120c597b19f2158306a5352
Reviewed-on: https://go-review.googlesource.com/c/tools/+/222845
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
I forgot to put in a section heading and every line
containing a colon in the text got parsed as a URL,
failing and printing errors. It took a while to find
where they were coming from.
For golang/go#33955.
Change-Id: Ibbc41a8446c292f6ab363829cf31fe594152e42d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/222844
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
This is not strictly necessary, but being able to wrap these long lines
helps make the diffs for the Markdown conversion of old files easier to read.
The wrapping of the blog is in CL 222839.
For golang/go#33955.
Change-Id: I26c3f8db6b137c194f03b2538f221aa4fc3f2324
Reviewed-on: https://go-review.googlesource.com/c/tools/+/222843
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
Previously, using incorrect syntax for one of image, iframe, or video
functions caused an index out of range panic. Add a check to prevent
the panic and return an error instead.
Fixesgolang/go#35142
Change-Id: Ifffb4cc5daded5331d617a3db7cad84e37abadc8
Reviewed-on: https://go-review.googlesource.com/c/tools/+/203477
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
To find out whether the documentation was wrong, or if the
implementation had a bug, I did some code archeology. The earliest
commit I found where the 'h' key in browser was mentioned was the
very first commit where the present format is added. It was in talks
subrepo before being moved to tools subrepo. It was CL 6497063.
In that commit, I see no mention of 'h' key anywhere else except
that one line of documentation.
Three years later, the 'h' key got mapped to hiding the help dialog
in CL 4910.
My best guess is this original feature was documented but
never implemented. So removing it from documentation is
the most appropriate fix.
Fixesgolang/go#17375.
Change-Id: Ibe0b39d73a7a0652acd6a04beddfcff22b0e3c4a
Reviewed-on: https://go-review.googlesource.com/c/143557
Reviewed-by: Andrew Gerrand <adg@golang.org>
The link to the sam documentation explaining the use
of the address syntax used when loading code files
was dead. This updates the location of the
documentation to the new plan9 site.
Fixesgolang/go#23247
Change-Id: If27702a17700ac859650e1e3c070cb43345f32b0
Reviewed-on: https://go-review.googlesource.com/85420
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
There was an extra line in the documentation for the
present package that appears to be a copy paste from the
previous paragraph. This removes that line.
Fixes#21891
Change-Id: Ic50840b2210e3d93ac452a659e29b6feaa33c7b7
Reviewed-on: https://go-review.googlesource.com/63811
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This allowed me to better match the background image to the size of
the slides.
Change-Id: Ieaae93cd78582a3059ed6c3e64e740dea9088af5
Reviewed-on: https://go-review.googlesource.com/47130
Reviewed-by: Andrew Gerrand <adg@golang.org>
Run-TryBot: Andrew Gerrand <adg@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Found with honnef.co/go/tools/cmd/unused.
Change-Id: Iabfa1e9926e097ba11d1db0a2d785fec70ce3997
Reviewed-on: https://go-review.googlesource.com/37609
Reviewed-by: Alan Donovan <adonovan@google.com>
This allows markup bracketed by punctuation even when the
punctuation has text on the other side, like in:
- Markup—_especially_italic_text_—can easily be overused.
- We want to increase `go`vet`'s usage.
Change-Id: I0c6ca790f23f705d8c8ba8a225c0280b916ebb6c
Reviewed-on: https://go-review.googlesource.com/33662
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
Also added a suite of tests and fixed a minor bug that
caused a panic when the .code command specified HL with
no text after.
Fixesgolang/go#17379.
Change-Id: I3c246523c3d4010bf76a467ee648475255090e1b
Reviewed-on: https://go-review.googlesource.com/30691
Reviewed-by: Rob Pike <r@golang.org>
For /start/,/end/, the /end/ address can wrap around and match somewhere
before /start/. Handle this case without crashing.
Fixesgolang/go#7163.
Change-Id: I6fc3b5048e88728c9403a1d1e284ea8ada567a1e
Reviewed-on: https://go-review.googlesource.com/21182
Run-TryBot: Rob Pike <r@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
This is the first of a series of changes that add support for
speaker notes to the Go present tool. This is done by displaying
slides with speaker notes on a second window, and synchronizing
both windows.
Updates golang/go#14654
Change-Id: Ic7b158d1e40f9e7e58d01791c88909f5619ce87f
Reviewed-on: https://go-review.googlesource.com/21485
Reviewed-by: Andrew Gerrand <adg@golang.org>
when handling text line by line, the current line will be ignored if it
may be a command line, so we should stack back this line for further parse.
Fixesgolang/go#11435
Change-Id: If0567c46c90d09b30e78b72f24395725b9e00ea3
Reviewed-on: https://go-review.googlesource.com/16410
Reviewed-by: Andrew Gerrand <adg@golang.org>
This allows having links from one slide to another one in the same presentation.
Also it is needed in the new tour to cross reference lessons.
R=r
CC=golang-codereviews
https://golang.org/cl/46130043
Dan Kortschak
Rebecca Stambler
Rob Pike
Russ Cox
Dmitri Shuralyov
Tobias Klauser
Kazuhiro Sera
David Url
Johan Brandhorst
Johan Brandhorst
griesemer
Edward Muller
kortschak
Eyal Posener
Alexis Hildebrandt
David R. Jenni
gulyasm
Alex Carol
Francesc Campoy
Dominik Honnef
Audrey Lim
Andrew Gerrand
Timothy Studd
Tw
David Symonds