Heschi Kreinick 513be0a9d2 internal/lsp/cache: disable network for mod tidy diagnostics ... The only thing that the mod tidy diagnostics use the network for is adding dependencies, and we already have quick fixes for those. The one exception is the case covered by TestBadlyVersionedModule, a dependency that fails to declare one of its own dependencies and therefore requires an indirect dependency in the workspace module. That only triggers an error on the dependency's import statement, which the user will never see. Fortunately, the go command does expose these problems in the DepsErrors field of the list response. Add an internal API to access that, and turn it into diagnostics on both the file and the controlling go.mod. Refactor the go get diagnostic generation so that it applies to both modules and packages. Fixes golang/go#38462. Change-Id: Ie2af940087654682a40de9ecfccd46f404a88b60 Reviewed-on: https://go-review.googlesource.com/c/tools/+/289309 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2021-02-05 19:41:14 +00:00
..
packages.go	internal/lsp/cache: disable network for mod tidy diagnostics	2021-02-05 19:41:14 +00:00