tools/internal
Tim King 8111118043 go/analysis/internal/facts: fix cycle in importMap.
This change resolves two interrelated outstanding bugs in handling Named
types and type declarations in importMap().
1) Named types did not visit their Underlying() types.
2) Whether Named types were fully visited was order dependent.
   Previously a Named type was not fully visited (methods visited, etc)
   when the type declaration was visited by addObj() before the Named
   type was visited by addType().

Fixes golang/go#49469

Change-Id: Ibf9c6d9afd4958d474149edf2749d994199f14b1
Reviewed-on: https://go-review.googlesource.com/c/tools/+/362414
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Tim King <taking@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
2023-02-02 23:42:27 +00:00
..
analysisinternal go/analysis: add Pass.TypeErrors field 2022-11-16 21:35:14 +00:00
apidiff all: gofmt 2022-04-12 17:53:17 +00:00
bug gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
diff tools/internal/diff: fix off-by-one error in computing diffs 2023-01-21 15:27:42 +00:00
event gopls: migrate internal/lsp to gopls/internal/lsp 2022-09-07 16:44:44 +00:00
facts go/analysis/internal/facts: fix cycle in importMap. 2023-02-02 23:42:27 +00:00
fakenet
fastwalk internal/fastwalk: improve Darwin performance by ~3x 2022-10-13 16:31:57 +00:00
fuzzy gopls/.../fillstruct: support generic types 2022-09-30 19:58:05 +00:00
gcimporter gopls/internal/lsp/source: use syntax alone in FormatVarType 2023-02-02 19:21:44 +00:00
gocommand gopls/internal/lsp/source: delete Snapshot.WriteEnv method 2022-12-29 17:48:08 +00:00
gopathwalk internal/gopathwalk: remove unnecessary call to os.Lstat 2022-03-31 05:33:07 +00:00
goroot internal/gcimporter: load cached export data for packages individually 2022-12-02 18:23:46 +00:00
imports internal/imports: update stdlib index for Go 1.20 2023-02-02 17:00:30 +00:00
jsonrpc2 all: use constant to avoid repeated definitions 2022-09-19 15:32:23 +00:00
jsonrpc2_v2 internal/jsonrpc2_v2: fix typos 2023-01-17 23:21:59 +00:00
lockedfile internal/lockedfile: fix build constraints on solaris 2023-01-27 23:34:20 +00:00
memoize internal/memoize: fix race in Store.Promise 2022-07-28 15:35:11 +00:00
packagesinternal x/tools/go/packages: on Go 1.19+, explicitly ask for -json fields needed 2022-04-19 17:08:06 +00:00
persistent gopls/internal/lsp/cache: invalidate metadata after vendor change 2022-12-02 15:45:07 +00:00
pkgbits all: fix some comments 2023-01-31 16:03:41 +00:00
proxydir
robustio internal/robustio: fix signature of getFileID on plan9 2023-02-01 18:41:57 +00:00
stack all: gofmt 2022-04-12 17:53:17 +00:00
testenv internal/gcimporter: fix TestImportStdLib 2022-12-01 21:10:12 +00:00
tokeninternal gopls/internal/lsp/source: use syntax alone in FormatVarType 2023-02-02 19:21:44 +00:00
tool internal/tool: implement structured help command 2022-05-04 22:58:41 +00:00
typeparams x/tools/internal/typeparams: use regexp to match wanted result 2022-09-02 19:06:05 +00:00
typesinternal internal/typesinternal: update go/types error codes for 1.20 2022-11-10 22:27:59 +00:00
xcontext