The nightly is deprecated in favor of the new pre-release versions.
Clean up docs and references.
Use "Pre-release" instead of "Preview" in user-facing doc.
(We also use "insiders" or "preview" to refer to VS Code Pre-release
inside our code or project to distinguish from semver's prerelease,
but outside our project, "Pre-release extension" is the term to use)
For golang/vscode-go#1953
Change-Id: Id9e5cc53fb1f459e69e7aa264ef76799b069c676
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/613178
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Change-Id: Icdba4abbdd59e9b11224b98b4447d5b6040f8c20
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/599596
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
Commit-Queue: Michael Matloob <matloob@golang.org>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
And fix the issue tracker URL in CHANGELOG.md
Fixesgolang/vscode-go#3428
Change-Id: Ia7e217ea84681908f4f96c958691d3ecd6a3326e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/596275
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
kokoro-CI: kokoro <noreply+kokoro@google.com>
And add LICENSE to the docs module.
Change-Id: Ib1b60b2022cd31d033370e26a1d098a5d525a74c
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/592815
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Temporarily map "any" to "boolean" until CL 593656 is released.
For golang/go#68057
Change-Id: Id134337269b26b9a9ddb546c63f645996d3c3c83
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/593678
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Change-Id: Ib64c2616c6c14ebeafc824d235cb0e508fc121ad
GitHub-Last-Rev: f9be4890c8
GitHub-Pull-Request: golang/vscode-go#3255
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/571955
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Commit-Queue: Ian Lance Taylor <iant@golang.org>
Reviewed-by: David Chase <drchase@google.com>
VS Code changed its TextMate rule source to worlpaker/go-syntax.
Change-Id: I5c59ac851731c388a2a8a317ed5a3c5ca0946a69
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/582675
Reviewed-by: Peter Weinberger <pjw@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
This reverts commit 5b0d6db961.
Reason for revert: Need to address path mapping issue: golang/vscode-go#3175
Change-Id: Iade1d9f2438993025ac1ef5ec9ad6f1213d79ed6
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/580019
kokoro-CI: kokoro <noreply+kokoro@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Change-Id: I9085d2c2fd5299eb199ec43c2299c5baba06580e
GitHub-Last-Rev: a376d21520
GitHub-Pull-Request: golang/vscode-go#3309
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/575897
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
From v0.41.0, we are switching the default to dlv-dap.
Fixesgolang/vscode-go#2205
Change-Id: Iaef25bd94620fd74e7721ab7a55721a9f4f91355
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/562678
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
README - update the setup instruction. The "Analysis Tools Missing"
notification was removed and important tools are installed
automatically.
UI - Go status bar was moved to right, Language status bar is added.
Add the screenshot for Go explorer view. Rephrase the go version
management section to direct users to use GOTOOLCHAIN env var. But
we still need to rethink/rewrite this workflow.
Tools - mention the vscgo binary.
For golang/vscode-go#3167
Change-Id: Iad5528fdfcd9f9b282e6a873259e2c8cecdec227
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/562681
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Change-Id: Iaf9d707ebd16255f68603db9d4407b0c5f4d0f7d
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/561996
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
goLogging was used for extension's verbose/debug logging and debug
session's client-side logging ("Go Debug") output channel.
vscode's LogOutputChannel API provides log level control consistent
across all VS Code components. More importantly, this allows users
to inspect verbose/debug level logging messages from the Go output
channel easily, instead of relying on the Developer's debug console
(which is not guaranteed to be accessible from non-desktop editor
integration products).
Convert the "Go Debug" output channel to vscode LogOutputChannel.
This allows us to control the logging level separate from the shared
go.logging.level configuration.
In fact, 'go.logging.level' setting is no longer necessary.
Mark it deprecated.
Change-Id: I4180eb1ce8afee63863d741b3501f0624aa42433
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/559739
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
The vscgo command line tool is moved to the repo root module.
This simplifies the release process.
The extension module is meant to be used only for development
and majority of the code is non-Go code.
src/goInstallTools.ts installVSCGO is modified too -
Nightly installs with @master.
Updates golang/vscode-go#3122
Updates golang/vscode-go#3121
Change-Id: I04e441ecac71b4ab42e635835d91dcf344353e67
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/554316
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
The latest version no longer offers the "Go: Fill struct" command.
Suggest the code action.
Fixesgolang/vscode-go#3104
Change-Id: Ida95173f0f88322b32ac319d3f8aa1d3d7cf1b5c
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/553075
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
There is an extra quote in the command, which should be an error.
Change-Id: I6ff7c00fa7cacaaef9476232637bff110647ff40
GitHub-Last-Rev: 703b7a1691
GitHub-Pull-Request: golang/vscode-go#3042
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/541875
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
This change removes "Go: Extract to function" and "Go: Extract to
variable" commands, which were using godoctor.
Extract function/var features are implemented in gopls, which can
be accessible by
selecting the range to extract
trigger code action
If users want access through commands, we can consider to add
commands (as we are doing for "Go: Fill struct" command).
Updates golang/vscode-go#2862
Change-Id: Id43374513dcd347c06ae8107aa1c25a41e884641
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/538756
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
VSCode's `editor.action.codeAction` provides a unified way
of accessing refactoring features, including "fill struct".
Gopls returns the appropriate fill struct options based on
the selection or cursor position when invoked with
"args": {
"kind": 'refactor.rewrite',
}
https://code.visualstudio.com/docs/editor/refactoring#_keybindings-for-code-actions
We no longer require a separate fillstruct tool.
Delete the 'fill struct' tests. I hoped we could move these
tests to the gopls integration test, but it turned out
that is more complicated than I thought.
- Starting a VS Code editor instance is costly, so our integration
test starts the editor only once and restarts the gopls instances
for each test suite or test case.
- VSCode does not expose a way to close text document explicitly
by design. We can close visible editors, tabs, or tab groups
and make them disappear (as many stackoverflow posts suggest),
but VSCode keeps open text documents internally for some time
(and some hard-coded eviction age limit like 3minutes).
Reference: https://github.com/microsoft/vscode/issues/192308
- As a result, when a new Gopls instance starts, the editor
(LSP client) sends didOpen messages for the documents open
for previous testing. These documents belong to different
modules, and Gopls considers this misconfiguration.
- Fill struct is implemented as diagnostics. When we trigger
code action requests, Gopls tries to compute diagnostics first.
Unfortunately, gopls thinks the workspace is misconfigured,
produces various diagnostics about all the documents we've
ever opened in our integration test, and fails to suggest
or run fill struct action before timeout.
We can consider
- wait for gopls to support multiple-modules setup (aka
zero config gopls). That will handle the left-over files better.
- rearrange the test dataset to be in one workspace (go.work,
or a single module),
- arrange the integration test to work on a copied test data
and clean up used files at the end of every test. Still unclear
how quickly VSCode detects deleted files and invalidates the
contents in memory though, or
- arrange the lsp client middleware to hijack didOpen notification
and filter out messages about unwanted files during testing.
But given that the extension doesn't do anything special
beyond invoking the codeaction, I am not sure if we need to add
more complexity right now if the future gopls can handle this
better. So, I am dropping the tests now.
Fixesgolang/vscode-go#2107
Change-Id: Ib5659274ae6bd7d25c7b3cdd432f2d5c17e0e30d
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/538755
TryBot-Result: kokoro <noreply+kokoro@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Add a command to the callstack context menu that allows users to
toggle between hiding and showing system goroutines. This allows
for easier discovery of the feature.
For golang/vscode-go#1797
Change-Id: I7f085d5e7d50ec3f3ae2a9d515c99b2e935c5d3a
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/534955
Commit-Queue: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
and pin dlv version used for testing to v1.21.0
to unbreak the debug testing.
Updates golang/vscode-go#2999
Change-Id: If66962ae23b1af6530840937517a97802d654b88
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/533316
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
And update the github workflows to drop go 1.17, and add go 1.21.
Change-Id: Id1e9e25e56c435fb88a62bbd9256576ae6867715
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/531076
Commit-Queue: Robert Findley <rfindley@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
This command invokes the gopls command that starts its
internal debugging web server (and requests that the
client open the web page).
I used the terms "language server" instead of gopls,
and "maintainer interface" instead of debug server
since "debug" has a different conntation in the VS Code UI.
Tested manually.
Change-Id: I9fe5d90f095ef3eed4ea2c1a7ba42117ceb002a2
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/506516
Run-TryBot: Alan Donovan <adonovan@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
The config predates kokoro CI.
The GitHub-based test workflow is not accessible
by external, unapproved contributors.
Remove the docs/testing.md that mostly talks about
these outdated workflows.
Change-Id: Ie7502067d53494f9b28bc807313b35885e066cb3
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/506655
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
This new setting controls whether to show the Welcome
on first install.
Based on GitHub-Pull-Request: golang/vscode-go#2704
Hana Kim ran `go run tools/generate.go` to update
docs/settings.md.
Change-Id: I30a4c5fd6066b4c5e3052ba3d75e47e6b52a4a76
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/501208
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
The deprecation note was present for over two years. No objection
was raised.
Updates golang/vscode-go#1109
Updates golang/vscode-go#50
Change-Id: Ia78b894a200f4120c76fb473ec84ae39578f215f
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/501199
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
The notification provides options to open the settings
and suppress the notification forever.
Also update package.json to change the description of
the go.useLanguageServer setting.
Updates golang/vscode-go#2799
Change-Id: Ib0e4e4414942ab083d1932abcb34f5871911d3da
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/501198
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
By adding the deprecation notes, the current users of these settings
will notice the deprecation when they happen to edit their
settings.json. Moreover, VS Code will exclude them from the default
settings UI and autocompletion list, which will help users not getting
distracted by these old settings.
Updates golang/vscode-go#2799
Change-Id: I771dd5aeb6f826882d2c234e80862a8fb7d45670
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/501206
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Change-Id: I235fb4960de994f84a70e6b1460ed52b5a8ca3b1
GitHub-Last-Rev: 2cde5ded3d
GitHub-Pull-Request: golang/vscode-go#2774
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/495636
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
They are:
"ui.noSemanticNumber": true,
"ui.noSemanticString": true
Updates golang/vscode-go#2682
Change-Id: I942b735af16ed7d070615baad231df4cdcba5d73
GitHub-Last-Rev: 9ac0a3eeb8
GitHub-Pull-Request: golang/vscode-go#2684
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/471280
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Peter Weinberger <pjw@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
This new provider provides the execution for tasks
with type = "go". The task runs the `go` command and runs
the build or test command, along with optional 'args'.
The provider provides the default task definitions including
- go build <current package>
- go test <current package>
- go build ./...
- go test ./...
VS Code offers users to create custom task configurations from
the default task definition this provide provides.
By default a Go task runs from the workspace root folder with
the tools execution environment unless options "cwd"/"env" are
configured. Users who need to work with a module in a nested
directory have to either set up `go.work` in the workspace root
folder, or create custom task configurations that set options
"cwd" property.
Fixesgolang/vscode-go#194
Change-Id: I3ee54af6e1b37031a60fdcb511fd1d961687314e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/467697
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
- lowercased headings
- removed gerunds from headings
- edited 'Stay up to date' section and removed outdated mention of Jan
2022 release
- edited `Switch to legacy debug adapter` section. May want to add link
to legacy docs here
- Edited to "Launch" section. Added numbered lists for instructions.
- Edited to "Breakpoints" section. rewording for clarity.
Change-Id: I27840c690ea67b51eaabefbe029903832f31d1fd
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/461798
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Change-Id: I93cbe95a814e5293d69f20bd67fc4a64ebc9b678
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/461576
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Add more specific instructions for how to go about updating settings
for the inlay hints feature in VS Code.
For golang/go#57470
Change-Id: Ibb457ad1c8c8a092cc27fafc1a70b3f62812f783
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/459519
Run-TryBot: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
The current implementation did not support codelens for sub tests and this
made it quite cumbersome to test and debug codebases that use a large
number of subtests within vscode.
This pull request introduces:
- Test and debug codelenses support for subtests
- A new command "Go: Debug Subtest At Cursor"
- Fixes issues with subtests not running due to missing test name escaping
Fixesgolang/vscode-go#2536
Change-Id: I82087b31bd102d3614f59d070c49e12c5d6d70c3
GitHub-Last-Rev: 094157961e
GitHub-Pull-Request: golang/vscode-go#2537
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/451755
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Hana (Hyang-Ah) Kim
Russell Webb
ossan
monitor1379
rogeryk
Suzy Mueller
Alan Donovan
cuining
Zeke Lu
Xiaoming
Beth Brown
Diogo Correia