This CL also adds a trivial test that checks -n output to see
if the release command calls expected commands.
And fix nightly release's README handling again.
I hoped the new --readme-path flag can help us package README.md file
in the repo root https://go-review.git.corp.google.com/c/vscode-go/+/556535
but it doesn't seem to work yet.
Instead, we copy the README.md file to the extension directory.
Also, fixes the image and content base uris.
Update golang/vscode-go#3122
Change-Id: I6c79d34653346ef2e2b596f0ca4db1de16b79853
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/556536
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
README.md is outside the extension directory.
Updated @vscode/vsce to get --readme-path flag support.
(Still in a prerelease state.
See https://github.com/microsoft/vscode-vsce/issues/905).
Change-Id: Ie9ed25643307ae8827bbf15589be131019a9159b
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/556535
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
And fix all.bash prepare_nightly. It needs to access files in
build/nightly.
Change-Id: I9fab26159ebccc106b6be510088415aaa803ea19
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/555617
TryBot-Result: kokoro <noreply+kokoro@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
The vscgo command line tool is moved to the repo root module.
This simplifies the release process.
The extension module is meant to be used only for development
and majority of the code is non-Go code.
src/goInstallTools.ts installVSCGO is modified too -
Nightly installs with @master.
Updates golang/vscode-go#3122
Updates golang/vscode-go#3121
Change-Id: I04e441ecac71b4ab42e635835d91dcf344353e67
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/554316
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
This workflow is meant to replace the GitHub action workflow defined in
https://github.com/golang/vscode-go/blob/master/.github/workflows/release.yml
The GH workflow was a collection of command line tools invocation and
some bash scripting to parse the version tag and adjust the workflow
depending on whether it's for rc or not. I figured it's easier to work
with go, so ported the logic to build/release.go.
TODO: convert most part of build/all.bash and the nightly release workflow
with go code.
release.go uses `gh` (GitHub CLI tool) to post the release note and
the artifacts (vsix) to GitHub. Dockerfile is updated to include `gh`.
Reference: https://stackoverflow.com/a/69477930
The workflow needs to access GitHub personal access token.
To access the release API, write permission for Content & Workflow is
necessary.
https://docs.github.com/en/rest/authentication/permissions-required-for-fine-grained-personal-access-tokens?apiVersion=2022-11-28#repository-permissions-for-contents
Tested it by triggering the GCB workflow against a forked repo.
For b/216321767
Change-Id: I1eec6b4b896fe1f1565bbf9e160f0368cade36c7
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/553115
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Delete the github workflow.
The new gcb workflow is tested. Go Nightly v2023.12.2718 was
released from GCB.
Change-Id: Ief89f3f914832c300981fe666e5d1ef82ff41558
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/553015
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Building and testing the extension requires a custom docker
image that includes Go, Node.js, jq, gopls, dlv, staticcheck, etc.
build-ci-image.yaml is a workflow that builds and stores the image
in Artifact Registry. (vscode-go-docker-repo/ci-image).
release-nightly.yaml workflow uses the container.
- The workflow clones the vscode-go repo (master branch).
- Before packaging, the "prepare nightly release" step
adjusts the package.json for golang.go-nightly use.
- Then run tests. It's possible that the lint test and the
tools/generate.go test may be unhappy about the spacing and formatting
caused by the modification made during the previous step. However,
the errors are not critical for packaging/publishing. Refactoring of
all.bash was to skip the lint, generate.go tests during nightly
release.
The workflow uploads the built extension to the project's GCS bucket but
does not publish the built extension to the marketplace yet.
Change-Id: Ib48fdc45f1fd1c86fcfc2d293e7f60690b2cad11
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/510515
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
We already have vsce and typescript in the project's package.json
and don't need to preinstall them.
Change-Id: Idf4484a3b5662d9509c3146737d6d448bd9c8771
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/506656
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
The config predates kokoro CI.
The GitHub-based test workflow is not accessible
by external, unapproved contributors.
Remove the docs/testing.md that mostly talks about
these outdated workflows.
Change-Id: Ie7502067d53494f9b28bc807313b35885e066cb3
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/506655
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
The container enabled ipv6 but the VM we are in
doesn't have ipv6 interface yet. Set
NODE_OPTIONS="-dns-result-order=ipv4first" to prefer ipv4.
And update Dockerfile to install @vscode/vsce instead of
now obsolete vsce.
Lastly, skip printing gopls version.
We control gopls version to install/use in the install script.
And the setting doc test also prints gopls version.
Fixesgolang/vscode-go#2769
Change-Id: Ie3f8ad52ebaefb52079a879f8892210967e74fc9
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/494402
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Bypass: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
VSCode modifies package.json while running in the
integration test. It reverts back the package.json
to original, but the revert file write can occur
asynchronously. That affects our document generator
tests following the integration test.
Change the test order so we run the document generator
test before.
Usually, integration test takes long. So, running
this quick documentation consistency test first and
reporting the problem early is better.
Also, change Dockerfile to bring up the container
as non-root user (node created by the node container)
Fixesgolang/vscode-go#2230
Change-Id: I14b2d260f66e8213bdca2125900b5213a45ba8d1
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/405905
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Now that all strict type errors are fixed, we can unify
the tsconfig.
Fixesgolang/vscode-go#57.
Change-Id: If60e91c29826be6dafe9d614f0f0186cc8349b3f
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/406304
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Test files are excluded from strict typechecking. We plan
to fix errors in those files as needed or remove the tests
with the legacy tooling.
For golang/vscode-go#57.
Change-Id: I84ea8bc1834e2e1ee58c297fed984bb94ec0de52
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/403775
TryBot-Result: kokoro <noreply+kokoro@google.com>
Run-TryBot: Jamal Carvalho <jamal@golang.org>
Auto-Submit: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
This reverts commit 106d188c81.
Reason for revert: from internal feedback - often the vulnerabilities are either false-positive or not impacting us, so blocking all dev work may not be a great idea.
Change-Id: Ia93867485c83583e69f4371cde4e9f08f9f883f2
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/397414
Reviewed-by: Robert Findley <rfindley@google.com>
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Change-Id: I36c2b309464d22e2b8c27c956f21b62d4f484655
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/397114
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
This change includes the configuration for hiding the system
goroutines in a debug session. It also sets the default value in
go nightly to true.
The setting of go.useLanguage server in nightly to true is also
removed by this change, since it is not the default everywhere.
Change-Id: I43b45b7743e6b3b31a41da1462e50669846b0f0d
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/359402
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
GitHub Action workflows had tool installation commands defined
in .yml file while Kokoro CI used a bash script. This change
made them to share the same logic.
Instead of using the existing build/all.bash script, this CL
reimplemented the installation logic in go
- to have one single program for all platforms (linux, windows, mac)
- to implement complex logic that switches between go get and
go install depending on the go version (versioned binary installation
using go install became available only after 1.16.
Updates golang/vscode-go#1825
Change-Id: I295856e7d2bdd2d1fc07efc1e794eccb42b55ad6
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/359397
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
This reverts commit 80c100954a.
Delve build is fixed, so, revert the temporary workaround.
We will figure out what workflows work better with the pinned
version of delve.
Change-Id: I2483953197c59892d07aabe137e7ca3a3c322e41
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/339778
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Delve @ master currently doesn't build. Pin the version used in the
builders temporarily.
Change-Id: Ia4d393ddac5500dfec89540c40071381de3a65e2
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/339629
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
In kokoro, we use only 1.16 which has `go install` support.
vscode-go repo has go.mod, so we can't use `go get` for clean install.
Alternatively we can try to use a temp directory (without go.mod)
as a working directory for tools installation. That's how we do
in github action where we also have testings running with go 1.15.
Change-Id: I44626b2889be61fe49ad59ba3f2eb9dbf98949b0
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/322990
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Made `tools/goplssetting` to be a library package
so the functionality can be called from tools/generate.go.
Since this is in a separate package, calling this is tricky
without being in the same module. Create go.mod.
I initially wanted to have go.mod under tools directory
but that breaks `go run tools/generate.go` from
the project root directory.
Simplified the jq query - the original one was written
when we attempted to define all gopls settings in the
top-level. We changed to define them inside "gopls"
object, it can be simpler. Also, it seems like jq
in the distro is outdated and doesn't support the 'walk'
function.
Removed 'unusedwrite' from the available analysis
list in the settings.md doc. It's not available in 0.6.6,
but added by mistake. Now this is included in CI and
CI currently uses the 'latest' for generation, this
extra setting not available in the current latest
will cause failure.
Fixesgolang/vscode-go#1280
Change-Id: Ia1b153d079dfec932b8ddbe946e7352dc405a473
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/299949
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Golint is unmaintained and effectively deprecated.
So, switch to staticcheck, which is one of the existing linter
options we've provided, and is actively maintained.
Compared to golint, we observed staticcheck provides more useful
signals about the code style and common errors, while it is still
easy to use. Some controversial checks existed in the golint are
turned off by default (ST1000, ST1003, ST1016), or removed. Users
can turn them on if want, by supplying -checks as lintFlags.
Unlike golint, staticcheck reports only compile errors and does
not show other lint errors if compile errors are present. Because
the compile errors will be also detected by the language server
or by the buildOnSave/vetOnSave checks and the extension will
deduplicate them, it may look to users as if the linter wasn't
running - I am not sure how much this will bother users yet.
Fixes golang/vscode-go#189
Updates #38968
Change-Id: Ie9334867aef3673aed01d7eaf757966486178dbc
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/279212
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
We want to test the latest dlv dap version in our CI to get any bug
fixes and updates while it is under active development.
Change-Id: I0680cfeb5bce481fe6eb5bd82a9239380c66d5ac
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/295417
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Change-Id: I0cc5a9cb6b6b834885a54ad4c99e0cdefc476473
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/292705
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
github.com/stamblerre/gocode, gocode for module mode.
Module mode will be the default in go1.16, and some tests
for legacy language feature providers need this.
For golang/vscode-go#983
Change-Id: I30ebdc33a6aa97faead69c8d5dfa6cc8c97aeec0
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/291309
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Debug tests need to launch dlv and that needs ptrace.
SYS_PTRACE is not in the default capability list so, add it.
https://docs.docker.com/engine/reference/run/
Change-Id: I3c53e0dd956b731726c5bbf7853d3f30d258dd26
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/287712
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Not sure what caused the breakage now but since the error message
complains about missing tsc, here we install typescript explicitly.
https://source.cloud.google.com/results/invocations/fc221c68-5ed5-4e30-968e-66736d024092/targets/golang%2Fvscode-go%2Fgcp_ubuntu%2Fpresubmit/log
Explicitly exclude .user-data-dir-test directory from vsce packaging.
Tests leave the directory (used as a fake user workspace) behind
and sometimes fail to clean up files under the directory. Those
files cause issues in vsce packaging.
Change-Id: I34f552d90d459a957f88c324c92187fc5b8bab10
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/279693
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
This will detect npm dependency issues that are detected during
packaging.
Change-Id: I7e3bbeee407b764a18e80a21999385472812cf08
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/279012
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Recent changes in kokoro seem to restrict access to the root directories
other than /workspace. Place all directories we need write permission fo
under /workspace directory. That includes the home directory (where npm
and the vscode test framework store downloaded data and configuration by
default) and the default GOPATH directory ($HOME/go) under which tests
copy test fixtures.
Fixesgolang/vscode-go#833
Change-Id: I85ad64d253df31f782d29ae0fe994945210567cc
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/264877
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
The builder log is too verbose with -v.
Change-Id: Id16a7d2d06dae3f13784110894c5f756a3420944
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/259139
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
build/Dockerfile assumes the docker container is built from the root,
after golang.org/cl/253749. Change `all.bash testlocal` to build
the container image from the root.
Change-Id: I30114c49894a847975cc901efd30bb029f0c79e7
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/254805
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
That can be used to install all the tools vscode-go test depends
on. We use this new command in build/Dockerfile and also,
reference in the contribution guideline.
We can also consider changing .github/workflows/* to use this
command. But I am not yet sure how to reuse it in Windows yet.
Change-Id: I328707ab4c60428e67ef43f99d5d533a6fa5f211
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/253749
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Docker build is failing for me (and for CI). Probably this behavior
varies across Docker versions.
Change-Id: I953d40582eb4a2e17459d7655f90fdae8805cb59
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/248177
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Tests do not need the source code of some tools.
Build all tools in modules mode as the extension does.
Also, remove explicit setting of GOPATH for testing.
Fixesgolang/vscode-go#6
Change-Id: Ifff7262bd0debece5781ac73c091ba9d15acc440
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/244772
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
CI should fail if you update the package.json without updating the
corresponding documentation. Confirmed that this works in an earlier,
intentionally broken patchset.
Updates golang/vscode-go#198.
Change-Id: I375e17ea7981bd045145128ac398ef1aa4c3f33d
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/237877
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Since we are now maintaining golang.go and that is our main extension,
using the id makes more sense. That will help existing Go users who want
to make and test a small change quickly.
- Rename src/telemetry.ts to src/const.ts because there is no
telemetry related code in the file.
- Move docs/nightly back to build/nightly, because they are meant to be
used during the nightly release process, rather than to serve as
documentation for end users.
In the nightly release, we replace the extension id with golang.go-nightly,
combine README.md with build/nightly/README.md, and replace src/const.ts
with build/nightly/const.ts.
Change-Id: I08e452dea4319d38f8f0e7ab1285ff34c2343365
GitHub-Last-Rev: 0a720d0c3e
GitHub-Pull-Request: golang/vscode-go#234
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/238358
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run lint as part of the usual build/test job instead of running it as a separate job.
But place it at the end so we can run tests even when fixing lint is necessary.
Separate ci.yml to test-smoke.yml (Smoke Tests) and test-long.yml (Long Tests).
Long Tests run on windows and mac as well, while Smoke Tests run only on linux.
(I removed mac and windows from Smoke Tests because our tests fail on windows currently).
Long Tests will be triggered on 'push', and
Smoke Tests will run on every 'pull_request'.
Updates #208
Change-Id: Ic978dacb2a2c51f2912375e739a6d854a091d4f4
GitHub-Last-Rev: ac5bafb083
GitHub-Pull-Request: golang/vscode-go#218
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/237717
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Delete the merge.bash file as we no longer need it.
Fix a Markdown lint warning in SECURITY.md.
Mention linting in the contribution doc.
Delete outdated CONTRIBUTING.md.
Change-Id: Ica9afdfb3a4f906df890c7dddf3740bdad8f44da
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/237257
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
I updated copyright headers of the some of the files we heavily
modified to set the example.
Change-Id: If24d525442bd6ba37133f1397f81c8d918ad725e
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236964
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Rewrote a number of documents. Notable changes:
- Cleaned up and updated the debugging documentation. Some more work
still needs to be done, but I think it's in pretty good shape.
- Move build/README.md to docs/testing.md. I think it fits better with
the other docs, and I expect most of the build directory will be going
away soon? Hana, let me know what you think because I can also move it
back.
- Separated settings.md from commands.md. Ran out of steam when trying
to finish commands.md, but I'll try to work on it more next. Haven't
updated all of the incorrect references to commands.md yet, but
that's for the next CL.
- Updated and cleaned up the smoke test. Not sure if we'll ever use it,
but it's not a bad thing to have, and I caught a gopls bug with it.
Change-Id: Ie9ed8187a0597d36f5960d77fd999d14366bbe74
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236379
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Hana (Hyang-Ah) Kim
Jamal Carvalho
Suzy Mueller
Rob Findley
Rebecca Stambler