We will need to invoke the default pgrep (/usr/bin/pgrep) and prevent
a buggy pgrep from getting in the way. This CL checks in the copy of tree-kill (tree-kill-1.2.2) under third_party.
Updates golang/vscode-go#90
Change-Id: Ibd8d1ecb15a8a09c2d638eabff1c4069eff8c97b
GitHub-Last-Rev: 591b59de13
GitHub-Pull-Request: golang/vscode-go#167
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236145
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
https://go-review.googlesource.com/c/vscode-go/+/234020 added
new dependency on 'glob', so the package.json had to be updated.
The 'glob' module was already in the dev dependency, we couldn't
catch this during testing. Missing this dependency in the packaged
extension caused the debug adapter process to crash when loading.
We need to improve our testing to 1) add end-to-end debug testing,
2) run tests with .vsix.
Fixesgolang/vscode-go#107
Change-Id: Icc7b5743def13d877069d836079c71b199b21ec9
Change-Id: Icc7b5743def13d877069d836079c71b199b21ec9
GitHub-Last-Rev: 6d300abe13
GitHub-Pull-Request: golang/vscode-go#148
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/236037
Reviewed-by: Quoc Truong <quoct@google.com>
The existing telemetry code is no longer used.
Remove the dependency on the telemetry module
that was a blocker of extension bundling.
Updates golang/vscode-go#53
Change-Id: I659166d121da05766cd5fd7ed16bbaf36e05c74b
Change-Id: I659166d121da05766cd5fd7ed16bbaf36e05c74b
GitHub-Last-Rev: f0db5abb16
GitHub-Pull-Request: golang/vscode-go#74
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/234530
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This change tests the tool installation behavior. It uses a fake, file-based module proxy to create stubs for the tools. Follow-up CLs will include installing tools at specific versions and integration tests that use the network and run only in CI.
Updates golang/vscode-go#42
Change-Id: I8845e8c2ffebe9468ac8d2442d3675e514f0787b
GitHub-Last-Rev: 3188bbf0f5
GitHub-Pull-Request: golang/vscode-go#36
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/233557
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
* Fix process cancelation
Processes were not being killed due to the path to the external scripts
being incorrect. Fix this by relying on the tree-kill package rather
than shelling out to an external script to kill a process and its
children.
Also add sinon as a dev dependency for testing purposes.
Updates #3044
* Use tree-kill directly in the debug adapter.
We cannot take a dependency on util, which depends on the vscode module
because the debug adapter runs in a process that doesn't have access
to the vscode module.
Co-authored-by: Ramya Achutha Rao <ramyar@microsoft.com>
* Increase performace of DocumentSymbolProvider via byte offset memos
Decreases time to get symbols by 1-2 orders of magnitiude in large files
This in turn seems to speed up formatting time.
Still WIP, will look for other performance pitfalls.
* remove logging
* Minor formatting
* Naming
* Add tests and fix bugs
* add vsix
* Add comparison vsix's
* Rename/update docs
* Naming
* naming
* remove vsix
* Naming
* update dependencies
* update dependancies
Rebecca Stambler
Hana (Hyang-Ah) Kim
Ramya Achutha Rao
Zac Bergquist
Luis GG
C S Madhav
James George
Vlad Barosan
Jackson Kearl
Bryce Kahle
Alexandros Dorodoulis