Граф коммитов

44 Коммитов

Автор SHA1 Сообщение Дата
Zvonimir Pavlinovic 0419a58004 docs: update triage.md on handling duplicates
Change-Id: Ie820e613acfc294abefd9760c733d015bfe8f10e
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/623715
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-10-30 21:21:03 +00:00
Zvonimir Pavlinovic ac6b9d6d8b doc: add triage instructions for issues not affecting Go code
Change-Id: Id0a80bd4925de06f1bae1c23efae1bda3c31fb9c
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/614616
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
2024-09-20 18:15:33 +00:00
Tatiana Bradley 73190ac6a7 internal/report: add new excluded reason WITHDRAWN
Add new excluded reason, WITHDRAWN, which indicates
that a report was withdrawn before we got a chance
to publish it in vulndb.

This allows us to keep better track of withdrawn reports
(as opposed to completely omitting them from our
records).

Change-Id: I7209edc88e903787b0c79556177af8f34fed8a4e
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/607818
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Tatiana Bradley <tatianabradley@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
2024-08-26 20:06:40 +00:00
Tatiana Bradley 0efc140091 cmd/vulnreport: simplify the duplicates process
Remove the "possible duplicate" label and instead
label all suspected duplicates as "duplicate" and
post a comment of the form "Duplicate of #NNN" to
the issue.

Update the instructions for the triager.

This is OK because the duplicate-finding check is
almost always correct.

Change-Id: I9d036f3a0490564000a13d783353608cde39880a
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/606236
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
2024-08-16 17:42:07 +00:00
Tatiana Bradley e4e33bd87e doc: update triage docs
Re-arrange the docs so that reference-style info about triage
is in triage.md, and add a new page vulnreport.md.

Update the descriptions of the triage states in triage.md

Change-Id: I75c5fe555a3cbcb0eedcec58fe811f5b5caef0b6
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/600236
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Tatiana Bradley <tatianabradley@google.com>
2024-07-22 19:08:24 +00:00
Tatiana Bradley 9840931d1e cmd/vulnreport: automatically decide whether to create REVIEWED or UNREVIEWED report
Command vulnreport create now decides whether to generate a REVIEWED
or UNREVIEWED report based on issue's labels.

This can be overridden with flag "-status=<REVIEW_STATUS>". The "unreviewed"
flag is removed.

Change-Id: I8f8b808c6f9bbcaeb0dc176fb6cb875b8f9ccee4
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/587976
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
2024-05-23 20:24:39 +00:00
Tatiana Bradley 95da37aca7 doc: add WIP quickstart guide
Adds the beginnings of a guide that can be used as a
reference for the current vulndb triager, in combination
with the older triage guide.

The goal is to document new features / processes
so we can get started with experimenting with them
without needing to overhaul the whole guide before we
have worked out the final process.

Change-Id: Iad8256414fda78ebbdbfc44776a46786cbbb034c
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/587975
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
2024-05-23 20:24:20 +00:00
Tatiana Bradley d97fcd06a3 doc: add documentation for new YAML fields
Change-Id: I79cde31a1e0d42de916376245f6397d86d539eb1
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/587916
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
2024-05-23 20:24:05 +00:00
Tatiana Bradley 0ab8d8ec22 data/reports: unexclude GO-2024-2539.yaml
This is a previously-excluded binary report used
to demonstrate the usage of the new "non_go_versions" field.

Aliases: CVE-2024-23319, GHSA-4fp6-574p-fc35

For golang/vulndb#2539

Change-Id: I06fa51de3e32d78bdc53bf8262e84d92e5af2d95
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/568058
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
2024-03-18 17:29:34 +00:00
Tatiana Bradley 183a48467d internal/{osv,report}: add support for non-Go version ranges
A non-Go version range can be used to specify versions used by
module maintainers that do not conform to Go's module
version conventions (https://go.dev/doc/modules/version-numbers).

For now, these versions are not published in OSV. In the future,
they will likely be published in an ecosystem_specific field
and used for display purposes.

Change-Id: I3fcd13a832fd91bce3dfaccd56e63a06e95410b3
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/568057
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
2024-03-18 17:29:15 +00:00
Tatiana Bradley 051ab66191 triage.md: add documentation for new features
Change-Id: I3179e088c3bd8e41da08a2ca26504f9221d36f1c
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/568916
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Tatiana Bradley <tatianabradley@google.com>
2024-03-04 22:19:39 +00:00
Jonathan Amsterdam 8e880fc462 doc/triage.md: explain "waiting analysis"
Say that we should write a report if the NIST page says "awaiting analysis".

Change-Id: Ieabecd3743b6495c679650e950a466f5846aec70
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/555895
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
2024-01-15 17:25:49 +00:00
Tatiana Bradley c0fd17af32 format.md: update format instructions
Change-Id: I0c93122675698700a729b26a720b8980cc843be9
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/543802
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
2023-12-14 15:51:53 +00:00
Jonathan Amsterdam 03ba437d43 doc: minor clarifications
Change-Id: I1243bd051411191c5d35e0be35b515b1ea184558
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/535695
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
2023-10-16 19:30:39 +00:00
Tatiana Bradley 34442e5801 internal/report: allow empty description in lint
Allow empty description for third-party reports that have an advisory link.

Change-Id: I49ffa56cbc2820e0afcd4ce8a0645ee1e9a2ff40
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/506336
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
2023-06-26 20:24:37 +00:00
Tatiana Bradley 2f2503f609 internal/report: add notes field to YAML
Add a new YAML field, "notes", which can be used to add notes to a report
to, e.g., document why certain decisions were made. These notes are only
stored in the YAML files, and not published to OSV or CVE records.

Change-Id: I3e9a328d4b61595b393ab3d1747870c13736dd0a
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/503875
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
2023-06-21 18:36:08 +00:00
Tatiana Bradley 9d677addaa doc: update triage.md
Updates triage.md to better match current state of triaging.

Change-Id: Ide8ead20b6af380f3f2d9121ff78b372a6953643
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/503039
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
2023-06-15 18:16:23 +00:00
Tatiana Bradley 851938218c doc: update format.md
Update docs to match current reality of the YAML format.

Change-Id: Ie5e23b1af1b7c53037feb47eae08b2cddb753999
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/503037
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2023-06-13 21:20:44 +00:00
Jonathan Amsterdam 4ab4099618 doc/triage.md: elaborate on how to edit a generated report file
Change-Id: Ib23c3d48e15b39a9e5d023ce0da7621fae09c9ec
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/494938
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
2023-05-15 16:40:34 +00:00
Tatiana Bradley 56a4787e15 all: remove references to x/vuln in documentation
Change-Id: Id948f4a202ef3369ab208ba16742e3a3e241a1b8
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/481995
Run-TryBot: Tatiana Bradley <tatianabradley@google.com>
Reviewed-by: Julie Qiu <julieqiu@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
2023-04-04 16:07:17 +00:00
Jonathan Amsterdam c023f0d4b1 doc: minor clarifications
Change-Id: I425edd523541ccab6641d27ed01d70d0fe3ba5bb
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/476675
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2023-03-15 21:08:04 +00:00
Jonathan Amsterdam 77ae2d0758 doc/triage.md: document `vulncheck osv`
Change-Id: I1c1c65490ebd194f50616ef3577a34db88e2bcd0
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/475922
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
2023-03-13 20:22:40 +00:00
Jonathan Amsterdam 5f89dfe256 doc: additions
- triage.md: Mention that you must be at repo root to run some
  vulnreport commands, and fix a heading level.

- format.md: document vulnerable_at, and add some more information
  about credit.

Change-Id: I3194b70fbc8ff15cf4a8b9b938b27a1034862b43
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/475918
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2023-03-13 17:17:09 +00:00
Jonathan Amsterdam fc667938db doc/triage.md: advise creating a branch before running `created-excluded`
If you run `vulnreport create-excluded` on master, you'll get a new commit
on master. You need to be on another branch.

Change-Id: I10abad871a04f5e54f96bec40828529d631e8b71
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/475916
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2023-03-13 15:36:46 +00:00
Tim King f2a1768ad8 doc: document vulnreport failures in triage
Change-Id: I3c031d93c4a1beda829fe3f00debcdb6810bd29f
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/461635
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Tim King <taking@google.com>
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
2023-01-11 18:50:04 +00:00
Tim King 143de287a2 doc/triage.md: clarify instructions for duplicates
Change-Id: I91e8f7baa15b2096c42f6c039ede43dddf827bab
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/459535
Run-TryBot: Tim King <taking@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-12-27 20:21:44 +00:00
Maceo Thompson 4f346b5d5a doc/triage: add documentation for the create-excluded cmd
This change adds documentation/instructions for batch creating excluded reports.

Change-Id: Ib5f17129692b9d166606680c6fe63b36cc1cfc56
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/451288
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Maceo Thompson <maceothompson@google.com>
2022-11-21 17:37:13 +00:00
Jonathan Amsterdam 239d639f29 doc/triage.md: add instructions for aliases
Change-Id: I8fc38bd2441368d6da6c99caa09224a29b10b002
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/451398
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
2022-11-17 13:08:17 +00:00
Tim King fb87641ab1 doc: update triage.md with more details.
Adds more details for how to add a new report to triage.md.
Added details come from fricition from onboarding.

Change-Id: I92f7064e65da021429cae9dbe664b48e47f4a74e
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/447075
Run-TryBot: Tim King <taking@google.com>
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-11-01 21:03:39 +00:00
Tatiana Bradley 118a7f2ceb doc: update triage.md to reflect latest
Change-Id: I6092977e2419193dbb9117adb16cde7c172bc3a0
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/442780
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Tatiana Bradley <tatiana@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Julie Qiu <julieqiu@google.com>
2022-10-13 18:52:59 +00:00
Damien Neil 9e744d63c0 doc: document new reference format
Change-Id: I67b5df686f1bc5f3f9e71154ec0b140a705a308f
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/426474
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
2022-08-29 22:07:41 +00:00
Damien Neil 5f75c97393 all: report cmd/... as in module "cmd", "toolchain" in OSV
The toolchain binaries (cmd/...) are in module "cmd" (according to
go/src/cmd/go.mod), but we've been putting "std" as the module in
reports. Fix the reports. Put in a lint check to prevent backsliding.

Our ecosystem-specific OSV spec states that toolchain binaries
get a path of "toolchain", so convert "cmd" to "toolchain" at
generation time.

Put toolchain reports in toolchain.json for consistency.

Change-Id: I8513438496d2c84846483febd874710cdbf67dea
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/425005
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Julie Qiu <julieqiu@google.com>
2022-08-22 18:06:37 +00:00
Damien Neil 95a417dbb7 data/reports: add published date to all reports
The move of reports from reports/ to data/reports broke lookups of
the publication date from the git history. Set the publication
date for all existing reports based on the history from the old
location.

Change-Id: I7a4dd9121894d037c689db7398311b234bdf270b
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/424377
Reviewed-by: Julie Qiu <julieqiu@google.com>
2022-08-18 20:22:13 +00:00
Damien Neil 74a8e0131d all: add support for excluded reports
Add support for recording the reason no report exists for a CVE or GHSA.
Excluded reports are placed in the excluded/ directory, and follow the
same format as normal reports except:

  - Excluded reports have a "excluded" field indicating why the
    report has been excluded.
  - Excluded reports must have at least one associated CVE or GHSA.
  - Excluded reports need have no other fields set.

Change-Id: I4b346567bd2b0ac08c78a9bc5ae26f721a8c3147
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/422638
Reviewed-by: Julie Qiu <julieqiu@google.com>
2022-08-11 18:46:24 +00:00
Damien Neil df74e71288 doc: add style guide to report format documentation
Change-Id: Iad47cbbeee2efa128949511a848ea32cf5622108
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/419183
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
2022-07-27 18:18:29 +00:00
Damien Neil 8a80fd9e78 doc: update triage documentation for "vulnreport commit"
Change-Id: Ib7a1e5bc4020b8be0c340cc663d5c9d945538ce0
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/412417
Reviewed-by: Julie Qiu <julieqiu@google.com>
2022-06-15 22:07:57 +00:00
ariathaker d324b005f1 doc: add instructions for standard library reports
All Go standard library reports to x/vulndb should follow the same
format, which is now documented in triage.md.

Change-Id: Idce3501cd7c26e1d2a02dd8e74c8a89a3144c123
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/389534
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
Reviewed-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
Reviewed-by: Julie Qiu <julieqiu@google.com>
2022-05-23 16:04:06 +00:00
Tatiana Bradley 68d4ba9a14 x/vulndb: update report format doc to reflect new changes and improve readability
Documentation for the vulndb reports now reflects refactored Package and
adds documentation for GHSA IDs.

Additionally reformats document for readability, adds more examples, and
makes wording more consistent throughout.

Change-Id: I64798238ac3f1476c64691bdbcefa15d8de8e375
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/406254
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
2022-05-23 15:59:04 +00:00
Jonathan Amsterdam 5c0656910a doc: describe derived_symbols and how to create them
Change-Id: Ia45fa5c45a5a54fad8fce8d790dbab11b24301a5
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/384335
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-02-16 15:50:09 +00:00
Jonathan Amsterdam d02be8961a doc/worker.md: explain default creds
Change-Id: I425d3190d0a3b0c39901a4235a9021614d85ffda
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/379140
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
2022-01-19 17:42:56 +00:00
Julie Qiu e3c64859d5 doc: update format.md
format.md is updated to the latest YAML format.

Fixes golang/go#50003

Change-Id: I577d4bd81dc7dfdde014e350d5b23856dd70a133
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/375439
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
2022-01-05 02:54:57 +00:00
Julie Qiu 18df4dec1c doc: document triage process
Change-Id: I35df49a1833c4daa704f6df970c5b38a66ec1122
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/374174
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
2022-01-04 16:11:47 +00:00
Jonathan Amsterdam a16c2408ae cmd/worker: add README
Change-Id: Icb362490cb53cd750e198bf2d573e694b6f2643c
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/373676
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
2021-12-22 14:00:45 +00:00
Julie Qiu 59bebd7cab doc: move format.md
A doc folder is created for documentation about x/vulndb and format.md
is moved to that directory.

Change-Id: Ibb9c946cdae8b0cc5626eb47a1272de1783d5ad7
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/373500
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
2021-12-20 22:17:51 +00:00