`stage_description` -> `ot_description`

With a more detailed description of the field and its relation to OT
This commit is contained in:
Daniel Smith 2023-09-13 12:46:44 -07:00
Родитель cc0308efc7
Коммит 1b471fad6f
7 изменённых файлов: 2 добавлений и 11 удалений

Просмотреть файл

@ -177,7 +177,7 @@ def stage_to_json_dict(
'created': str(stage.created),
'feature_id': stage.feature_id,
'stage_type': stage.stage_type,
'stage_description': stage.stage_description,
'ot_description': stage.ot_description,
'display_name': stage.display_name,
'intent_stage': INTENT_STAGES_BY_STAGE_TYPE.get(
stage.stage_type, INTENT_NONE),

Просмотреть файл

@ -64,7 +64,6 @@ class StagesAPITest(testing_config.CustomTestCase):
self.stage_4 = Stage(
id=40, feature_id=1, stage_type=150, browser='Chrome',
stage_description='An origin trial\'s description',
origin_trial_id='-5269211564023480319',
ux_emails=['ux_person@example.com'],
intent_thread_url='https://example.com/intent',
@ -101,7 +100,6 @@ class StagesAPITest(testing_config.CustomTestCase):
'created': str(self.now),
'desktop_first': 100,
'desktop_last': None,
'stage_description': None,
'display_name': None,
'enterprise_policies': [],
'origin_trial_id': None,
@ -190,7 +188,6 @@ class StagesAPITest(testing_config.CustomTestCase):
'te_emails': [],
'intent_thread_url': 'https://example.com/intent',
'desktop_first': 100,
'stage_description': None,
'display_name': None,
'desktop_last': None,
'android_first': None,
@ -236,7 +233,6 @@ class StagesAPITest(testing_config.CustomTestCase):
'te_emails': [],
'intent_thread_url': 'https://example.com/intent',
'desktop_first': 100,
'stage_description': 'An origin trial\'s description',
'display_name': None,
'desktop_last': None,
'android_first': None,

Просмотреть файл

@ -292,6 +292,7 @@ const FLAT_ORIGIN_TRIAL_FIELDS = {
// TODO(jrobbins): display r4dt_url instead when deprecating.
'i2e_lgtms',
'intent_to_experiment_url',
'ot_description',
'ot_chromium_trial_name',
'ot_webfeature_use_counter',
'ot_documentation_url',

Просмотреть файл

@ -241,7 +241,6 @@ export const STAGE_SPECIFIC_FIELDS = new Set([
// Misc fields.
'display_name',
'stage_description',
'origin_trial_feedback_url',
'ot_chromium_trial_name',
'ot_description',

Просмотреть файл

@ -258,9 +258,6 @@ class Stage(ndb.Model):
stage_type = ndb.IntegerProperty(required=True)
display_name = ndb.StringProperty()
# Currently only used for separate origin trial descriptions.
stage_description = ndb.TextProperty()
# Pragmatic information: where and when.
browser = ndb.StringProperty() # Blank or "Chrome" for now.
milestones = ndb.StructuredProperty(MilestoneSet)

Просмотреть файл

@ -30,7 +30,6 @@ class StageDict(TypedDict):
created: str
feature_id: int
stage_type: int
stage_description: str | None
display_name: str
intent_stage: int
intent_thread_url: str | None

Просмотреть файл

@ -268,7 +268,6 @@ class FeatureEditHandler(basehandlers.FlaskHandler):
('rollout_milestone', 'int'),
('rollout_platforms', 'split_str'),
('rollout_details', 'str'),
('stage_description', 'str'),
('enterprise_policies', 'split_str'),
('intent_thread_url', 'str'),
('display_name', 'str'),