Rename "ready_for_trial_url" to "announcement_url" (#2891)

client-src/elements/form-definition.js

@@ -279,7 +279,7 @@ const FLAT_DEV_TRIAL_FIELDS = {
         'dt_milestone_desktop_start',
         'dt_milestone_android_start',
         'dt_milestone_ios_start',
-        'ready_for_trial_url',
+        'announcement_url',
       ],
       isImplementationSection: true,
       implStatusValue: IMPLEMENTATION_STATUS.BEHIND_A_FLAG[0],
@@ -510,7 +510,7 @@ const DEPRECATION_DEV_TRIAL_FIELDS = {
         'dt_milestone_desktop_start',
         'dt_milestone_android_start',
         'dt_milestone_ios_start',
-        'ready_for_trial_url',
+        'announcement_url',
       ],
       isImplementationSection: true,
       implStatusValue: IMPLEMENTATION_STATUS.BEHIND_A_FLAG[0],

client-src/elements/form-field-enums.js

@@ -150,7 +150,7 @@ export const STAGE_SPECIFIC_FIELDS = new Set([
   'rollout_platforms',
   'rollout_details',
   'enterprise_policies',
-  'ready_for_trial_url',
+  'announcement_url',
 ]);
 
 // Mapping of specific field names to their more generic stage names.

client-src/elements/form-field-specs.js

@@ -624,7 +624,7 @@ export const ALL_FIELDS = {
                 thread, link to it here.`,
   },
 
-  'ready_for_trial_url': {
+  'announcement_url': {
     type: 'input',
     attrs: URL_FIELD_ATTRS,
     required: false,

internals/processes.py

@@ -99,7 +99,7 @@ PI_SEC_REVIEW = ProgressItem('Security review issues addressed')
 PI_PRI_REVIEW = ProgressItem('Privacy review issues addressed')
 # TODO(jrobbins): needs detector.
 PI_EXTERNAL_REVIEWS = ProgressItem('External reviews')
-PI_R4DT_EMAIL = ProgressItem('Ready for Trial email', 'ready_for_trial_url')
+PI_R4DT_EMAIL = ProgressItem('Ready for Trial email', 'announcement_url')
 
 PI_TAG_REQUESTED = ProgressItem('TAG review requested', 'tag_review')
 PI_VENDOR_SIGNALS = ProgressItem('Vendor signals', 'safari_views')

internals/search_queries.py

@@ -296,7 +296,7 @@ STAGE_QUERIABLE_FIELDS: dict[str, Property] = {
     'intent_to_extend_experiment_url': Stage.intent_thread_url,
     'intent_to_implement_url': Stage.intent_thread_url,
     'intent_to_ship_url': Stage.intent_thread_url,
-    'ready_for_trial_url': Stage.announcement_url,
+    'announcement_url': Stage.announcement_url,
 
     # Obsolete fields
     # 'i2e_lgtms': Feature.i2e_lgtms,
@@ -330,7 +330,7 @@ STAGE_TYPES_BY_QUERY_FIELD: dict[str, dict[int, Optional[int]]] = {
     'intent_to_extend_experiment_url': core_enums.STAGE_TYPES_EXTEND_ORIGIN_TRIAL,
     'intent_to_implement_url': core_enums.STAGE_TYPES_PROTOTYPE,
     'intent_to_ship_url': core_enums.STAGE_TYPES_SHIPPING,
-    'ready_for_trial_url': core_enums.STAGE_TYPES_PROTOTYPE,
+    'announcement_url': core_enums.STAGE_TYPES_PROTOTYPE,
   }
 
 

pages/guide.py

@@ -239,7 +239,6 @@ class FeatureEditHandler(basehandlers.FlaskHandler):
       'devrel': 'devrel_emails',
       'spec_mentors': 'spec_mentor_emails',
       'comments': 'feature_notes',
-      'ready_for_trial_url': 'announcement_url',
       'intent_to_implement_url': 'intent_thread_url',
       'intent_to_ship_url': 'intent_thread_url',
       'intent_to_experiment_url': 'intent_thread_url',
@@ -247,7 +246,7 @@ class FeatureEditHandler(basehandlers.FlaskHandler):
 
   # Field name, data type
   STAGE_FIELDS: list[tuple[str, str]] = [
-      ('ready_for_trial_url', 'link'),
+      ('announcement_url', 'link'),
       ('origin_trial_feedback_url', 'link'),
       ('experiment_extension_reason', 'str'),
       ('finch_url', 'link'),

pages/guide_test.py

@@ -215,10 +215,10 @@ class FeatureEditHandlerTest(testing_config.CustomTestCase):
     # Fields changed.
     form_fields = ('category, name, summary, shipped_milestone, '
         'intent_to_experiment_url, experiment_risks, experiment_reason, '
-        'origin_trial_feedback_url, intent_to_ship_url, ready_for_trial_url')
+        'origin_trial_feedback_url, intent_to_ship_url, announcement_url')
     # Expected stage change items.
     new_shipped_milestone = '84'
-    new_ready_for_trial_url = 'https://example.com/trial'
+    new_announcement_url = 'https://example.com/trial'
     new_intent_to_experiment_url = 'https://example.com/intent'
     new_experiment_risks = 'Some pretty risky business'
     new_origin_trial_feedback_url = 'https://example.com/ot_intent'
@@ -232,7 +232,7 @@ class FeatureEditHandlerTest(testing_config.CustomTestCase):
             'name': 'Revised feature name',
             'summary': 'Revised feature summary',
             'shipped_milestone__60': new_shipped_milestone,
-            'ready_for_trial_url__30': new_ready_for_trial_url,
+            'announcement_url__30': new_announcement_url,
             'intent_to_experiment_url__50': new_intent_to_experiment_url,
             'experiment_risks__50': new_experiment_risks,
             'origin_trial_feedback_url__50': new_origin_trial_feedback_url,
@@ -266,7 +266,7 @@ class FeatureEditHandlerTest(testing_config.CustomTestCase):
     self.assertIsNotNone(shipping_stages)
     # Check that correct stage fields were changed.
     self.assertEqual(dev_trial_stage[0].announcement_url,
-                     new_ready_for_trial_url)
+                     new_announcement_url)
     self.assertEqual(origin_trial_stages[0].experiment_risks,
         new_experiment_risks)
     self.assertEqual(origin_trial_stages[0].intent_thread_url,