intent template adjustments and fixes (#4112)

This commit is contained in:
Daniel Smith 2024-07-16 20:36:46 -07:00 коммит произвёл GitHub
Родитель 3693202da2
Коммит 65f3633b3f
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: B5690EEEBB952194
8 изменённых файлов: 78 добавлений и 149 удалений

Просмотреть файл

@ -174,7 +174,7 @@ class FunctionTest(testing_config.CustomTestCase):
self.assertEqual('feature_owner@example.com', task['to'])
self.assertEqual('[Action requested] Update feature one', task['subject'])
self.assertEqual(None, task['reply_to'])
TESTDATA.make_golden(task['html'], 'test_build_email_tasks_feature_accuracy_enterprise.html')
# TESTDATA.make_golden(task['html'], 'test_build_email_tasks_feature_accuracy_enterprise.html')
self.assertMultiLineEqual(
TESTDATA['test_build_email_tasks_feature_accuracy_enterprise.html'],
task['html'])

Просмотреть файл

@ -63,27 +63,11 @@
</table>
<table>
</table>
<table>
</table>
<table>

Просмотреть файл

@ -58,27 +58,11 @@
</table>
<table>
</table>
<table>
</table>
<table>

Просмотреть файл

@ -58,27 +58,11 @@
</table>
<table>
</table>
<table>
</table>
<table>

Просмотреть файл

@ -139,33 +139,32 @@ limitations under the License.
<section>
<h3>Copy and send this text for your "Intent to ..." email</h3>
<p>Email to</p>
<div class="subject">
blink-dev@chromium.org
</div>
<h3>Copy and send this text for your "Intent to ..." email</h3>
<p>Email to</p>
<div class="subject">
blink-dev@chromium.org
</div>
<p>Subject</p>
<div class="subject">
Intent to Prototype:
feature one
</div>
<p>Subject</p>
<div class="subject">
Intent to Prototype:
feature one
</div>
<p>Body
<span class="tooltip copy-text" style="float:right"
title="Copy text to clipboard">
<a href="#" data-tooltip>
<iron-icon icon="chromestatus:content_copy"
id="copy-email-body"></iron-icon>
</a>
</span>
</p>
<p>Body
<span class="tooltip copy-text" style="float:right"
title="Copy text to clipboard">
<a href="#" data-tooltip>
<iron-icon icon="chromestatus:content_copy"
id="copy-email-body"></iron-icon>
</a>
</span>
</p>
<div class="email">
<h4>Contact emails</h4>
<div class="email">
<h4>Contact emails</h4>
<a href="mailto:user1@google.com">user1@google.com</a>
@ -311,14 +310,11 @@ False
<br><br><div><small>
This intent message was generated by
<a href="https://chromestatus.com">Chrome Platform Status</a>.
</small></div>
</div> <!-- end email body div -->
<br><br><div><small>
This intent message was generated by
<a href="https://chromestatus.com">Chrome Platform Status</a>.
</small></div>
</div> <!-- end email body div -->
</section>

Просмотреть файл

@ -44,8 +44,36 @@
{% if intent %}
<section>
<h3>Copy and send this text for your "Intent to ..." email</h3>
{% include "blink/intent_to_implement.html" %}
<h3>Copy and send this text for your "Intent to ..." email</h3>
<p>Email to</p>
<div class="subject">
blink-dev@chromium.org
</div>
<p>Subject</p>
<div class="subject">
{{subject_prefix}}:
{{feature.name}}
</div>
{#
Insted of vertical margins, <br> elements are used to create line breaks
that can be copied and pasted into a text editor.
#}
<p>Body
<span class="tooltip copy-text" style="float:right"
title="Copy text to clipboard">
<a href="#" data-tooltip>
<iron-icon icon="chromestatus:content_copy"
id="copy-email-body"></iron-icon>
</a>
</span>
</p>
<div class="email">
{% include "blink/intent_to_implement.html" %}
</div> <!-- end email body div -->
</section>
{% endif %}

Просмотреть файл

@ -1,31 +1,3 @@
<p>Email to</p>
<div class="subject">
blink-dev@chromium.org
</div>
<p>Subject</p>
<div class="subject">
{{subject_prefix}}:
{{feature.name}}
</div>
{#
Insted of vertical margins, <br> elements are used to create line breaks
that can be copied and pasted into a text editor.
#}
<p>Body
<span class="tooltip copy-text" style="float:right"
title="Copy text to clipboard">
<a href="#" data-tooltip>
<iron-icon icon="chromestatus:content_copy"
id="copy-email-body"></iron-icon>
</a>
</span>
</p>
<div class="email">
<h4>Contact emails</h4>
{% if not feature.browsers.chrome.owners %}None{% endif %}
{% for owner in feature.browsers.chrome.owners %}
@ -303,7 +275,8 @@
<br><br><h4>Links to previous Intent discussions</h4>
{% for stage in stage_info.proto_stages %}{% if stage.intent_thread_url %}
Intent to prototype: {{stage.intent_thread_url|urlize}}
Intent to Prototype: {{stage.intent_thread_url|urlize}}
<br>
{% endif %}{% endfor %}
{% for stage in stage_info.dt_stages %}{% if stage.announcement_url %}
@ -322,18 +295,14 @@
<br>
{% endif %}{% endfor %}
{% for stage in stage_info.extension_stages %}{% if stage.intent_thread_url %}
{% for stage in stage_info.ship_stages %}{% if stage.intent_thread_url %}
Intent to Ship: {{stage.intent_thread_url|urlize}}
<br>
{% endif %}{% endfor %}
{% endif %}
<br><br><div><small>
This intent message was generated by
<a href="https://chromestatus.com">Chrome Platform Status</a>.
</small></div>
</div> <!-- end email body div -->
<br><br><div><small>
This intent message was generated by
<a href="https://chromestatus.com">Chrome Platform Status</a>.
</small></div>

Просмотреть файл

@ -26,57 +26,41 @@
{% endif %}{% endfor %}
</table>
<table>
{% for stage in stage_info.ship_stages %}{% if stage.milestones.android_first %}
<tr><td>Shipping on Android</td>
<td>{{stage.milestones.android_first}}</td></tr>
{% endif %}{% endfor %}
{% for stage in stage_info.ot_stages %}{% if stage.milestones.android_last %}
<tr><td>OriginTrial Android last</td>
<td>{{stage.milestones.android_last}}</td></tr>
{% endif %}{% if stage.milestones.android_first %}
<tr><td>OriginTrial Android first</td>
{% for stage in stage_info.ot_stages %}{% if stage.milestones.android_first %}
<tr><td>Origin trial Android first</td>
<td>{{stage.milestones.android_first}}</td></tr>
{% endif %}{% if stage.milestones.android_last %}
<tr><td>Origin trial Android last</td>
<td>{{stage.milestones.android_last}}</td></tr>
{% endif %}{% endfor %}
{% for stage in stage_info.dt_stages %}{% if stage.milestones.android_first %}
<tr><td>DevTrial on Android</td>
<td>{{stage.milestones.android_first}}</td></tr>
{% endif %}{% endfor %}
</table>
<table>
{% for stage in stage_info.ship_stages %}{% if stage.milestones.webview_first %}
<tr><td>Shipping on WebView</td>
<td>{{stage.milestones.webview_first}}</td></tr>
{% endif %}{% endfor %}
{% for stage in stage_info.ot_stages %}{% if stage.milestones.webview_last %}
<tr><td>OriginTrial webView last</td>
<td>{{stage.milestones.webview_last}}</td></tr>
{% endif %}{% if stage.milestones.webview_first %}
<tr><td>OriginTrial webView first</td>
{% for stage in stage_info.ot_stages %}{% if stage.milestones.webview_first %}
<tr><td>Origin trial WebView first</td>
<td>{{stage.milestones.webview_first}}</td></tr>
{% endif %}{% if stage.milestones.webview_last %}
<tr><td>Origin trial WebView last</td>
<td>{{stage.milestones.webview_last}}</td></tr>
{% endif %}{% endfor %}
</table>
<table>
{% for stage in stage_info.ship_stages %}{% if stage.milestones.ios_first %}
<tr><td>Shipping on WebView</td>
<tr><td>Shipping on iOS</td>
<td>{{stage.milestones.ios_first}}</td></tr>
{% endif %}{% endfor %}