Remove unneeded install command. (#3427)

* Remove unneeded install command.

* Update playwright Dockerfile version. Make dependabot track Dockerfile updates (#3429)

* Update playwright Dockerfile version

Without this commit: `npm install` runs and installs the version in package.json which was 1.39 while the preinstalled browsers targeted playwright 1.37.


Now that we are relying on the already installed libraries and browsers, we can get rid of the npm install in the Dockerfile too. 

TODO: Modify [dependabot](https://github.com/GoogleChrome/chromium-dashboard/blob/main/.github/dependabot.yml) to update the docker image. This should help prevent package.json playwright from outpacing the docker file image.

* Update dependabot.yml to track Dockerfile updates

* try

* final

---------

Co-authored-by: James C Scott III <jcscottiii@users.noreply.github.com>
This commit is contained in:
Jason Robbins 2023-10-19 10:08:54 -07:00 коммит произвёл GitHub
Родитель bf295164f1
Коммит 6aeec90869
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
3 изменённых файлов: 13 добавлений и 2 удалений

10
.github/dependabot.yml поставляемый
Просмотреть файл

@ -15,3 +15,13 @@ updates:
reviewers:
- "kyleju"
- "jrobbins"
- package-ecosystem: "docker"
directory: "/"
schedule:
interval: "weekly"
commit-message:
# Prefix all commit messages with "docker"
prefix: "docker"
reviewers:
- "jrobbins"
- "jcscottiii"

Просмотреть файл

@ -0,0 +1 @@
node_modules

Просмотреть файл

@ -1,4 +1,4 @@
FROM mcr.microsoft.com/playwright:v1.37.1-jammy
FROM mcr.microsoft.com/playwright:v1.39.0-jammy
ARG USERID
ARG GROUPID
@ -18,6 +18,6 @@ USER pwuser
WORKDIR /work
# Cache the infrequent but time consuming changes early
COPY --chown=pwuser:pwuser package.json /work/
RUN npm install -D && npx playwright install
RUN npm install -D
# Copy the rest
COPY --chown=pwuser:pwuser . /work