googlechrome
/
chromium-dashboard
зеркало из https://github.com/GoogleChrome/chromium-dashboard.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Increase stages_api coverage to 100%, plus a drive-by fix (#2829) 

Co-authored-by: Kyle Ju <kyleju@chromium.org>
This commit is contained in:
Kyle Ju 2023-03-14 11:45:06 -07:00 коммит произвёл GitHub
Родитель fc0c4306e2
Коммит a1653c3745
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
2 изменённых файлов: 142 добавлений и 4 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

8
api/stages_api.py
Просмотреть файл

@ -105,12 +105,12 @@ class StagesAPI(basehandlers.APIHandler):
if field in body:
if stage.milestones is None:
stage.milestones = MilestoneSet()
setattr(stage.milestones, field, body['field'])
setattr(stage.milestones, field, body[field])
# Keep the gate type that might need to be created for the stage type.
gate_type: int | None = None
# Update type-specific fields.
if s_type == core_enums.STAGE_TYPES_DEV_TRIAL[feature_type]:
if s_type == core_enums.STAGE_TYPES_DEV_TRIAL[feature_type]: # pragma: no cover
gate_type = core_enums.GATE_API_PROTOTYPE
if s_type == core_enums.STAGE_TYPES_ORIGIN_TRIAL[feature_type]:
@ -121,11 +121,11 @@ class StagesAPI(basehandlers.APIHandler):
self._add_given_stage_vals(stage, body, self.OT_EXTENSION_FIELDS)
gate_type = core_enums.GATE_API_EXTEND_ORIGIN_TRIAL
if s_type == core_enums.STAGE_TYPES_SHIPPING[feature_type]:
if s_type == core_enums.STAGE_TYPES_SHIPPING[feature_type]: # pragma: no cover
self._add_given_stage_vals(stage, body, self.SHIPPING_FIELDS)
gate_type = core_enums.GATE_API_SHIP
if s_type == core_enums.STAGE_TYPES_ROLLOUT[feature_type]:
if s_type == core_enums.STAGE_TYPES_ROLLOUT[feature_type]: # pragma: no cover
self._add_given_stage_vals(stage, body, self.ENTERPRISE_FIELDS)
stage.put()

138
api/stages_api_test.py
Просмотреть файл

@ -51,6 +51,28 @@ class StagesAPITest(testing_config.CustomTestCase):
self.stage_2 = Stage(id=11, feature_id=1, stage_type=160)
self.stage_2.put()
self.stage_3 = Stage(id=30, feature_id=99, stage_type=150, browser='Chrome',
ux_emails=['ux_person@example.com'],
intent_thread_url='https://example.com/intent',
milestones=MilestoneSet(desktop_first=100),
experiment_goals='To be the very best.')
self.stage_3.put()
self.stage_4 = Stage(id=40, feature_id=1, stage_type=150, browser='Chrome',
ux_emails=['ux_person@example.com'],
intent_thread_url='https://example.com/intent',
milestones=MilestoneSet(desktop_first=100),
experiment_goals='To be the very best.')
self.stage_4.put()
self.stage_5 = Stage(id=50, feature_id=1, stage_type=150, browser='Chrome',
ot_stage_id=40,
ux_emails=['ux_person@example.com'],
intent_thread_url='https://example.com/intent',
milestones=MilestoneSet(desktop_first=100),
experiment_goals='To be the very best.')
self.stage_5.put()
self.expected_stage_1 = {
'id': 10,
'feature_id': 1,
@ -115,6 +137,70 @@ class StagesAPITest(testing_config.CustomTestCase):
self.assertEqual(self.expected_stage_1, actual)
def test_get__valid_with_extension(self):
"""Returns stage data with extension if requesting a valid stage ID."""
extension = {
'id': 50,
'feature_id': 1,
'stage_type': 150,
'intent_stage': 3,
'pm_emails': [],
'tl_emails': [],
'ux_emails': ['ux_person@example.com'],
'te_emails': [],
'intent_thread_url': 'https://example.com/intent',
'intent_to_experiment_url': 'https://example.com/intent',
'desktop_first': 100,
'desktop_last': None,
'android_first': None,
'android_last': None,
'webview_first': None,
'webview_last': None,
'experiment_goals': 'To be the very best.',
'experiment_risks': None,
'ot_milestone_android_end': None,
'ot_milestone_android_start': None,
'ot_milestone_desktop_end': None,
'ot_milestone_desktop_start': 100,
'ot_milestone_webview_end': None,
'ot_milestone_webview_start': None,
'origin_trial_feedback_url': None}
expect = {
'id': 40,
'feature_id': 1,
'stage_type': 150,
'intent_stage': 3,
'pm_emails': [],
'tl_emails': [],
'ux_emails': ['ux_person@example.com'],
'te_emails': [],
'intent_thread_url': 'https://example.com/intent',
'intent_to_experiment_url': 'https://example.com/intent',
'intent_to_extend_experiment_url': 'https://example.com/intent',
'desktop_first': 100,
'desktop_last': None,
'android_first': None,
'android_last': None,
'webview_first': None,
'webview_last': None,
'experiment_extension_reason': None,
'experiment_goals': 'To be the very best.',
'experiment_risks': None,
'extensions': [extension],
'ot_milestone_android_end': None,
'ot_milestone_android_start': None,
'ot_milestone_desktop_end': None,
'ot_milestone_desktop_start': 100,
'ot_milestone_webview_end': None,
'ot_milestone_webview_start': None,
'origin_trial_feedback_url': None}
with test_app.test_request_context(f'{self.request_path}1/stages/10'):
actual = self.handler.do_get(feature_id=1, stage_id=40)
self.assertEqual(expect, actual)
@mock.patch('flask.abort')
def test_post__not_allowed(self, mock_abort):
"""Raises 403 if user has no edit access to feature."""
@ -130,6 +216,18 @@ class StagesAPITest(testing_config.CustomTestCase):
self.handler.do_post(feature_id=1)
mock_abort.assert_called_once_with(403)
@mock.patch('framework.permissions.validate_feature_edit_permission')
def test_post__Redirect(self, permission_call):
"""Lack of permission in POST and redirect users."""
permission_call.return_value = 'fake response'
testing_config.sign_in('feature_owner@example.com', 123)
with test_app.test_request_context(
f'{self.request_path}1/stages/10'):
actual = self.handler.do_post(feature_id=1)
self.assertEqual(actual, 'fake response')
@mock.patch('flask.abort')
def test_post__bad_id(self, mock_abort):
"""Raises 404 if ID does not match any feature."""
@ -179,6 +277,7 @@ class StagesAPITest(testing_config.CustomTestCase):
testing_config.sign_in('feature_owner@example.com', 123)
json = {
'stage_type': 151,
'desktop_first': 100,
'intent_thread_url': 'https://example.com/different'}
with test_app.test_request_context(
@ -244,6 +343,34 @@ class StagesAPITest(testing_config.CustomTestCase):
self.handler.do_patch(feature_id=1)
mock_abort.assert_called_once_with(404, description='No stage specified.')
@mock.patch('flask.abort')
def test_patch__no_feature(self, mock_abort):
"""Raises 404 if no feature was found."""
testing_config.sign_in('feature_owner@example.com', 123)
json = {
'intent_thread_url': 'https://example.com/different'}
mock_abort.side_effect = werkzeug.exceptions.BadRequest
with test_app.test_request_context(
f'{self.request_path}1/stages', json=json):
with self.assertRaises(werkzeug.exceptions.BadRequest):
self.handler.do_patch(stage_id=30)
description = 'Feature 99 not found associated with stage 30'
mock_abort.assert_called_once_with(404, description=description)
@mock.patch('framework.permissions.validate_feature_edit_permission')
def test_patch__Redirect(self, permission_call):
"""Lack of permission in Patch and redirect users."""
permission_call.return_value = 'fake response'
testing_config.sign_in('feature_owner@example.com', 123)
with test_app.test_request_context(
f'{self.request_path}1/stages/10'):
actual = self.handler.do_patch(stage_id=10)
self.assertEqual(actual, 'fake response')
@mock.patch('flask.abort')
def test_patch__stage_type_change_attempt(self, mock_abort):
"""stage_type field cannot be mutated."""
@ -318,3 +445,14 @@ class StagesAPITest(testing_config.CustomTestCase):
actual = self.handler.do_delete(feature_id=1, stage_id=10)
self.assertEqual(actual['message'], 'Stage archived.')
self.assertEqual(self.stage_1.archived, True)
@mock.patch('framework.permissions.validate_feature_edit_permission')
def test_delete__Redirect(self, permission_call):
"""Lack of permission in Delete and redirect users."""
permission_call.return_value = 'fake response'
with test_app.test_request_context(f'{self.request_path}1/stages/10'):
actual = self.handler.do_delete(feature_id=1, stage_id=10)
self.assertEqual(actual, 'fake response')