From ec543aeeae6c7ed8aad51102e6546737eed5cde5 Mon Sep 17 00:00:00 2001
From: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Thu, 11 Jul 2024 16:35:07 -0700
Subject: [PATCH] fix test rendering and lint

---
 .../chromedash-guide-intent-preview.js        |  2 +-
 .../chromedash-intent-template_test.js        |  1 -
 client-src/js-src/cs-client.js                |  2 +-
 internals/reminders_test.py                   |  2 +-
 ...mail_tasks_escalated_feature_accuracy.html | 16 -----
 ...st_build_email_tasks_feature_accuracy.html | 16 -----
 ...ail_tasks_feature_accuracy_enterprise.html | 16 -----
 .../test_html_rendering.html                  | 58 +++++++++----------
 8 files changed, 30 insertions(+), 83 deletions(-)

diff --git a/client-src/elements/chromedash-guide-intent-preview.js b/client-src/elements/chromedash-guide-intent-preview.js
index c6e1560d..8687ed3a 100644
--- a/client-src/elements/chromedash-guide-intent-preview.js
+++ b/client-src/elements/chromedash-guide-intent-preview.js
@@ -21,7 +21,7 @@ class ChromedashGuideIntentPreview extends LitElement {
       stage: {type: Object},
       gate: {type: Object},
       loading: {type: Boolean},
-      subject: {type:String},
+      subject: {type: String},
       intentBody: {type: String},
       displayFeatureUnlistedWarning: {type: Boolean},
     };
diff --git a/client-src/elements/chromedash-intent-template_test.js b/client-src/elements/chromedash-intent-template_test.js
index 8b15d0c7..4e34ef62 100644
--- a/client-src/elements/chromedash-intent-template_test.js
+++ b/client-src/elements/chromedash-intent-template_test.js
@@ -3,7 +3,6 @@ import {assert, fixture} from '@open-wc/testing';
 import {ChromedashIntentTemplate} from './chromedash-intent-template';
 
 describe('chromedash-intent-template', () => {
-
   it('renders with fake data', async () => {
     const component = await fixture(
       html`<chromedash-intent-template
diff --git a/client-src/js-src/cs-client.js b/client-src/js-src/cs-client.js
index bb4ce9f6..ecfce7dd 100644
--- a/client-src/js-src/cs-client.js
+++ b/client-src/js-src/cs-client.js
@@ -647,7 +647,7 @@ export class ChromeStatusClient {
 
   // Intents API
   async getIntentBody(featureId, stageId) {
-    return this.doGet(`/features/${featureId}/${stageId}/intent`)
+    return this.doGet(`/features/${featureId}/${stageId}/intent`);
   }
   async postIntentToBlinkDev(featureId, stageId, body) {
     return this.doPost(`/features/${featureId}/${stageId}/intent`, body);
diff --git a/internals/reminders_test.py b/internals/reminders_test.py
index 7d4c1972..008b3df8 100644
--- a/internals/reminders_test.py
+++ b/internals/reminders_test.py
@@ -174,7 +174,7 @@ class FunctionTest(testing_config.CustomTestCase):
     self.assertEqual('feature_owner@example.com', task['to'])
     self.assertEqual('[Action requested] Update feature one', task['subject'])
     self.assertEqual(None, task['reply_to'])
-    TESTDATA.make_golden(task['html'], 'test_build_email_tasks_feature_accuracy_enterprise.html')
+    # TESTDATA.make_golden(task['html'], 'test_build_email_tasks_feature_accuracy_enterprise.html')
     self.assertMultiLineEqual(
         TESTDATA['test_build_email_tasks_feature_accuracy_enterprise.html'],
         task['html'])
diff --git a/internals/testdata/reminders_test/test_build_email_tasks_escalated_feature_accuracy.html b/internals/testdata/reminders_test/test_build_email_tasks_escalated_feature_accuracy.html
index 94b210ec..75d4cd3b 100644
--- a/internals/testdata/reminders_test/test_build_email_tasks_escalated_feature_accuracy.html
+++ b/internals/testdata/reminders_test/test_build_email_tasks_escalated_feature_accuracy.html
@@ -63,27 +63,11 @@
     
     
 
-  </table>
-
-  <table>
-
     
     
     
-
-  </table>
-
-
-  <table>
-
     
     
-
-  </table>
-
-
-  <table>
-
     
     
 
diff --git a/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy.html b/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy.html
index bc183685..dd464256 100644
--- a/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy.html
+++ b/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy.html
@@ -58,27 +58,11 @@
     
     
 
-  </table>
-
-  <table>
-
     
     
     
-
-  </table>
-
-
-  <table>
-
     
     
-
-  </table>
-
-
-  <table>
-
     
     
 
diff --git a/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy_enterprise.html b/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy_enterprise.html
index 9b097f39..01d86d29 100644
--- a/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy_enterprise.html
+++ b/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy_enterprise.html
@@ -58,27 +58,11 @@
     
     
 
-  </table>
-
-  <table>
-
     
     
     
-
-  </table>
-
-
-  <table>
-
     
     
-
-  </table>
-
-
-  <table>
-
     
     
 
diff --git a/pages/testdata/intentpreview_test/test_html_rendering.html b/pages/testdata/intentpreview_test/test_html_rendering.html
index 2120a70b..b1bc02f5 100644
--- a/pages/testdata/intentpreview_test/test_html_rendering.html
+++ b/pages/testdata/intentpreview_test/test_html_rendering.html
@@ -139,33 +139,32 @@ limitations under the License.
 
 
 <section>
-<h3>Copy and send this text for your "Intent to ..." email</h3>
-<p>Email to</p>
-<div class="subject">
-  blink-dev@chromium.org
-</div>
+  <h3>Copy and send this text for your "Intent to ..." email</h3>
+  <p>Email to</p>
+  <div class="subject">
+    blink-dev@chromium.org
+  </div>
 
-<p>Subject</p>
-<div class="subject">
-  Intent to Prototype:
-  feature one
-</div>
+  <p>Subject</p>
+  <div class="subject">
+    Intent to Prototype:
+    feature one
+  </div>
 
+  
 
+  <p>Body
+    <span class="tooltip copy-text" style="float:right"
+          title="Copy text to clipboard">
+        <a href="#" data-tooltip>
+          <iron-icon icon="chromestatus:content_copy"
+                    id="copy-email-body"></iron-icon>
+        </a>
+    </span>
+  </p>
 
-<p>Body
-  <span class="tooltip copy-text" style="float:right"
-        title="Copy text to clipboard">
-      <a href="#" data-tooltip>
-        <iron-icon icon="chromestatus:content_copy"
-                   id="copy-email-body"></iron-icon>
-      </a>
-  </span>
-</p>
-
-<div class="email">
-
-  <h4>Contact emails</h4>
+  <div class="email">
+      <h4>Contact emails</h4>
   
   
     <a href="mailto:user1@google.com">user1@google.com</a>
@@ -311,14 +310,11 @@ False
 
 
 
-
-
-<br><br><div><small>
-  This intent message was generated by
-  <a href="https://chromestatus.com">Chrome Platform Status</a>.
-</small></div>
-
-</div> <!-- end email body div -->
+  <br><br><div><small>
+    This intent message was generated by
+    <a href="https://chromestatus.com">Chrome Platform Status</a>.
+  </small></div>
+  </div> <!-- end email body div -->
 </section>