Граф коммитов

297 Коммитов

Автор SHA1 Сообщение Дата
Jason Robbins cbfb373d70
Implement attachment_api and serving of attachments (#4541)
* WIP

* progress

* revert undesired changes

* progress

* Added redirect

* Fix API parameter name and lint-fix.

* tests

* testing progress

* Finished tests

* Addressed review comments
2024-11-08 10:19:55 -08:00
Kyle Ju bbfa6c8d0d
Highlight outdated feature entries on roadmap (#4472)
* Add outdated logic

* Explain feature oudated icons

* Address comments

* UI tests

* Another fix

* lint
2024-10-23 17:09:54 -07:00
Jason Robbins df3e080dd6
Update shipping_year when milestones are edited. (#4397)
* Update shipping_year when milestones are edited.

* Only check if the user edited a shipping stage
2024-09-27 10:19:14 -07:00
Jason Robbins 5d7522ca7f
Cache full search results. (#4382)
* Cache full search results.

* Addressed review comments.
2024-09-24 11:02:02 -07:00
Jason Robbins 868baf9087
Align feature_type enum names on client and server. (#4379)
* Align feature_type enums on client and server.

* typos
2024-09-21 14:20:03 -07:00
Jason Robbins 22b6a18127
add security checks to report apis (#4375)
* Add permission checking for reports API and avoid login redirect for any API GET.

* snapshots

* Re-ran playwright

* Re-ran playwright
2024-09-19 10:37:40 -07:00
Kyle Ju d5f5788230
Load feature names only for the /newfeatures page (#4337)
* Implementation

* Check entries length in tests

* Nits
2024-09-18 11:54:32 -07:00
Daniel Smith 0697666a50
OT Creation allows for the selection of WebDXFeature use counters (server-side) (#4267)
* Obtain chromium source files concurrently

* remove log

* Add validation logic for WebDXFeature use counters

* Change implementation to use string prefix
2024-09-05 13:50:03 -07:00
Jason Robbins ee836d22bd
Record an Activity when assigning a reviewer. (#4316) 2024-08-30 10:15:18 -07:00
Mark Xiong 2ea0e2f2a0
OpenAPI: stars_api (#4254)
* stars get

* post

* case to model

* feature_id backward compatibility

* lint

* adjust assertion in tests
2024-08-29 22:05:54 -05:00
Mark Xiong 6e22d7d6e6
OpenAPI: OT (#4226)
* origin trial obj

* origin trial

* typo

* creat ot models

* save

* stage field

* request obj

* add none check to update field

* patch

* change data structure

* info value seperation

* correct diff msgs

* mapping

* run: npm run openapi

* resolve conflicts

* add models back

---------

Co-authored-by: James Scott <jamescscott@google.com>
2024-08-29 02:23:27 -05:00
Mark Xiong 2e0800e319
OpenAPI: settings_api (#4253)
* settings api

* fix para name

* request rename
2024-08-29 00:31:59 -05:00
Mark Xiong d841c893b8
OpenAPI: login logout (#4220)
* login logout

* error handling
2024-08-29 00:23:56 -05:00
Daniel Smith d02bcaa64f
Make certain props in feature links nullable (#4281)
* make certain props in feature links nullable

* update openapi models

* update TS type def for FeatureLink

* remove information and http_error_code required

* Use LinkPreview instead of LinkPreviewBase

* information set to optional
2024-08-25 11:30:07 -07:00
Daniel Smith 7ba365892b
Obtain Chromium source files concurrently (#4266)
* Obtain chromium source files concurrently

* remove log

* Update origin_trials_api.py
2024-08-23 10:32:10 -07:00
Mark Xiong a3a26cc2b8
OpenAPI: review_api (#4250)
* process

* process models

* seperate progress item

* fix reserved word

* progress

* vote model

* vote api done

* get gates for a feature

* xfn gates

* remove white space

* merge
2024-08-23 09:38:07 -05:00
Mark Xiong dd4a0a4d6b
token refresh (#4255) 2024-08-23 08:39:31 -05:00
Mark Xiong 532109ed78
OpenAPI: component_users (#4199)
* cast to models

* changed to from_dict

* delete param
2024-08-23 08:38:47 -05:00
Mark Xiong fbe07e7aa0
OpenAPI: comments_api (#4195)
* generated code

* add models

* map json fields

* casting post objects to models

* from dict

* modify test to models

* resolve conflicts

* fix datetime

* resolve conflicts

* regenerate models

* reorganize

* changing helper names
2024-08-23 08:26:36 -05:00
Daniel Smith 34cf3cddb4
handle ID key in changes dictionary (#4265) 2024-08-22 15:55:52 -07:00
Daniel Smith ce04546dbd
Disable OT milestone edits during automated OT creation process (server-side) (#4236)
* No OT milestone edits during OT creation process

* fix imports
2024-08-21 08:50:46 -07:00
Jason Robbins 6edf33db53
Add shipping_year field. (#4257)
* Add shipping_year field.

* formatting

* updated screenshots

* updated typedict

* Updated screenshots again
2024-08-20 13:26:56 -07:00
Mark Xiong 9c59fd4858
OpenAPI: feature links (#4213)
* OAS

* openapi modelas

* links sample datastructure

* cast to models

* handler with openapi models
2024-08-14 14:22:59 -05:00
Mark Xiong 70b3eba8c5
permissions (#4227) 2024-08-12 22:09:21 -05:00
Mark Xiong 59a78a87bd
dismissed cue (#4211) 2024-08-07 15:39:21 -05:00
Mark Xiong ee876747bc
OpenAPI: accounts_api (#4130)
* accounts api specification

* generated code

* adding Type to response

* convert to dic

* accounts api specification

* generated code

* adding Type to response

* convert to dic

* generated code

rebase main
2024-08-05 16:58:39 -05:00
Daniel Smith e4b279863d
[3/3] New Intent SPA component and direct intent posting (#4114)
* new Intents API and notifier for intent sending

* OpenAPI for Intents API

* Add request body for Intents API POST

* reference request object correctly

* Intents API tests

* notifier tests for intent posting

* fix tests

* changes suggested by @jrobbins

* changes suggested by @jcscottiii

* Fix tests and add new ones

* mypy and test fix

* Changes suggested by @jcscottiii

* Use OpenAPI object to create response

* UI changes and paths for intent draft and posting

* changes suggested by @jrobbins

* lint-fix

* read subject from API response

* remove unused imports

* Move copy intent body event to @click

* Additional fixes

intents_api.py: Pass in `gate_id` for intent GET request to populate URL query string. Also, pass `sections_to_show` param for template rendering.
chromedash-intent-preview-page.js: When finding matching stage, search extension stages as well.
cs-client.js: Pass `gateId` in GET request.
notifier.py: Add APP_TITLE to populate intent template.
main.py: Update route for passing `gate_id` in GET request.
api.yaml: Add definition for `gate_id` in GET request.
2024-07-25 12:08:06 -07:00
Daniel Smith b7245b4860
extension stages are correctly ordered (#4151) 2024-07-23 17:43:00 -07:00
Daniel Smith c7bf9c0eaa
[2/3] New Intents API (#4113)
* new Intents API and notifier for intent sending

* OpenAPI for Intents API

* Add request body for Intents API POST

* reference request object correctly

* Intents API tests

* notifier tests for intent posting

* fix tests

* changes suggested by @jrobbins

* changes suggested by @jcscottiii

* Fix tests and add new ones

* mypy and test fix

* Changes suggested by @jcscottiii

* Use OpenAPI object to create response
2024-07-23 17:42:07 -07:00
Daniel Smith 85faf4a48f
Add setting for automated OT creation flag (#4122)
* Add setting for automated OT creation toggle

* Update cron.yaml

* add/change tests
2024-07-17 15:14:50 -07:00
Daniel Smith e2f703d1d8
Add new OT approvals field `ot_approval_buganizer_custom_field_id` (#4061)
* Add new OT approvals field

* lint-fix

* add field to api_specs

* update field description

* lint-fix
2024-07-09 12:42:43 -07:00
Daniel Smith 3caf3559b1
"N/A" counted as approved for trial extensions (#4081)
* "N/A" counted as approved for trial extensions

* fix test and add a new one
2024-07-09 11:17:02 -07:00
Daniel Smith bac5ca7410
Gate OT creation form to require approvals beforehand (#3897)
* Gate OT creation form to require approvals before

* update PW tests

* merge fix
2024-06-24 13:10:43 -07:00
Daniel Smith c2d63034c3
OT creation process uses new enum field (#3918)
* new OT field `ot_setup_status`

* OT creation process uses new enum field

* Add test for trial creation request

* changes suggested by @KyleJu

* changes suggested by @KyleJu

* change data type for test
2024-06-24 11:49:33 -07:00
Daniel Smith c8508f1442
new OT Stage field `ot_setup_status` (#3917)
* new OT field `ot_setup_status`

* Add test for new field
2024-06-18 13:50:37 -07:00
Jason Robbins 1d9fbfb69b
Fix date-dependent test (#3966) 2024-06-12 18:17:46 -07:00
Jason Robbins 7e0c7c0769
Allow @google and @chromium users to request OTs. (#3942)
* Allow @google and @chromium users to request OTs.

* Added TODO about using 401s.
2024-06-06 16:50:31 -07:00
Jason Robbins 729c315d08
Fix checking for usecounter (#3907)
* Fix checking for usecounter

* Avoid using async to simplify testing.
2024-05-23 15:48:04 -07:00
Daniel Smith eceab54a3a
extension stages added to ot stages later (#3892) 2024-05-20 10:14:32 -07:00
Daniel Smith 47b19d98f4
Remove OT extension request notification references (#3885)
* remove reference to extension notification

* add test to ensure extension notification not sent

* Add comment about new enum
2024-05-15 19:42:42 -07:00
Daniel Smith 26d10edda1
Add new Stage field `ot_activation_date` (#3855)
* add new field "ot_activation_date"

* add to StageDict

* make ot_activation_date optional on stagedict

* ot_activation_date not required
2024-05-09 13:31:14 -07:00
Daniel Smith 42668ce7b2
OT creation form bug fixes (#3865)
* OT creation form bug fixes

* non-deprecation trials require a usecounter value

* lint fix
2024-05-09 12:55:13 -07:00
Jeffrey Yasskin 285d520f68
Add a report on external review status (#3819) 2024-04-29 13:16:56 -07:00
Daniel Smith 028184618e
Utilize "OT Extension approved" email template (#3815)
* New "OT extension approved" email template

* send to requester email and OT support

* update test to remove inconsistency

* Notify about extension when gate is approved

* ensure checked gate is an extension gate

* changes suggested by @jrobbins
2024-04-24 11:21:25 -07:00
Daniel Smith ef4faa38ff
utilize "OT Extended" email template (#3814) 2024-04-24 11:21:13 -07:00
Daniel Smith 450cbeea9e
Update async Chromium file checks (#3807) 2024-04-22 10:51:42 -07:00
Daniel Smith d8cf7f26f1
Obtain Chromium file contents asynchronously (#3801)
* Squashed commit of the following:

commit 5ee220fded
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 17:11:42 2024 -0700

    npm: bump @babel/preset-env from 7.24.3 to 7.24.4 (#3799)

    Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.24.3 to 7.24.4.
    - [Release notes](https://github.com/babel/babel/releases)
    - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/babel/babel/commits/v7.24.4/packages/babel-preset-env)

    ---
    updated-dependencies:
    - dependency-name: "@babel/preset-env"
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 66c768273e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 16:21:28 2024 -0700

    npm: bump rollup from 4.14.1 to 4.14.3 (#3797)

    Bumps [rollup](https://github.com/rollup/rollup) from 4.14.1 to 4.14.3.
    - [Release notes](https://github.com/rollup/rollup/releases)
    - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/rollup/rollup/compare/v4.14.1...v4.14.3)

    ---
    updated-dependencies:
    - dependency-name: rollup
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit bea0dd3af3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 15:47:05 2024 -0700

    npm: bump @babel/core from 7.24.3 to 7.24.4 (#3798)

    Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.24.3 to 7.24.4.
    - [Release notes](https://github.com/babel/babel/releases)
    - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/babel/babel/commits/v7.24.4/packages/babel-core)

    ---
    updated-dependencies:
    - dependency-name: "@babel/core"
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 4142251f32
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 15:46:43 2024 -0700

    npm: bump tar from 6.2.1 to 7.0.1 (#3796)

    Bumps [tar](https://github.com/isaacs/node-tar) from 6.2.1 to 7.0.1.
    - [Release notes](https://github.com/isaacs/node-tar/releases)
    - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/isaacs/node-tar/compare/v6.2.1...v7.0.1)

    ---
    updated-dependencies:
    - dependency-name: tar
      dependency-type: direct:development
      update-type: version-update:semver-major
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 57437c166c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 15:46:15 2024 -0700

    npm: bump sass from 1.74.1 to 1.75.0 (#3795)

    Bumps [sass](https://github.com/sass/dart-sass) from 1.74.1 to 1.75.0.
    - [Release notes](https://github.com/sass/dart-sass/releases)
    - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/sass/dart-sass/compare/1.74.1...1.75.0)

    ---
    updated-dependencies:
    - dependency-name: sass
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6358a50bfa
Author: Jeffrey Yasskin <jyasskin@google.com>
Date:   Mon Apr 15 12:30:20 2024 -0700

    Show feature links in the Consensus section (#3791)

    Also denormalizes external reviewer positions into the FeatureEntries table.

commit cf742510fa
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Mon Apr 15 10:20:25 2024 -0700

    Check that OT Chromium name not used by other OTs (#3792)

* async calls

* update tests

* type hinting

* remove print

* Changes suggested by @jrobbins

* lint fix
2024-04-18 11:39:01 -07:00
Daniel Smith c6b40378ee
Validate OT creation arguments (API) (#3794)
* Check that OT Chromium name not used by other OTs

* Add method for validating OT creation arguments

* Handle Chromium checks in API

* Squashed commit of the following:

commit 5ee220fded
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 17:11:42 2024 -0700

    npm: bump @babel/preset-env from 7.24.3 to 7.24.4 (#3799)

    Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.24.3 to 7.24.4.
    - [Release notes](https://github.com/babel/babel/releases)
    - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/babel/babel/commits/v7.24.4/packages/babel-preset-env)

    ---
    updated-dependencies:
    - dependency-name: "@babel/preset-env"
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 66c768273e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 16:21:28 2024 -0700

    npm: bump rollup from 4.14.1 to 4.14.3 (#3797)

    Bumps [rollup](https://github.com/rollup/rollup) from 4.14.1 to 4.14.3.
    - [Release notes](https://github.com/rollup/rollup/releases)
    - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/rollup/rollup/compare/v4.14.1...v4.14.3)

    ---
    updated-dependencies:
    - dependency-name: rollup
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit bea0dd3af3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 15:47:05 2024 -0700

    npm: bump @babel/core from 7.24.3 to 7.24.4 (#3798)

    Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.24.3 to 7.24.4.
    - [Release notes](https://github.com/babel/babel/releases)
    - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/babel/babel/commits/v7.24.4/packages/babel-core)

    ---
    updated-dependencies:
    - dependency-name: "@babel/core"
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 4142251f32
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 15:46:43 2024 -0700

    npm: bump tar from 6.2.1 to 7.0.1 (#3796)

    Bumps [tar](https://github.com/isaacs/node-tar) from 6.2.1 to 7.0.1.
    - [Release notes](https://github.com/isaacs/node-tar/releases)
    - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/isaacs/node-tar/compare/v6.2.1...v7.0.1)

    ---
    updated-dependencies:
    - dependency-name: tar
      dependency-type: direct:development
      update-type: version-update:semver-major
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 57437c166c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 15 15:46:15 2024 -0700

    npm: bump sass from 1.74.1 to 1.75.0 (#3795)

    Bumps [sass](https://github.com/sass/dart-sass) from 1.74.1 to 1.75.0.
    - [Release notes](https://github.com/sass/dart-sass/releases)
    - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/sass/dart-sass/compare/1.74.1...1.75.0)

    ---
    updated-dependencies:
    - dependency-name: sass
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6358a50bfa
Author: Jeffrey Yasskin <jyasskin@google.com>
Date:   Mon Apr 15 12:30:20 2024 -0700

    Show feature links in the Consensus section (#3791)

    Also denormalizes external reviewer positions into the FeatureEntries table.

commit cf742510fa
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Mon Apr 15 10:20:25 2024 -0700

    Check that OT Chromium name not used by other OTs (#3792)

* Update package-lock.json

* lint fix
2024-04-18 10:37:28 -07:00
Jeffrey Yasskin 6358a50bfa
Show feature links in the Consensus section (#3791)
Also denormalizes external reviewer positions into the FeatureEntries table.
2024-04-15 12:30:20 -07:00
Jason Robbins 62878647d6
Reduce the number of parallel ndb queries. (#3772) 2024-04-03 14:22:48 -07:00