* Make fieldId optional in comments API.
* Add index needed for retrieving review comments.
* Add index needed for retrieving review comments.
* Add index needed for retrieving review comments.
* Add index needed for retrieving review comments.
* Add index needed for retrieving review comments.
* Use toast rather than alert().
* Update static/elements/chromedash-roadmap.js
Co-authored-by: Kyle Ju <kyleju@google.com>
* Update static/elements/chromedash-roadmap.js
Co-authored-by: Kyle Ju <kyleju@google.com>
Co-authored-by: Kyle Ju <kyleju@google.com>
* Make the myfeatures page be one big webcomponent.
* Update static/elements/chromedash-feature-table.js
Co-authored-by: Kyle Ju <kyleju@google.com>
* Addressed review comment
Co-authored-by: Kyle Ju <kyleju@google.com>
* wrote code
* Added unit tests and removed unwanted CSS.
* Use warning() because warn() is deprecated.
* Update internals/models.py
Co-authored-by: Kyle Ju <kyleju@google.com>
* Incorporated review comments.
Co-authored-by: Kyle Ju <kyleju@google.com>
* Added support for scrolling back to Chrome release 1
* optimised the scrolling process
* Using variable instead of hard-coded values for easy value change in future
* Added support for getting schedule of specified range of channels API
* Loading the next three milestones in advance after loading the first three milestones
* Channels API will send information of only three standard channels
* Added support for binding the properties to the new milestone cards
* Changed variable name to make code more readable
* Made the code DRY w.r.t mapFeaturestoShippingType
* Fetching in advance on second last element
* Added variables instead of static values
* Previous Button will not scroll to versions before stable
* Undo Changes in index.yaml
* Deleted commented lines
* Fixed a comment
* Ask user to reload the page if some error occurs
* Added Support for highlight on hover over a feature
* Removed unnecessary spaces
* Map feature to shipping type at the backend
* Frontend no longer maps features to shipping type
* Fixed tests in models_test.py
* Fixed tests in features_api_test.py
* Added support for getting schedule of specified range of channels API
* Loading the next three milestones in advance after loading the first three milestones
* Channels API will send information of only three standard channels
* Added support for binding the properties to the new milestone cards
* Changed variable name to make code more readable
* Made the code DRY w.r.t mapFeaturestoShippingType
* Fetching in advance on second last element
* Added variables instead of static values
* Previous Button will not scroll to versions before stable
* Undo Changes in index.yaml
* Deleted commented lines
* Fixed a comment
* Ask user to reload the page if some error occurs
* Added comments and a constant
* Changed a function name
* Changed variable names
* Removed unnecessary blank lines
* Changed an old variable name
* Changed Implementation of sortFeaturesByName
* Removed two & from query string
* Added space around operators
* Changed implementation of sort function
* Made Position of arrows responsive
* Some CSS Improvements
* Display Only Single Milestone on narrow view ports
* Compute the number of items to be displayed according to the size of display
* Fetching schedule of Dev plus one version
* Added four cards
* Added Slideable cards
* Added timeline controls
* Responsive Design
* Improved implementation
* Timeline Controls should not be displayed in narrow viewports
* Added GreyScale logo for milestones later than dev
* Changed the location of the timeline control buttons to above the container
* Using Webcomponent for each milestone card
* Fixed Bug: Signed User would be asked to sign in when trying to star a feature
* CSS Improvements
* Removed unnecessary function call
* Added Annotations for Shipping Type
* BugFix: Even if some error occurred on the server, the UI would update to show the feature as starred
* Factored the Event Creation and event call to a method
* Internationalization Modifications
* Added Some comments
* Binding properties to variables without passing them in the attribute
* Lint Fix
* Made render method modular
* Removed Single Quotes Around values
* Renamed ShowBlink variable to ShowShippingType
* Updated Download links on upcoming page
* Created Upcoming page by duplicating code from schedule page
* The new upcoming page now uses Features and Channels API to fetch data
* Fetching features of each milestone separately
* Using csClient for fetching information
* Removed unreferenced variable set from upcoming-page.js
* Fixed Right Margin Around the Feature Cards in Mobile View
* Fixed Add Feature Button on Mobile UI
* Fixed NavBar on narrow viewports
* Added a custom Google Sign In Button
* Redesigned the Google Sign In Button
* Google Sign In Image
* Added DropDown Menu for Chrome Version
* Added all the Chromium Statuses that were not directly accessible
* Reverted index.yaml
* 'Canary' 'Dev' 'Beta' 'Stable' will be displayed next to version number depending on the class name
* Clicking on 'X' in Filter Input Box will select the 'Select Chrome Version' option in Chrome Versions List
* Changed Label to Filter By
* Make it so Adam A is notified of CSS Changes
* Fix incorrect percentage sorting
* Corrected typo
* Removed change unrelated to this PR
* Removed unused variable
Co-authored-by: Joe Medley <jmedley@google.com>
* Partial progress
* more progress
* Basically done
* prepared demo for chromedash-feature-detail
* Added new field api_spec
* add more tests
* Revert most of templates/feature.html for this CL
* fixed typos
* Partial progress for demo
* Added a separate card and POST handlers.
* Remove instructions about leaving because Guide UX prompts for webview milestone only when appropriate
* remove unused constant
* Fixed a spelling error
* Fixed copy-paste error for one field.
* Implement separate servlet for intent emails and indent template source
* Redid template conditions
* Update templates/admin/features/launch.html
* Update templates/admin/features/launch.html
* added auth and tests
* Move subject line compution to python and add test
Co-authored-by: Jason Robbins <jrobbins@chromium.org>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: aglaforge <35039800+aglaforge@users.noreply.github.com>
* Add launch bug URL, add try link at top, style tweaks.
* Add feedback link
* New UI link on add feature form
* Added link to launch bug template
Co-authored-by: Jason Robbins <jrobbins@chromium.org>
* Define all stage-specific forms and their fields.
* Implement checkboxes to advance stage, and fix alignment.
* Specified actions in process.py and CSS tweaks.
* Update guideforms.py
Co-authored-by: Joe Medley <jmedley@google.com>
* Update guideforms.py
Co-authored-by: Joe Medley <jmedley@google.com>
* Update guideforms.py
Co-authored-by: Joe Medley <jmedley@google.com>
* Update guideforms.py
Co-authored-by: Joe Medley <jmedley@google.com>
* Update guideforms.py
Co-authored-by: Joe Medley <jmedley@google.com>
* Add space after sentence.
* Added Shipped and fixed errors
Co-authored-by: Jason Robbins <jrobbins@chromium.org>
Co-authored-by: Joe Medley <jmedley@google.com>
* Show unlisted features to users who can edit.
* remove logging
* Add indication to unlisted features that are shown
* Update static/elements/chromedash-feature.js
Co-authored-by: Joe Medley <jmedley@google.com>
* Update templates/feature.html
Co-authored-by: Joe Medley <jmedley@google.com>
* Update templates/guide/metadata.html
Co-authored-by: Joe Medley <jmedley@google.com>
* Update tests/models_test.py
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Jason Robbins <jrobbins@chromium.org>
Co-authored-by: Joe Medley <jmedley@google.com>
* Implemented process choice
* added tests
* Reworded as feature type
* Renamed feature.process to feature.feature_type
Co-authored-by: Jason Robbins <jrobbins@chromium.org>
* Use lit-virtualizer with UI state in the items rather than mutating.
* recalc when the user filters
* Map to Set and fix opening of ID in URL.
* Allow package-lock under version control.
* Allow package-lock under version control.
This fixes the chromedash-metadata template to include the deprecated
features entry in the versions list. This also fixes a problem that was
uncovered where an ordered list that was in the incorrect order which
resulted in the wrong implementation status being shown in the versions
list.
This adds support for exceptions to the general form
visibility/requirements per category, and adds exceptions for tag review
and wpt form fields for features in the JavaScript category. This also
fixes a few form visibility issues when editing old feature entries that
don't have an intent stage set.
This makes it so that editing an old Feature entry (one created before
the notion of intent stage was introduced) is possible again w/o the
need to enter a bunch of launch process specific information.
This expands the length of the free form text fields from 500 to 1480.
There's a hard maximum of 1500 in the database, and it seems the front
end text field limiting code is buggy and doesn't correctly account for
newlines in the form fields, so I cut this a bit short of the hard limit
to help users more often know that they've reached the limit. This
change also loosens the restriction for the intent to implement link as
users don't always have one at this point.
This fixes an issue (#595) where several of the form fields added in #589
were not marked as multiline entries in the database (i.e. the form fields
could only contain a single line of text). This changes that, and also fixes
an issue with the Web Platform Tests checkbox couldn't be left unchecked.
* Start removing Opera.
* Mark Opera removals in feature_form.js
* Remove most actual code.
* Remove last commented code.
* Remove toggleSpecLink() since it is never called.
* Feedback from Eric B.
Add a set of fields to the entry creation/edit form so that we collect
all the information that is part of the blink launch process. This
also makes chromestatus generate up to date intent templates with the
future intent of eliminating the need to manually create and send
intent emails. This includes making feature entries aware of the
current intent stage they're in as well as holding on to all the
additional data so that creating intent messages for later stages of
the launch process is a matter of updating the entry and generating a
new intent message.
* Integrated httparchive data on metrics pages
* Update note
* Add Bigquery cmd
* dont show empty pre
* Increase iframe height to account for urls
* update bq query
* Update callout
* space for http archive
* space
* Added a note about included WebView metrics
* Added a note for the metrics spike around 2018-3-20
* Added a note for the metrics spike around 2018-3-20
* Added a note for the metrics spike around 2018-3-20