* Initial install of playwright visual tests
* Close to working.
* who knows...
* after updates
* Extend devcontainer docker compose file for playwright (#3192)
* Extend devcontainer docker compose file for playwright
Create another docker compose file for playwright.
That new one extends the existing docker compose
Should be able to run:
`npm run pwtests`
* adjust gh action
* adjust gh action
* remove volumes
* add timeout
* fix volumes
* Fix docker compose environment
* ignore stuff and volume mounting
* Attempting to login reliably
* Auto cleanups.
* Finally starting to work
* Thought it was getting better, but maybe not
* Seems reliable now
* Higher success rate
* Add test of entering feature name. Remove new feature page content test.
* Add playwright-report dir to Dockerfile.
* Comment out mkdir -p /work/playwright-report line.
* Update screenshots.
* Increasing timeout for entering feature name
* try running as user (#3248)
* try running as user
* again
* try
* change volume ownership
* tidy up
* Adjust login process to be more reliable.
* Add 5 second delay before first test runs.
* Wait longer for first login.
* Add auto-logout during login if already logged in
* Screenshot after login click
* Add testName to screenshots. Upload artifacts. Fix form method="POST".
* Add doc to README for Updating the test_html_rendering files.
* Maybe increase chance of login.
* Add a couple more delays.
* Repeat auto-logout during login until no longer logged in, before logging in again.
* Add some more delays.
* Use loginButton.click(). Add delay before after-click screenshot.
* Add console info an errors to login process.
* Capture console messages, relay to terminal.
* Capture console messages properly.
* Add some more console messages during login.
* Ignore error on jsonValue.
* Reduce most delays. Add more logs. Add top-level playwright call.
* More logging to figure out why login fails
* More logging to detect if ever logged in.
* Add more logging to each stage of testing
* Use history.replaceState before changing location.
* Use location.reload() after a timeout.
* After login, just load home page.
* Add playwright-report to artifacts.
* Turn off playwright-report during CI
* Log response after login
* Only log first response after request that should log in.
* Look for 'currentuser/permissions' request/response.
* Delay after mock_login and before reload of home page
* Comment out header and cookie logs.
* Act like logged when in DEV_MODE and login attempted.
* Fix mock mock login.
* Undo fake mock_login.
* rearrange docker (#3265)
* Updates after changes by James.
* Fix previous updates.
* Remove pwtests-shutdown from "stop" command.
* Remove pwtest from client-src/elements. (moved to packages/playwright/tests)
* update paths for run.sh
* Add pwtests-shutdown to top-level stop command.
* Remove "playwright" from ./wait-for-app.sh
* Add logging of user login status.
* add playwright_display for debugging
* add server debugging
* Remove extra "/__screenshots__" in path.
* Update the path for test-results artifacts in the playwright.yml
* add health checks
* fix action
* fix run.sh
* Add beforeAll method, disabled.
* add dsadmin
* Add top level pwtests command, not working yet.
* cleanup and undo changes
* use transactions
* always reuse server
* temp: limit the workers
* Partial cleanup. Reduce timeouts and delays a bit.
* More cleanup. Reduce timeout/delay.
* Update the correct README file. Update html rendering tests.
* Remove unnecessary changes.
* set script-shell to fix source not found and call npm run setup (#3292)
* set script-shell to fix source not found and call npm run setup
There has always been `source: not found` in the previous CI jobs
The tests previously worked because
npm run deps installs the requirements into the default environment and not the virtual environment.
And since we actually did not call `source` correctly, it was okay because
the default environment had the packages installed.
The problem started to arise because we started to call `source`
correctly in some places but not all places. This fixes by setting the
shell consistently whenever we call `source`
More info:
https://morgan.cugerone.com/blog/troubleshooting-source-not-found-when-in-the-context-of-package-json-scripts/
* do each separately
* Revert "do each separately"
This reverts commit 4fc75f7407.
* do ci job
* consistent to the right datastore mode
* verbose
* kill the emulator
* remove verbose
* Reenable Google login
* Finish reenabling Google signin button. Add margin for Firefox.
* Only show Google signin if playwright is not active
* Preserve url on login. Use default num of workers. Retry tests in CI
* Some updates after comments
* optimize docker changes
* Rename account-indicator. Shorten some delays.
* revert the workers
* Make playwright.yml push and pull_request triggers be like others.
* Use getByTestId instead of locator with data-testid.
---------
Co-authored-by: James C Scott III <jcscottiii@users.noreply.github.com>
Co-authored-by: James Scott <jamescscott@google.com>
* Remove all references to django
Replace any functionality with flask
* more cleanup
* fix template test after removing empty comment
* remove unused test_app
* Progress
* Send and receive emails in py3 using GAE legacy libraries.
* No need to run py2 unit tests when there are none
* Addressed review comments.
* Avoid needing to run py2 on workstations.
* Use gunicorn instead of dev_appserver
* Add comment to explain that dev-default.yaml is not currently used.
* Use venv pip to install py3 deps.
* Auto-activate and stop referencing lib/.
* Make gunicorn use libs in cs-env.
* Migrated models.py
* Migrated bulkloader_helpers.py
* Migrated accounts_api.py
* Migrated models.py
* Migrated ramcache.py
* Migrated secrets.py
* Migrated basehandlers.py
* Migrated metricsdata.py
* Migrated fetchmetrics.py
* Migrated notifiers
* blink_handler
* guide.py
* users.py
* fix_data.py
* appengine.py
* Migrated all order() function calls
* Fixed filterby[]
* Migrated all filter() queries
* Migrated some left out lines
* Fixed Bug: json_dump would result in TypeError
* Fixed bug - key() is not callable
* Bug Fix: Query Filters were not working
* Fixed Bug: JSON output of feature list would not contain feature id
* Removed unused ndb import
* Fixed Bug: old_val would have properties wrappped in _BaseValue
* Migrated Tests
* Fixed Test: capstone has no attribute delete()
* Fixed Bug: A filter won't work
* Fixed Bug: Index out of range if self.Blink_components length is 0
* Fixed Bug: Some order statements won't work
* Assigning default value to Feature_blink_components
* Fixed Bug: A filter won't work
* Fetching singleton using ancestor for strong consistency
* Moved the ancestor query for strong consistency to replace the correct original query
* Replaced _pre_put_hook with _from_pb
* Fix: NDB picked up old properties while looping over self.properties
* Fix: NDB would generate diffs if None is compared with empty strings
* Added Google Platform Library
* Added Meta Element for Client ID
* Added Google Sign-In Button
* Authenticating the id_token on our backend
* Saving id_token in flask session, using the id_token to fetch the current user and replaced the usages of AppEngine Users API (not from *_tests.py)
* Correct the flow on pressing SignIn and SignOut
* Code refactor
* Added Comment for is_current_user_admin
* Supporting GAE Users library for post request
* Made some fixes
* Changed Admin User condition
* Reloading only on 200 response code
* Do not require sign in and xsrf token while sending post request for login
* Sign Out using Google Sign In if cookie is not set after login
* Clearing the session if the id_token stored in the session variable becomes invalid or expires
* Replaced GAE Users from tests
* Replaced GAE users with framework users in tests.py
* Upgrade from GAE taskqueue to Google Cloud Tasks.
* added unit tests
* Add link to Monorail file that I referenced.
* Add grpcio to travis build
* Try installing grpcio locally first
* Try installing grpcio via sudo
* Try a smaller set of deps for travis.
* Debug travis config
* Avoided missing imports while running unit tests on travis
* Removed travis debugging lines
- Intercepts calls to Feature.put() and diffs changes in properties for updates
- Creates async task queue and email notifies feature owners
- Switch to pip and custom django install instead of GAE version
Daniel LaLiberte
Kyle Ju
James C Scott III
Jason Robbins
Shivam Agarwal
Eric Bidelman
Francois Beaufort