caeaeecb1e
CSS ISSUE : larger Property names not breaking up and sliding into Percentage column. #1655 fix ( #1658 )
...
Large property names should wrap to 2nd line.
The word-break property specifies how words should break when reaching the end of a line.
added { word-break: break-all; } to all <a> inside <li>
2022-01-05 14:11:25 -08:00
2c4162f388
Update call to create_task() to match updated GCT. ( #1654 )
...
* Update call to create_task() to match updated GCT.
* Make fake create_task()s match the real one
2022-01-05 08:30:08 -08:00
8b6e1c59e3
Add indexes for queries done when closing a review. ( #1660 )
2022-01-05 08:26:33 -08:00
2c4d1e536b
Clean up requirements.txt ( #1651 )
...
* Rearrange dependencies
* Revert the google-cloud-tasks in #1141
* Keep the google-auth pin for google-cloud-ndb in #1365
* Revert the pin in #1335 for outdated py2 support
* Remove the pin for requests in #1205
2021-12-21 11:33:03 -08:00
a3ae276538
Refresh Google Sign-In session. ( #1649 )
2021-12-15 08:15:43 -08:00
9037c4202e
Show review activity in list ( #1638 )
...
* Manual merge
* Display some approval details in the list view.
* revert index.yaml
2021-12-09 11:42:10 -08:00
7bfedd37f7
Fix incorrect caching logic that caused transient duplicates on myfeatures. ( #1648 )
...
* Fix incorrect caching logic that caused transient duplicates on myfeatures.
* Added a specific regression test.
2021-12-09 11:38:32 -08:00
9a20012660
Add navigational context for feature detail page back arrow. ( #1640 )
2021-12-08 07:57:37 -08:00
b222a12933
Hide non-working UI elements. ( #1639 )
2021-12-08 07:03:36 -08:00
03bcef81f1
Implement a UI for editing approval configs ( #1633 )
...
* Starting point
* laid out config display
* Fetching config data
* Implemented save and revised API param requirements
* Always send lists of possible owners.
* Revert unintented index.yaml changes
* address review feedback
* Clarified conditional defaults
2021-12-07 16:13:42 -08:00
d862026aa7
Treat N/A as approved. ( #1634 )
2021-12-07 15:07:29 -08:00
d224f557c7
Redirect from www.DOMAIN to bare domain. ( #1635 )
...
* Redirect from www.DOMAIN to bare domain.
* Test that query string is preserved
2021-12-07 14:03:25 -08:00
513e5cdd22
[wip] Fix for CI ( #1631 )
2021-12-03 11:06:09 -08:00
7bd459c884
Treatempty uma-export result as not ready. ( #1630 )
2021-12-02 14:45:10 -08:00
6d86f9e31b
Implement a new approval config datastore entity type and API ( #1625 )
...
* progress
* Added tests and csClient call.
* Added date format ValueError exception handler
2021-12-01 13:40:00 -08:00
9355547ef0
Add Blink>WebML to hardcoded list of blink components. ( #1624 )
2021-11-30 10:43:57 -08:00
fa4755dc34
Small fixes to intent email handling. ( #1623 )
...
* Small fixes to intent email handling.
* Make py2 test more realistic.
2021-11-30 10:43:40 -08:00
a6704e72d7
Revert "Add a field for next_review_date. ( #1617 )" ( #1621 )
...
This reverts commit 946ecfbb2f
2021-11-29 12:32:33 -08:00
8c363ff20d
Layout quick-approval UI elements. ( #1618 )
2021-11-27 07:49:37 -08:00
3c74e91a59
Make chromestatus link detection more robuts. ( #1619 )
2021-11-27 07:43:56 -08:00
946ecfbb2f
Add a field for next_review_date. ( #1617 )
...
* Add a field for next_review_date.
* Add check for next_review_date to unit test
2021-11-24 12:49:28 -08:00
3c382624c0
Detect LGTM emails and record them ( #1616 )
...
* progress
* Finished
* Fixed defect and tests and comments
2021-11-23 17:27:00 -08:00
7ab852cb80
Implement posting review comments to blink-dev mailing list. ( #1611 )
...
* Implement posting review comments to blink-dev mailing list.
* Update internals/notifier.py
Co-authored-by: Kyle Ju <kyleju@google.com>
Co-authored-by: Kyle Ju <kyleju@google.com>
2021-11-22 14:41:00 -08:00
9e8b635f8a
Increase number of items shown in recently closed box. ( #1615 )
2021-11-19 13:37:38 -08:00
ad9e2c2b07
Work around broken library dependency. ( #1614 )
2021-11-19 11:44:23 -08:00
5fec2b7edf
Update chromedash-timeline.js ( #1613 )
2021-11-19 09:59:45 -08:00
47890874fd
Upgrade to instances with more RAM. ( #1607 )
2021-11-12 08:42:02 -08:00
8b4c28a02d
For inbound approval emails, prefer X-Original-From. ( #1606 )
2021-11-12 08:41:44 -08:00
d3c278d091
Add more approvals indexes. ( #1605 )
2021-11-12 08:41:28 -08:00
ae76168ec2
Fix summary ellipsis for collapsed chromedash-feature ( #1603 )
2021-11-11 11:40:18 -08:00
03b814da8b
Implement a "Recently reviewed features" box on the myfeatures page ( #1600 )
...
* Implement a "Recenty reviewed features" box on the myfeatures page.
* removed some logging
2021-11-09 18:00:07 -08:00
237e5dde54
Add stamp icons to feature list and feature detail pages. ( #1601 )
...
* Add stamp icons to feature list and feature detail pages.
* Added preventDefault() to all listeners
2021-11-09 17:19:27 -08:00
2ea3cbed16
Make py2 inbound email handler call py3 via appspot.com. ( #1598 )
2021-11-09 08:23:12 -08:00
60f0beff37
When an intent review is complete, make it no longer pending. ( #1597 )
...
* When an intent review is complete, make it no longer pending.
* Meged with change from NEEDS_REVIEW to REVIEW_REQUESTED
2021-11-09 08:21:06 -08:00
1880804978
Fix defect in read-only display of approval values. ( #1599 )
...
* Fix defect in read-only display of approval values.
* Use REVIEW_REQUESTED rather than NEEDS_REVIEW
2021-11-05 14:24:25 -07:00
f896c59558
20211001 approvals dialog ( #1591 )
...
* progress
* progress
* progress
* progress
* initially show only pending intentds
* progress
* progress
* Save comments
* rename property to "heading"
* Phase out unneeded property.
* Addressed review comments
* Addressed review comments
2021-11-04 09:06:09 -07:00
9b5a6a685e
Outline the implementation of the approvals dialog ( #1596 )
...
* Outline the implementation of the approvals dialog box.
* Fix some JS lint.
2021-11-03 08:39:31 -07:00
bef1cf9aa3
Make fieldId optional in comments API. ( #1593 )
...
* Make fieldId optional in comments API.
* Add index needed for retrieving review comments.
* Add index needed for retrieving review comments.
* Add index needed for retrieving review comments.
* Add index needed for retrieving review comments.
* Add index needed for retrieving review comments.
2021-11-01 15:08:05 -07:00
a98d996f26
Set approval by specifying featureId in URL only. ( #1594 )
2021-11-01 15:07:45 -07:00
b86100e9b2
Add heading property to chromedash-dialog. ( #1595 )
2021-11-01 14:15:42 -07:00
eb9e688b5a
Allow required int parameters to have zero value. ( #1592 )
2021-11-01 13:26:00 -07:00
57abce6aba
Use urlfetch directly in py2 code. ( #1590 )
2021-10-26 17:33:00 -07:00
a2b2f9db98
Make footer fixed on very long pages. ( #1588 )
2021-10-21 15:35:25 -07:00
2d60a480e6
Add some APIs needed for approvals dialog. ( #1585 )
...
* Add some APIs needed for approvals dialog.
* Addressed review comments
* clarified comment
2021-10-19 16:56:37 -07:00
16792ca436
Better intent parsing and add extend experiment link. ( #1586 )
...
* Better intent parsing and add extend experiment link.
* Update templates/blink/intent_to_implement.html
Co-authored-by: Kyle Ju <kyleju@google.com>
Co-authored-by: Kyle Ju <kyleju@google.com>
2021-10-19 16:02:46 -07:00
c57f61680e
Remove Webview DT from the UI. ( #1583 )
2021-10-13 18:28:22 -07:00
e9ae478b7d
Remove edge signals and add other signals. ( #1581 )
...
* Remove edge signals and add other signals.
* Revert unintented file change
2021-10-13 18:28:03 -07:00
6bac49bdc2
Decode response from uma-export. ( #1580 )
2021-10-08 13:09:25 -07:00
4f54030d63
Use toast rather than alert(). ( #1578 )
...
* Use toast rather than alert().
* Update static/elements/chromedash-roadmap.js
Co-authored-by: Kyle Ju <kyleju@google.com>
* Update static/elements/chromedash-roadmap.js
Co-authored-by: Kyle Ju <kyleju@google.com>
Co-authored-by: Kyle Ju <kyleju@google.com>
2021-10-08 11:28:12 -07:00
c321a95423
Fix missing import of settings. ( #1579 )
2021-10-08 11:17:46 -07:00
NIRAJ
Jason Robbins
Kyle Ju
Rick Viscomi
Liam Newmarch