* unique field partitioning
* correct prototype/incubate fields
* remove duplicate metadata form definition
* mark stage-specific fields
* reorganize stage field sections
* Change datatypes for field organization (WIP)
* display fields using new structure
* update editall to use stage ID
* Fix and remove irrelevant test
* remove unused process stage calls
* remove incorrect comment
* fix test
* Additional comments
* small wording change
* display and edit stages based on stage ID
* fix test
* defensive coding with intent stages
* new routes
* save active_stage_id in guide.py
This change is set to land in a separate PR.
* display active stage on detail page correctly
* remove "SHIPPED" stage types
* fix processes and tests
* add shipped form field to shipping form field
* Show matching process stages on process overview
* fix tests
* remove active_stage_id reference
* remove active_stage_id from test
* typo
* update url
* fix web test
* Consolidate "prepare to ship" and "ship"
* add small comment
* remove duplicated function
* clear up logic for writing to stages
* backwards-compatible urls and api
* Update tests
* Add rollout stage to the edit_all page
- Show the rollout stage in the edit all page for all non-enterprise feature types
- Use STAGE_ENT_ROLLOUT as the id for the piggybacking on the Shipping stage.
* Ensure rollout stage is shown on edit all page
Co-authored-by: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
* Use copy of forms on edit all page
Co-authored-by: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
* Exclude enterprise features from search results by default.
* Update internals/search.py
Co-authored-by: Kyle Ju <kyleju@google.com>
Co-authored-by: Kyle Ju <kyleju@google.com>
* Write and delete data for dev environments
* Add 2nd feature entry
* write old Feature entities as well
* More thorough commenting
* Make sure endpoints can only be used locally
* update return statements
* devtrial_instructions is a link
* changes suggested by @jrobbins
* comment change
* Intial code for display of amendments
* tests
* More tests, and avoid showing non-useful amendments
* More tests
* Put Loading... in a paragraph tag.
* Indent amendment details
* basic refactoring
* Use Vote and Gate entities for reading and writing
* update tests
* remove old Approval to JSON function
* type hints
* Add gate_type to Vote entity
* review changes
- Remove stage and gate info from format_for_template()
- Add new Vote index
- Change approvals_api.do_post() to take gate type rather than gate id.
* type hints
* Revert "type hints"
This reverts commit 9ffab5aabd.
* Move feature functions to separate helpers file
* remove import
* more import removal
* end of file newline
* mypy ignore ndb
* @jrobbins review changes
- Removed older standardization field logic
- Added TODO for migration script for values in migrate_views()
* staging fixes 2022-10-19
- Fixed approval_defs.set_vote() to write gate_id properly to Vote entity (previously was erroneously writing gate_type to gate_id).
- Created Gate entities in tests to allow Vote entities to be properly written.
- Incremented stage counts in schema_migration script properly reflect the amount of stages created.
- Removed Vote double-write call in Approval.set_approval() (this is no longer needed).
* Update approval_defs.py
* Add assertions for the templates in #2355
- Move the TESTDATA functionality to a testing_config to be a test helper.
In this new helper, users can still retreive from it like a dictionary.
In addition, there's a helper function to help make goldens that can be
used to regenerate the golden templates. Add commented out
code to use it.
- Add some clean ups to individual tests or test cases. This was needed
because some of the existing rendering tests would pull from the database.
But since they only asserted for the existence of some values, it did
not matter. In the future, we can add mocks for all of those.
- These cleanups also help for more than the rendering tests. Before these fixes, there were ~15 non-rendering tests that would fail if a developer ran the full suite with a clean db, then re-ran a test indivdually without resetting the database. There are still 2 non-rendering tests that fail without clearing the database first. But this first iteartion got a lot of them.
- Add a missing test for the PrepublicationHandler to increase coverage
* address comments
* more cleanup
Daniel Smith
Jason Robbins
Yann Dago
Kyle Ju
James C Scott III