Граф коммитов

944 Коммитов

Автор SHA1 Сообщение Дата
Jason Robbins cc4602d421
On the /upcoming page, always group features by launch type. (#1537) 2021-09-16 15:54:00 -07:00
Jason Robbins 8ae923858d
Add files via upload 2021-09-02 13:21:12 -07:00
Jason Robbins e42b202362
Fix the display of some feature details. (#1510)
* Fix the display of some feature details.

* remove debug logging
2021-09-02 09:29:03 -07:00
Jason Robbins 6e5806da06
Add OT gap to milestone visualization. (#1509) 2021-09-02 09:28:46 -07:00
Jason Robbins f5c6542411
Show dates on schedule "gap" column. (#1505)
* Show dates on schedule "gap" column.

* Fetch data in a try.
2021-09-01 13:19:46 -07:00
Jason Robbins 25425a6822
Add files via upload 2021-08-31 12:48:16 -07:00
Jason Robbins 180b65d66f
Outline code for /myfeatures page. (#1481)
* Outline code for /myfeatures page.

* Update templates/myfeatures.html

Co-authored-by: Kyle Ju <kyleju@google.com>

Co-authored-by: Kyle Ju <kyleju@google.com>
2021-08-27 18:19:00 -07:00
Jason Robbins 87ec6dc4a9
Fill in milestone when there is a gap between stable, beta, or dev. (#1499) 2021-08-27 10:17:44 -07:00
Jason Robbins 0f52572676
Hide milestone visualization when no active develoment. (#1492) 2021-08-25 17:22:54 -07:00
Jason Robbins 3f5c81ce22
Implement milestone visualization (#1469)
* Got visual layout working

* more experimentation

* Offsets and stable channel indicator

* Refined hover text

* addressed review comments

* addressed review comments
2021-08-17 14:24:47 -07:00
Shivam Agarwal 866dc3c43f
Added support for scrolling to previous releases (#1468)
* Added support for scrolling back to Chrome release 1

* optimised the scrolling process

* Using variable instead of hard-coded values for easy value change in future
2021-08-14 12:08:30 -07:00
Shivam Agarwal 6f5cd247ee
Added support for highlighting on hovering over a feature (#1462)
* Added support for getting schedule of specified range of channels API

* Loading the next three milestones in advance after loading the first three milestones

* Channels API will send information of only three standard channels

* Added support for binding the properties to the new milestone cards

* Changed variable name to make code more readable

* Made the code DRY w.r.t mapFeaturestoShippingType

* Fetching in advance on second last element

* Added variables instead of static values

* Previous Button will not scroll to versions before stable

* Undo Changes in index.yaml

* Deleted commented lines

* Fixed a comment

* Ask user to reload the page if some error occurs

* Added Support for highlight on hover over a feature

* Removed unnecessary spaces
2021-08-13 12:32:45 -07:00
Shivam Agarwal 51dd30cbbf
Map feature to Shipping Milestone on backend instead of frontend (#1464)
* Map feature to shipping type at the backend

* Frontend no longer maps features to shipping type

* Fixed tests in models_test.py

* Fixed tests in features_api_test.py
2021-08-13 12:26:22 -07:00
Shivam Agarwal dacabd180e
Infinite scroll on upcoming page (#1458)
* Added support for getting schedule of specified range of channels API

* Loading the next three milestones in advance after loading the first three milestones

* Channels API will send information of only three standard channels

* Added support for binding the properties to the new milestone cards

* Changed variable name to make code more readable

* Made the code DRY w.r.t mapFeaturestoShippingType

* Fetching in advance on second last element

* Added variables instead of static values

* Previous Button will not scroll to versions before stable

* Undo Changes in index.yaml

* Deleted commented lines

* Fixed a comment

* Ask user to reload the page if some error occurs

* Added comments and a constant

* Changed a function name

* Changed variable names

* Removed unnecessary blank lines

* Changed an old variable name

* Changed Implementation of sortFeaturesByName

* Removed two & from query string

* Added space around operators

* Changed implementation of sort function
2021-08-13 08:48:28 -07:00
Jason Robbins 1403aa117d
Display the standards maturity value, or backfill based on standardization (#1450) 2021-08-09 11:36:32 -07:00
Jason Robbins 8ecbe89ed6
Start strictly enforcing CSP (#1452)
* Start strictly enforcing CSP

* Remove unused actionPath and onsubmit
2021-08-09 11:36:13 -07:00
Shivam Agarwal 20acf9e65a
Responsive Scroll for narrow viewports (#1455)
* Made Position of arrows responsive

* Some CSS Improvements

* Display Only Single Milestone on narrow view ports

* Compute the number of items to be displayed according to the size of display
2021-08-09 09:13:38 -07:00
Shivam Agarwal 2f87b35ed4
Scroll Behaviour on upcoming page (#1451)
* Fetching schedule of Dev plus one version

* Added four cards

* Added Slideable cards

* Added timeline controls

* Responsive Design

* Improved implementation

* Timeline Controls should not be displayed in narrow viewports

* Added GreyScale logo for milestones later than dev

* Changed the location of the timeline control buttons to above the container
2021-08-05 17:08:59 -07:00
Shivam Agarwal e14fadd5a1
Using Webcomponent for each milestone card (#1432)
* Using Webcomponent for each milestone card

* Fixed Bug: Signed User would be asked to sign in when trying to star a feature

* CSS Improvements

* Removed unnecessary function call

* Added Annotations for Shipping Type

* BugFix: Even if some error occurred on the server, the UI would update to show the feature as starred

* Factored the Event Creation and event call to a method

* Internationalization Modifications

* Added Some comments

* Binding properties to variables without passing them in the attribute

* Lint Fix

* Made render method modular

* Removed Single Quotes Around values

* Renamed ShowBlink variable to ShowShippingType

* Updated Download links on upcoming page
2021-08-03 08:00:54 -07:00
Shivam Agarwal 8376c114f7
Bug Fix (#1446) 2021-08-02 15:32:24 -07:00
Jason Robbins ab8b2c1421
Add fields for DevTrial milestones. (#1425)
* Add fields for DevTrial milestones.

* Changed wording and added android OT milestones

* Added JS to copy desktop milestones to other platforms.
2021-07-26 12:17:00 -07:00
Shivam Agarwal 371a30f941
Bug Fix: Star would toggle in UI but not at the backend (#1436)
* Fixed Bug on All Features Page

* Fixed Star bug in the old features page
2021-07-26 12:12:05 -07:00
Jason Robbins 4b2f65da00
Access samples at the version=2 pathname. (#1433) 2021-07-23 08:03:20 -07:00
Jason Robbins 450c997d69
Add standard_maturity field. (#1428) 2021-07-21 15:37:45 -07:00
Shivam Agarwal 849a8536fa
New upcoming page (#1426)
* Created Upcoming page by duplicating code from schedule page

* The new upcoming page now uses Features and Channels API to fetch data

* Fetching features of each milestone separately

* Using csClient for fetching information

* Removed unreferenced variable set from upcoming-page.js
2021-07-20 13:59:55 -07:00
Shivam Agarwal 9f5ba41419
20210628 UI enhancements (#1376)
* Fixed Right Margin Around the Feature Cards in Mobile View

* Fixed Add Feature Button on Mobile UI

* Fixed NavBar on narrow viewports

* Added a custom Google Sign In Button

* Redesigned the Google Sign In Button

* Google Sign In Image
2021-07-19 13:00:13 -07:00
Jason Robbins 60d30c4087
Refine our use of CSP. (#1347) 2021-06-02 15:08:20 -07:00
Shivam Agarwal 1ceac8077d
Made Drawer Column responsive (#1346)
* Made Drawer Column responsive

* Changes made to JS Navigation Menu for a uniform UI similar to CSS Navigation Menu
2021-06-02 10:55:08 -07:00
Jason Robbins 1a51eccdd1
Simplify the on-page JS for signIn and signOut (#1332)
* progress

* Added catch() for case where sign-in fails.
2021-05-27 09:20:42 -07:00
Shivam Agarwal 97488ce9f3
Added the dropdown in narrow viewports (#1334) 2021-05-25 14:49:02 -07:00
Jason Robbins f8548b0d2f
Implement Comment API and storage. (#1333) 2021-05-24 13:50:40 -07:00
Shivam Agarwal 8e4fb24126
Replaced Left Hand Navigation with a dropdown menu (#1325)
* Added DropDown Menu for Chrome Version

* Added all the Chromium Statuses that were not directly accessible

* Reverted index.yaml

* 'Canary' 'Dev' 'Beta' 'Stable' will be displayed next to version number depending on the class name

* Clicking on 'X' in Filter Input Box will select the 'Select Chrome Version' option in Chrome Versions List

* Changed Label to Filter By
2021-05-21 11:07:47 -07:00
Jason Robbins a79b26f595
Convert old UI-style user admin requests to JSON API. (#1326) 2021-05-19 15:21:18 -07:00
Jason Robbins cbebbdc522
Consolidate some ajax calls into cs-client.js. (#1322)
* Consolidate some ajax calls into cs-client.js.

* Remove references to deleted JS files.
2021-05-19 09:24:33 -07:00
Jason Robbins 8fd2d43ed4
Fix signed-out star icons on the schedule page. (#1324) 2021-05-18 15:53:22 -07:00
Jason Robbins bc618aac74
Prompt the user to sign in for starring. (#1317) 2021-05-11 11:28:58 -07:00
Jason Robbins 12ae9e0166
Re-enabled experiment timeline if it is not empty. (#1307) 2021-05-06 08:55:39 -07:00
Jason Robbins ca1d31b0ea
Implement site banner. Set banner for Google Sign-In. (#1304)
* Implement site banner.  Set banner for Google Sign-In.

* Addressed review comments
2021-05-04 11:33:29 -07:00
Jason Robbins 9d15e46a97
Refresh XSRF token in form submission. (#1296)
* Refresh XSRF token in form submission.

* Dont pass xsrf_token because we use csClient.token.
2021-05-03 11:47:05 -07:00
Jason Robbins fd4875a95f
Stop hitting prod when testing locally. (#1292) 2021-04-28 15:17:39 -07:00
Jason Robbins 1594fcd80c
Implement JS client class for our API. (#1289) 2021-04-28 11:18:26 -07:00
Jason Robbins f4726b7455
Allow site admins to be specified via AppUser entities. (#1288) 2021-04-27 18:56:37 -07:00
Jason Robbins 558458174e
Replace non-standard event.path with e.composedPath(). (#1284) 2021-04-21 13:17:04 -07:00
Nikhil Saini e5a3ffd900
Fixes-chromedash-feature-collapse (#1232) 2021-04-21 12:53:46 -07:00
Jason Robbins dabcfb780f
Implement XSRF tokens for HTML forms (not enforced yet). (#1266)
* Implement XSRF tokens (but not enforced yet).

* Also add tokens to user list page.
2021-04-15 09:48:06 -07:00
Shivam Agarwal 3c415e1a8e
Fixed Bug: "additional fields by process phase" widget is not keyboard-accessible (#1244)
* Fixed Bug: Not Keyboard Accessible

* Removed the unnecessary aria-expanded attribute

Co-authored-by: Jason Robbins <jrobbins@gmail.com>
2021-03-30 16:00:41 -07:00
Jason Robbins 288467837d
Delete code for the legacy feature editing UI. (#1231) 2021-03-23 09:28:46 -07:00
Nikhil Saini 02396707f5
Fix sorting of percentage values (#1224)
* Make it so Adam A is notified of CSS Changes

* Fix incorrect percentage sorting

* Corrected typo

* Removed change unrelated to this PR

* Removed unused variable

Co-authored-by: Joe Medley <jmedley@google.com>
2021-03-20 13:47:18 -07:00
Shivam Agarwal e4d5be9df7
20210319 fix timeline narrrow ports (#1220)
* Added a navigation row on narrow view ports for all properties menu

* Added changes
2021-03-19 14:52:18 -07:00
Jason Robbins 8e5804412f Actually remove cues.py. 2021-03-19 16:09:40 -04:00
Jason Robbins 0489cb959c
Remove some code left over from push notifications. (#1223) 2021-03-19 11:19:57 -07:00
Jason Robbins 53c130c4f1
Hide components by default on the schedule page. (#1218)
* Hide components by default on the schedule page.

* update comments
2021-03-18 16:06:28 -07:00
RITARSHI CHATTARAJ 1795e60cf6
Tried fixing error #431 (#1206)
* added feature.keyword to temporary string regExp at #L201 function

* Changed feature.keyword to feature.tags at #L201 and wrapped text at 80 columns
2021-03-18 10:41:51 -07:00
Jason Robbins 6bba409a33 Start offering a simple REST API. 2021-03-03 16:46:54 -05:00
Jason Robbins b40145e60a Remove a few more references to unused service worker. 2021-02-25 16:14:18 -05:00
Jason Robbins 3d4861194a Fix an off-by-one error in feature list left-nav. 2021-01-28 18:29:20 -05:00
Jason Robbins d7573f7639 Remove prod mode from elements 2021-01-20 19:42:01 -05:00
Jason Robbins 8bf2c808a6
Start flask upgrading from webapp2 to flask (#1115)
* progress

* more progress

* Start upgrade from webapp2 to flask.
2020-12-16 08:38:33 -08:00
Jason Robbins 3fb9c01865 Avoid underlining whitespace when hovering over icon links 2020-12-01 13:07:16 -05:00
Jason Robbins 748d92c3f2
Add a sentence clarifying meaning of recently-added UseCounters (#1095)
* Add sentence clarifying meaning of recently-added UseCounters

* Also add it to the timeline page.
2020-11-20 09:36:01 -08:00
Jason Robbins 516227bf40
pushState when clicking on sidenav links (#1098)
* pushState when clicking on sidenav links

* fix logic error
2020-11-19 19:43:17 -08:00
Jason Robbins 2851b93c12 fix coding error 2020-11-19 15:46:06 -05:00
Jason Robbins 25eaa0668b Move no-active-dev features to bottom of the list. 2020-11-19 15:23:02 -05:00
Jason Robbins 18ef6acffc Remove custom tooltips because brosers provide tooltips. 2020-11-10 16:35:36 -05:00
Jason Robbins 53f895ba5e Addressed review comments 2020-11-09 16:17:14 -05:00
Jason Robbins 67b087756b Align field lists with existing page fields, and highlight active stage. 2020-11-06 15:19:44 -05:00
Jason Robbins 87d0364022 Add feature details to an accordion section on feature details page. 2020-11-06 14:14:44 -05:00
Jason Robbins 62dad4f16a
Implement chromedash-feature-detail component (#1085)
* Partial progress

* more progress

* Basically done

* prepared demo for chromedash-feature-detail

* Added new field api_spec

* add more tests

* Revert most of templates/feature.html for this CL

* fixed typos
2020-11-03 11:09:49 -08:00
Jason Robbins eec12912a1 Fix problems problems now that we use pre-wrap. 2020-10-05 17:59:01 -04:00
Jason Robbins cfe5548b27 Use pre-wrap instead of pre-line. 2020-10-01 20:18:28 -04:00
Jason Robbins 8eb2f268d3 Use white-space: pre-line for text fields that might have paragraphs. 2020-09-30 20:07:51 -04:00
Jason Robbins d8af86d803
Use new Google Analytics account. (#1047) 2020-09-30 09:42:27 -07:00
Jason Robbins e802e4f7e4
Add search tags to feature list entries and feature detail page. (#1046)
* Add search tags to feature list entries and feature detail page.

* Do conditional commas with CSS rather than JS or template logic.
2020-09-29 13:20:16 -07:00
Joe Medley 04c40cac77
Merge pull request #1041 from GoogleChrome/20200925-milestone-query-should-no-match-unrelased-features
Make milestone query not match unrelased features.
2020-09-29 09:12:30 -07:00
Jason Robbins 36e0fa4e9b
Refactor sass into lit-css: metadata. (#1044) 2020-09-28 14:45:55 -07:00
Jason Robbins 8fbb91b570
Refactor sass into lit-css: sample-panel, metrics, x-meter. (#1043)
* Refactor sass into lit-css: sample-panel, metrics, x-meter.

* Addressed review comment and fixed scrolling
2020-09-27 22:52:41 -07:00
Jason Robbins caa9b0633a Make milestone query not match unrelased features. 2020-09-25 16:33:53 -04:00
Joe Medley 551f2fa44c
Merge pull request #1012 from GoogleChrome/20200911-hide-milestones-when-in-development
Hide milestones in feature list entries for prelaunch features.
2020-09-25 13:22:02 -07:00
Jason Robbins 7c9306765a
Update chromedash-feature.js
Updated to match change in models.py.
2020-09-25 12:21:57 -07:00
Jason Robbins c17805fed1
Split timeline into numeric fields and separate impl fields (#1011)
* Partial progress for demo

* Added a separate card and POST handlers.

* Remove instructions about leaving because Guide UX prompts for webview milestone only when appropriate

* remove unused constant

* Fixed a spelling error

* Fixed copy-paste error for one field.
2020-09-24 16:38:59 -07:00
Jason Robbins 1e07806f5e
Fix urlize() usage for feature comments by defining autolink(). (#1039) 2020-09-24 14:56:06 -07:00
Jason Robbins ecf7e8f272
Refactor sass into lit-css: userlist, timeline, color-status. (#1033)
* Refactor sass into lit-css: userlist, timeline, color-status.

* Fixed CSS comment syntax
2020-09-23 09:39:04 -07:00
Joe Medley 58592b1168
Merge pull request #1026 from GoogleChrome/20200921-variable-fonts-in-textarea
Use proportional font "system-ui" in textarea elements.
2020-09-22 13:36:56 -07:00
Jason Robbins b6fabb30c2
Refactor sass into lit-css: ledgend and toast. (#1027)
* Refactor sass into lit-css: ledgend and toast.

* Delete unused file
2020-09-22 11:04:05 -07:00
Jason Robbins 34562a9106 Use proportional font "system-ui" in textarea elements. 2020-09-21 17:08:13 -04:00
Jason Robbins cb49974310
Refactor CSS into theme.css and lit-css. First steps. (#1025) 2020-09-21 13:40:11 -07:00
Jason Robbins d510d62016
Simpify app UX layout to be more document-like. (#1023)
* Simpify app UX layout to be more document-like.

* Eliminate default scrolling to IN_DEVELOPMENT

* Incorporated review comments
2020-09-18 11:05:22 -07:00
Jason Robbins 62f37e8704
Remove gradients and improve text contrast. (#1021)
* Remove gradiants and improve text contrast.

* Addressed review comments

* Addressed review comments

* Addressed review comments
2020-09-17 09:53:42 -07:00
Jason Robbins 07cf9cdb15
Add expand/collapse icon and remove feature overall risk color. (#1020) 2020-09-16 13:42:35 -07:00
Jason Robbins 3c757d8c58 fix syntax and add more details 2020-09-14 21:16:12 -04:00
Jason Robbins 1374ff6990 Allow generation of any intent email at any time. 2020-09-14 15:35:33 -04:00
Jason Robbins 371197e89e Add TODO 2020-09-14 13:52:31 -04:00
Jason Robbins 77e73b0969 Hide milestones in feature list entries for prelaunch features. 2020-09-11 18:57:45 -04:00
Joseph Medley 29991e3877 Make 'Motivation' into a heading. 2020-09-03 13:57:05 -07:00
Jason Robbins 00631812d1 Fix the guide cancel buttons 2020-09-01 19:52:28 -04:00
Jason Robbins d5709c8c68 Make guide UX the default. 2020-09-01 18:57:19 -04:00
Jason Robbins dd7901f603
Implement edit-all page (#991)
* Implement edit-all page.

* Make all form guide editing fields optional.
2020-09-01 13:41:01 -07:00
Jason Robbins 64c84411a0 Add simple "back"navigation out of guide pages. 2020-08-26 19:29:52 -04:00
Joe Medley 99eeaeab3d
Merge pull request #973 from GoogleChrome/summary
Add a label to the motivation text.
2020-08-26 07:46:59 -07:00
Jason Robbins bcaf4141b6
Callout elements for on-page help (#977)
* Starting implementation of callouts

* Implemented dismissed cues.

* Addressed review comments

* resolve a lint-fix error

* resolve a lint-fix error

* resolve a lint-fix error

Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-08-25 14:48:31 -07:00
Joseph Medley 546b86c579 Add a label to the motivation text. 2020-08-20 13:38:56 -07:00
Jason Robbins a60955e1f0
Remove footprint field from the UI. (#970)
Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-08-19 16:45:46 -07:00
Jason Robbins cf8d988871 Replace nested table with flexbox to make it work desktop and mobile. 2020-08-10 18:04:15 -04:00
Jason Robbins 0e4ed5e48c Add style file 2020-08-07 18:27:09 -04:00
Jason Robbins 420b08357c Make doc_links optional in all stages in old UX. 2020-08-06 15:30:46 -04:00
Jason Robbins 09bed45088
Implement progress detectors for Intent emails. (#951)
Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-08-05 16:45:07 -07:00
Jason Robbins 413c8dc3c5
Add Shipped stage. (#941)
Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-08-03 11:17:44 -07:00
Jason Robbins 53a92edd2b
Remove service worker (#936)
* Remove service worker

* Remove remaining CSS related to a2hs button

Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-07-29 14:33:27 -07:00
Jason Robbins 0c436fe1d7
Refactor intent email template (#887)
* Implement separate servlet for intent emails and indent template source

* Redid template conditions

* Update templates/admin/features/launch.html

* Update templates/admin/features/launch.html

* added auth and tests

* Move subject line compution to python and add test

Co-authored-by: Jason Robbins <jrobbins@chromium.org>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: aglaforge <35039800+aglaforge@users.noreply.github.com>
2020-07-24 14:37:55 -07:00
Jason Robbins 0052ad7836 Allow inputs to have defaul outline when focused. 2020-07-21 20:01:22 -04:00
Jason Robbins aacad37c92
Rename permission functions to use inclusive language. (#875)
Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-06-25 16:47:24 -07:00
Jason Robbins a7b9ddc4ca Improve input field placeholder text, e.g., "https://". 2020-06-24 16:42:53 -04:00
Jason Robbins 8eb63b5341 Implemented progress detectors 2020-06-17 01:34:06 -04:00
Jason Robbins 179b60610f
Updated process for deprecation. (#848)
* Updated process for deprecation.

* Added "Remove code" step.

Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-06-16 20:38:59 -07:00
Jason Robbins 65b13ba63a
Add launch bug URL, add try link at top, style tweaks. (#844)
* Add launch bug URL, add try link at top, style tweaks.

* Add feedback link

* New UI link on add feature form

* Added link to launch bug template

Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-06-15 12:46:08 -07:00
Jason Robbins a32ec28239
Define all stage-specific forms and their fields. (#843)
* Define all stage-specific forms and their fields.

* Implement checkboxes to advance stage, and fix alignment.

* Specified actions in process.py and CSS tweaks.

* Update guideforms.py

Co-authored-by: Joe Medley <jmedley@google.com>

* Update guideforms.py

Co-authored-by: Joe Medley <jmedley@google.com>

* Update guideforms.py

Co-authored-by: Joe Medley <jmedley@google.com>

* Update guideforms.py

Co-authored-by: Joe Medley <jmedley@google.com>

* Update guideforms.py

Co-authored-by: Joe Medley <jmedley@google.com>

* Add space after sentence.

* Added Shipped and fixed errors

Co-authored-by: Jason Robbins <jrobbins@chromium.org>
Co-authored-by: Joe Medley <jmedley@google.com>
2020-06-12 10:09:31 -07:00
Jason Robbins 0774b8a336
Show unlisted features to users who could edit them (#840)
* Show unlisted features to users who can edit.

* remove logging

* Add indication to unlisted features that are shown

* Update static/elements/chromedash-feature.js

Co-authored-by: Joe Medley <jmedley@google.com>

* Update templates/feature.html

Co-authored-by: Joe Medley <jmedley@google.com>

* Update templates/guide/metadata.html

Co-authored-by: Joe Medley <jmedley@google.com>

* Update tests/models_test.py

Co-authored-by: Joe Medley <jmedley@google.com>

Co-authored-by: Jason Robbins <jrobbins@chromium.org>
Co-authored-by: Joe Medley <jmedley@google.com>
2020-06-05 14:59:28 -07:00
Jason Robbins f6d1672d36
Implement ability to a choose feature process (#834)
* Implemented process choice

* added tests

* Reworded as feature type

* Renamed feature.process to feature.feature_type

Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-06-04 16:16:48 -07:00
Jason Robbins b9c3aa9560 Update style of buttons throught the app. 2020-06-02 12:59:43 -04:00
Jason Robbins 44039e948b
Show more fields on old editing form for INTENT_EXPERIMENT. (#835)
Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-05-29 10:38:07 -07:00
Jason Robbins d9971634c0 Remove email actions from stage form. 2020-05-26 12:23:42 -04:00
Jason Robbins f2e91e49a7 Implement featue metadata editing 2020-05-21 19:51:41 -04:00
Jason Robbins 1d2bfd008a
Partial implementation of feature editing guide UX. (#825)
* Partial implementation of feature editing guide UX.

* fixed some HTML lint

* Addressed review comments

* added TODO for email generation

* Addressed review comments

Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-05-14 11:37:31 -07:00
Jason Robbins f6d16725fb Prompt users to sign in when they try to star. 2020-04-09 16:28:06 -04:00
Jason Robbins d209f6a5f0 Replace bell icon with stars on schedule page. 2020-04-08 18:26:40 -04:00
Jason Robbins 82a7061f19 Update some JS packages to resolve vulnerability alerts. 2020-04-06 18:34:03 -04:00
Justin Fagnani 7217c4df77
Remove @polymer/lit-element from dependencies (#804)
It's an old package and appeared to be unused. `lit-element` is what's used in components.
2020-04-06 13:43:12 -07:00
Joe Medley f707e53ac4
Add 'On hold' to Chromium statuses. (#798) 2020-04-02 12:16:29 -07:00
Jason Robbins 4dd982c5a0 Handle bad or missing release info. 2020-03-31 20:18:52 -04:00
Jason Robbins 44e0d04638 Switch to new release info URL and show dates again. 2020-03-31 13:19:57 -04:00
Jason Robbins 90dad6631f Disable display of release dates. 2020-03-19 15:02:28 -04:00
Jason Robbins b62d3991b3 Use CamelCase names for CSS property metrics. 2020-03-12 19:58:04 -04:00
Jason Robbins a46d30a469 Addressed review comments 2020-03-12 13:45:45 -04:00
Jason Robbins 8b358e3429 Implement star icons in lit-element code. 2020-03-10 19:59:30 -04:00
Jason Robbins 374150d303
Make doc links shown for all intent stages. (#778)
Co-authored-by: Jason Robbins <jrobbins@chromium.org>
2020-03-09 14:34:15 -07:00
Jason Robbins d521c91c54
Add debounce to search input field. (#735)
* Added debounce to search input field.

* Addressed review comments
2020-01-30 11:50:44 -08:00
Jason Robbins 8428a074a7
Update polymer $ operator to querySelector(). (#724) 2020-01-24 09:37:51 -08:00
Jason Robbins a7ed3dade9
Tweak CSS to avoid wrapping between search input and "?" icon (#730)
* Make search box shorter to avoid help icon wrapping.

* Set min-width to avoid wrapping.
2020-01-23 14:21:47 -08:00
Jason Robbins c0c633494c
Remove lit-virtualizer until it is fully supported (#728)
* Try removing lit-virtualizer to avoid bugs.

* Limit display to 500 features.

* Addressed review comments
2020-01-22 15:44:40 -08:00
Jason Robbins 771f83c28d
Handle clicks on sorting arrow icons. (#726)
* Handle clicks on sorting arrow icons.

* cleaner code
2020-01-17 17:16:46 -08:00
Jason Robbins 64ea4973a2
Refactor chromedash-feature subscribed attribute. (#723)
* Refactor chromedash-feature subscribed attribute.

* Removed unneeded property
2020-01-17 10:14:44 -08:00
Jason Robbins 270eb760b4
Use lit-virtualizer with UI state in the items rather than mutating. (#722)
* Use lit-virtualizer with UI state in the items rather than mutating.

* recalc when the user filters

* Map to Set and fix opening of ID in URL.

* Allow package-lock under version control.

* Allow package-lock under version control.
2020-01-16 12:20:57 -08:00
Jason Robbins 9466f5cb58 merged from master to dev to resolve conflicts. 2020-01-13 18:36:01 -05:00
Jason Robbins 29763b5ac2
Fix several small defects to get the lit-element code all working. (#718) 2020-01-13 10:14:53 -08:00
Yangguang a448e6f9bf Using rollup for components (#679)
* Import lit-virtualizer

* misc

* Add rollup and add it to gulp task

* Update gulp

* Downgrade paper-toggle-button to input checkbox

* Include all css to lit-elements

* Add rollup minify. Remove unused packages.

* Fix code review feedback

* Fixes based on code review.

* Remove two unnecessary .call(this, ...)

* Bind _onFeatureToggled (used inside lit-virtualizer) in the constructor

* Add lit-analyzer

* Update lit-analyzer script
2019-11-11 14:32:32 -08:00
Yangguang Li cf411b9124 Bind _onFeatureToggled (used inside lit-virtualizer) in the constructor 2019-10-08 13:38:12 -10:00
Yangguang Li 36d096fc16 Remove two unnecessary .call(this, ...) 2019-09-27 22:35:26 -07:00
Yangguang Li 14084fbf5a Fixes based on code review. 2019-09-27 22:00:09 -07:00
Yangguang Li c0deb10f0f Merge in latest dev branch. Tweak _initializeValues 2019-09-25 13:52:52 -07:00
Yangguang Li 07505346b6 Use event bubble instead of manually bubbling. Initialize chromedash-feature values on updated. 2019-09-06 11:12:39 -07:00
Yangguang Li 8d2804be6a Bugfix: manually bubble events from chromedash-feature to chromedash-featurelist 2019-08-24 23:18:22 +08:00
Yangguang Li 6ce5b539e6 merge others 2019-08-24 22:24:19 +08:00
Yangguang Li 45f9d3959c Remove a eslint-disable comment 2019-08-15 11:40:39 +08:00
Yangguang Li 65c4f98ff6 lit-element code review 2019-08-15 10:39:30 +08:00
Johnny Stenback ada3b92a93 Followup fix for #654.
This fixes the chromedash-metadata template to include the deprecated
features entry in the versions list. This also fixes a problem that was
uncovered where an ordered list that was in the incorrect order which
resulted in the wrong implementation status being shown in the versions
list.
2019-08-14 11:29:42 -07:00
Yangguang Li 6a79352ce3 Some updates based on code review 2019-08-12 15:02:22 +08:00
Yangguang Li 254f3f4e90 Update to lit-virtualizer 0.3.0 2019-07-19 16:48:34 -07:00
Yangguang Li 6630bec732 Fix admin pages 2019-07-01 12:43:47 -07:00
Yangguang Li 2aa1743e6c Admin users page. And some css fix 2019-07-01 11:49:46 -07:00
Yangguang Li 6a80a7464b Merge branch 'other-parts' into lit-virtualizer 2019-06-28 10:49:10 -07:00
Yangguang Li e7508cf9f7 Move metrics.scss up. 2019-06-28 10:48:45 -07:00
Yangguang Li e537368048 Merge branch 'other-parts' into lit-virtualizer 2019-06-28 10:44:40 -07:00
Yangguang Li 483ac46bbf Remove console.log 2019-06-28 10:42:18 -07:00
Yangguang Li 24ed543495 Merge branch 'other-parts' into lit-virtualizer 2019-06-28 10:37:54 -07:00
Yangguang Li b5e37a3755 Finish metric page, and some cleanup 2019-06-28 09:56:30 -07:00
Yangguang Li d43f45d993 Merge branch 'components' into other-parts 2019-06-27 13:00:18 -07:00
Yangguang Li 6407a44053 Merge branch 'components' into lit-virtualizer 2019-06-27 13:00:00 -07:00
Yangguang Li 67326b164d Set static values in chromedash-feature, instead of using getters 2019-06-27 12:55:55 -07:00
Yangguang Li 92a4c0edbc Merge conflict 2019-06-25 11:17:26 -07:00
Yangguang Li 7437677a9b Rename pages 2019-06-25 11:16:06 -07:00
Yangguang Li f58061bfee Fix the stats tab in the nav 2019-06-24 15:52:09 -07:00
Yangguang Li 1a39776032 Fix schedule 'hide blink component' 2019-06-24 15:33:57 -07:00
Yangguang Li 51fa25ac8a Finish samples 2019-06-24 15:23:23 -07:00
Yangguang Li 5e53336df9 Finish schedule page 2019-06-24 12:06:27 -07:00
Yangguang Li f1c50d6506 Remove WIP files 2019-06-21 14:41:43 -07:00
Yangguang Li a415c1e720 misc 2019-06-21 14:13:01 -07:00
Yangguang Li 5aad3807e9 Merge branch 'components' into other-parts 2019-06-20 11:39:11 -07:00
Yangguang Li 9a6ad2a9ff Import lit-vir and fix the width 2019-06-19 14:39:47 -07:00
Yangguang Li 3fd617fe66 Update the gulp watch and remote a wrapper element 2019-06-19 13:39:39 -07:00
Yangguang Li d61b398fbc Misc code style changes in response to code review 2019-06-19 13:31:51 -07:00
Yangguang Li a453e1ef4a wip - started schedule 2019-06-18 16:23:52 -07:00
Yangguang Li 0857cc8f89 Import lit-virtualizer 2019-06-16 10:52:01 -07:00
Johnny Stenback c5dd500f49 Fix issue 646, line breaks dropped from motivation.
This ensures we display line breaks in feature motivation fields.
2019-06-04 13:46:51 -07:00
Yangguang Li 29779300d6 Finish page rendering. Without virtual scroller and scrolling features 2019-06-03 11:28:20 -07:00
Yangguang Li 1a7d8e634c Refresh gitignore 2019-05-22 11:13:30 -07:00
Yangguang Li 7196301568 WIP 2019-05-22 11:13:09 -07:00
Yangguang Li 242d0e428b WIP - finished first run of migration. 2019-04-24 13:24:40 -07:00
Yangguang Li 5b83d1c40b Migrate feature.js 2019-04-22 16:50:11 -07:00
Johnny Stenback 519886c2d9 Fix linter error. 2019-03-27 14:54:02 -07:00
Johnny Stenback d436ffe9ff Add support for making form exceptions per category
This adds support for exceptions to the general form
visibility/requirements per category, and adds exceptions for tag review
and wpt form fields for features in the JavaScript category. This also
fixes a few form visibility issues when editing old feature entries that
don't have an intent stage set.
2019-03-18 11:02:53 -07:00
Johnny Stenback 8966095e7c
Merge pull request #603 from GoogleChrome/instructions
Make motivation visible and clarify external content.
2019-03-07 11:05:18 -08:00
Philip Jägenstedt 1f236b3cb2
Hide explainer field for Intent to Remove 2019-03-07 15:45:09 +01:00
Johnny Stenback 018dbca46d Relax field requirements when intending to Remove...
Fixe issue #605. Make the explainer link, i2i link, doc link, and
spec link fields optional for features in the "Remove" intent
stage.
2019-03-04 12:14:54 -08:00
Joe Medley 790b349f2c Make motivation visible and larify external content. 2019-03-01 15:51:46 -08:00
Johnny Stenback bc0a4911b8
Merge pull request #601 from jstenback/fix-old-entry-edit
Fix editing of old Feature entries.
2019-03-01 15:20:03 -08:00
Joe Medley 3e418c02d7
Update feature_form.js 2019-03-01 14:37:13 -08:00
Johnny Stenback fc10365b24 Fix editing of old Feature entries.
This makes it so that editing an old Feature entry (one created before
the notion of intent stage was introduced) is possible again w/o the
need to enter a bunch of launch process specific information.
2019-03-01 13:53:10 -08:00
Johnny Stenback f9a5a9aa63 Expand the length of the free form text fields
This expands the length of the free form text fields from 500 to 1480.
There's a hard maximum of 1500 in the database, and it seems the front
end text field limiting code is buggy and doesn't correctly account for
newlines in the form fields, so I cut this a bit short of the hard limit
to help users more often know that they've reached the limit. This
change also loosens the restriction for the intent to implement link as
users don't always have one at this point.
2019-02-28 14:01:20 -08:00
Johnny Stenback 5cd94d14bc Fix editing of entries with multiline values
This fixes an issue (#595) where several of the form fields added in #589
were not marked as multiline entries in the database (i.e. the form fields
could only contain a single line of text). This changes that, and also fixes
an issue with the Web Platform Tests checkbox couldn't be left unchecked.
2019-02-27 21:36:15 -08:00
Joe Medley c705e15e45 Remove Opera from Dashboard (#586)
* Start removing Opera.

* Mark Opera removals in feature_form.js

* Remove most actual code.

* Remove last commented code.

* Remove toggleSpecLink() since it is never called.

* Feedback from Eric B.
2019-02-27 12:47:01 -08:00
Johnny Stenback 2bb203419e Reduce the max width of the form fields. 2019-02-21 17:00:40 -08:00
Johnny Stenback 6a8ce65520 Unify on using help_text instead of placeholder value for textareas, address additional review feedback, and fix the remaining linter errors. 2019-02-21 12:03:33 -08:00
Johnny Stenback a4e9b01c85 Fix issues found in initial review (including a few surrounding ones spotted while fixing), and fix linter errors reported as well. 2019-02-20 10:43:01 -08:00
Johnny Stenback 7026402f5d Inintial introduction of Blink Launch Process data into Chromestatus.
Add a set of fields to the entry creation/edit form so that we collect
all the information that is part of the blink launch process. This
also makes chromestatus generate up to date intent templates with the
future intent of eliminating the need to manually create and send
intent emails. This includes making feature entries aware of the
current intent stage they're in as well as holding on to all the
additional data so that creating intent messages for later stages of
the launch process is a matter of updating the entry and generating a
new intent message.
2019-02-14 15:46:30 -08:00
Eric Bidelman 3e85c33ce0
http archive charts on metrics pages (#584)
* Integrated httparchive data on metrics pages

* Update note

* Add Bigquery cmd

* dont show empty pre

* Increase iframe height to account for urls

* update bq query

* Update callout

* space for http archive

* space
2019-01-16 11:25:26 -08:00
Eric Bidelman 5f611fdd9f Filter by blink component. Fixes #540 2018-06-18 14:56:32 -07:00
Eric Bidelman 16da7aefcf better spacing, font size 2018-06-12 11:14:32 -07:00
Joe Medley c1f3eb1816 Add disclaimer to 'Consensus & standardization. (#558) 2018-06-08 16:19:36 -07:00
Eric Bidelman 23e78af1ca Modernize deps. Gulp4 2018-06-04 14:56:45 -07:00
Rick Byers c15170f1a3 Revert "Noted the Android WebView metrics inclusion" (#551)
* Revert "Add category for Layered APIs. (#550)"

This reverts commit 4dbdbedc27.

* Revert "Noted the Android WebView metrics inclusion (#537)"

This reverts commit 48191eb4ef.
2018-05-03 08:41:04 -07:00
PhistucK 48191eb4ef Noted the Android WebView metrics inclusion (#537)
* Added a note about included WebView metrics

* Added a note for the metrics spike around 2018-3-20

* Added a note for the metrics spike around 2018-3-20

* Added a note for the metrics spike around 2018-3-20
2018-04-28 09:15:31 -07:00
Eric Bidelman 233d0cd29a crush images. fixes #532 2018-03-23 11:28:02 -07:00
Eric Bidelman 82d208f0e5 Fixes #533 2018-03-23 11:10:32 -07:00
Eric Bidelman 64d59d012e Add to homescreen 2018-01-25 22:30:58 +11:00
Eric Bidelman e80b43625f Preserve newline whitespace on feature pages 2017-12-07 15:56:09 -08:00
Eric Bidelman fe4b0093c4 Make showing historical data a toggle 2017-11-01 15:00:14 -07:00
Eric Bidelman adb5664311 Show 2 years of metrics on the timeline charts 2017-11-01 14:42:42 -07:00
Eric Bidelman 1be155c9fd
Chart UI updates for new metrics (#522)
* Chart UI updates for new metrics

* Use 10.27 for charts marker

* Use prod data

* Update description

* feedback
2017-11-01 14:04:43 -07:00
Eric Bidelman 0df1ddce65 Fix notification feature detect for ios. Fixes #500 2017-10-26 14:36:33 -07:00
Eric Bidelman 129f275b6b Fixes #513 2017-10-26 14:04:43 -07:00
Eric Bidelman 986bfd9b0b Fixes #520 2017-10-20 16:29:11 -07:00
Joe Medley 5daf6ffdd9 Fix cr bug # regex to account for 'desc=' (#509)
* Fix cr bug # regex to account for 'desc='

If the cr bug URL contains a `desc` parameter, the current regex returns it's value instead of the `id'. Here are the two cases the new regex is intended to cover.

https://bugs.chromium.org/p/chromium/issues/detail?id=742518&desc=3
https://bugs.chromium.org/p/chromium/issues/detail?id=742518

Here's where I worked out this solution: https://regex101.com/r/c1ZzwZ/1

* Shorter Regex.

* Update chromedash-feature.html
2017-09-15 11:42:57 -07:00
François Beaufort a7004a6b8f Add Web Share to standalone feature page (#507)
* Add Web Share to standalone feature page

* Address @ebidel feedback
2017-09-14 09:39:16 -07:00
Eric Bidelman 2ce63fcb34 List of features for each blink component owner (#504)
* Add list of features next to owners

* More UI work. Cleanup 500 errors

* Responsive
2017-09-11 17:57:54 -07:00
François Beaufort 903973baac Update Chrome Logos (#497) 2017-08-25 12:34:33 -07:00
Eric Bidelman 651c2d4e55 List by owners page. Fixes #494 2017-08-19 18:29:11 -07:00
Eric Bidelman 40d7d2c7a4 Support multiple primary owners in UI 2017-08-19 12:11:41 -07:00
Eric Bidelman e744847d8a Add feature subscribers and feature owners distinction 2017-08-19 11:22:28 -07:00
Eric Bidelman 82e27ef7ff Schedule: add push notification support to stable and dev columns 2017-08-15 13:09:18 -07:00
Eric Bidelman 3972f18d83 Notifications on schedule page. Fixes #492 2017-08-15 12:39:04 -07:00
Eric Bidelman 9a6de7d8ab Notifications test page behind admin. Print num subscribers per feature 2017-08-06 13:37:08 -07:00
Eric Bidelman 0d970a851f ESLint cleanup. Rev Polymer 1.9.3 and iron-list 1.4.6 2017-08-06 10:35:40 -07:00
Eric Bidelman 06f392bbdc Support push notifications on individual feature page 2017-08-06 10:35:40 -07:00
Eric Bidelman 1d44d3e4f7 Tweaks to push UI. Also for ssl for GA 2017-08-06 10:35:40 -07:00
Eric Bidelman e93e420530 Push notifications: subscribe to all new features and updates 2017-08-06 10:35:40 -07:00
Eric Bidelman e5143b113f Notifications: UI hooked up to subscription state 2017-08-06 10:35:40 -07:00
Eric Bidelman 46f72420c7 Push notifications: sent to subscribers when feature is updated 2017-08-06 10:35:40 -07:00
Eric Bidelman 32f956d3e2 Frontend and tester page for push notifications 2017-08-06 10:35:40 -07:00
Eric Bidelman 88fc5b4f8b Tighten up UI lines 2017-06-30 16:04:31 -07:00
Eric Bidelman 68bf99683f Make schedule public 2017-06-30 16:04:31 -07:00
Eric Bidelman 6cbcf76960 Add blink component to main feature list 2017-06-30 16:04:31 -07:00
Eric Bidelman 951981d4a6 Deep links for components 2017-06-30 16:04:31 -07:00
Eric Bidelman ae7f32ac54 Edit component owners toggle and ui cleanup 2017-06-30 16:04:31 -07:00
Eric Bidelman ecd5550d1f Add seed file for devrel owners and populate handler 2017-06-30 16:04:31 -07:00
Eric Bidelman 5a525734d1 Add/remove functionality for /admin/blink CMS 2017-06-30 16:03:50 -07:00
Eric Bidelman e32d0b68ca Blink component ownners /admin/blink endpoint 2017-06-30 16:03:49 -07:00
Eric Bidelman 87f10b2544 Move toggle to header 2017-06-30 16:03:49 -07:00
Eric Bidelman b11dd81f34 Components in list, toggle, UI cleanup 2017-06-30 16:03:49 -07:00
Eric Bidelman 8f96a9304e Features appearing on release cards 2017-06-30 16:03:49 -07:00
Eric Bidelman abfc6003bd Pretty chrome relase cards 2017-06-30 16:03:49 -07:00