Граф коммитов

98 Коммитов

Автор SHA1 Сообщение Дата
Daniel LaLiberte 20236d5f11
Add chromedash-form-table and -form-field and use for all feature field forms (#1981)
* Add chromedash-form-table and -form-field and use for all form table and field rows.

* Display error text before form field, as it used to.

* Add minimal tests for -form-table and -form-field.

* Add unit tests. Delete commented code.

* Remove unused variables in utils.js

* Undelete showToastMessage and openApprovalsDialog.
2022-06-29 23:58:08 -04:00
Daniel LaLiberte 476ee36d77
Change the guide form field layout for all tables (#1965)
* Change the guide form field layout for all tables

* Updates following comments

* Add chromedash-checkbox, just so we can use the label attribute.

* Add missing option close tag: <option></option>
2022-06-25 16:57:58 -04:00
Kuan-Hsuan (Kevin) Shen 40f7323144
Add permissions API and move all feature content and js scripts into feature-page component (#1972)
* Add process and fieldDefs APIs and move components

* Add processes, cues, fielddefs tests

* Fix typos

* Add `permissions_api` and clean up `feature.html`

* Add permissions_api test and improve feature page test

* Change TODOs, rename test response variables
2022-06-25 10:54:02 -04:00
Kuan-Hsuan (Kevin) Shen 03c1b0efad
Convert part of feature template to a new element (#1937)
* Add chromedash-feature-page element

* Add spinner and move styles into page component

* Add autolinks and add js unit tests

* Fix summary autolink

* Add `sinon` and complete feature-page js test

* Update package-lock.json to include `sinon`

* Update package-lock.json to include `sinon`

* Fix css format, move `sinon` to devDep

* Fix feature page bugs

* Move Promise definitions into test body

Co-authored-by: kevinshen56714 <kevinshen56714@hotmail.com.tw>
2022-06-22 13:20:56 -04:00
Jason Robbins 2f9274488d
Fix UI behavior afte saving user prefs. (#1961)
* Fix UI behavior afte saving user prefs.

* Update and simplify unit test.
2022-06-21 13:45:42 -07:00
Daniel LaLiberte ea3e8beb0f
Form cleanups (focus for radio buttons, extra br) (#1960)
* Misc changes in the works.

* Add workaround for missing focus style on radio buttons.

* Remove use of sl-radio.

* Clarify comment about sl-radio.
2022-06-21 12:53:21 -04:00
Jason Robbins a81d997261
Reduce maxlength to fit limitations of StringProperty fields. (#1942)
* Reduce maxlength to fit limitations of StringProperty fields.

* Round down because some characters count as two.
2022-06-15 17:47:41 -07:00
Jason Robbins 30f05019db
Cope with missing select values. (#1939) 2022-06-15 15:16:06 -07:00
Jason Robbins 682e52bdcd
Avoid type="email" for multi emails. (#1933)
* Avoid type="email" for multi emails.

* A smaller change for the same result
2022-06-13 19:28:57 -07:00
Jason Robbins d0f72920b0 Fix autocomplete unit test in a different way. 2022-06-13 23:14:51 +00:00
Jason Robbins 24775a4422
Fix checkboxes and disabled input autocomplete. (#1928)
* Fix checkboxes and disabled input autocomplete.

* Add autocomplete="off" in python to fix failing unit test.
2022-06-13 15:25:37 -07:00
Daniel LaLiberte 104ad2943d
Define and use chromedash-textarea. Use sl-input. (#1921)
* Define and use chromedash-textarea.  Use sl-input.

* Fix problems. Use setCustomValidity() as intended.

* Add tests of valid and invalid input.

* Add missing newline and remove extra space.
2022-06-12 15:47:13 -04:00
Joe Medley dcedb251b3
Update help text. (#1924)
* Improve the summary help text.

* Add missing quotation mark.

* Change wording slightly.

* Add space after comma.

Co-authored-by: Jason Robbins <jrobbins@gmail.com>
2022-06-08 13:33:02 -07:00
Daniel LaLiberte aa69b9cf87
Add URL validation pattern and MultiUrlField validator (#1901)
* Add single and multi URL form field validation

* Add MultiUrlField

* Add unit test of validate_url

* Add  comment about the url pattern.
2022-05-27 12:02:49 -04:00
Jason Robbins 917c24b74d
Include all_platforms in both i2e and i2s. (#1893) 2022-05-19 12:43:38 -07:00
Daniel LaLiberte e5f1b48d31
Add styling for invalid form field values (#1870)
* Add styling for invalid form field values

* Apply to all multiple email address fields. Use pattern attr to do better validation

* Simplify and correct the email address regex
2022-05-17 15:01:03 -04:00
Jason Robbins ef70a1ab9e
Validate link scheme. (#1873) 2022-05-06 16:56:42 -07:00
Joe Medley 69a106b707
Fix platform spellings. (#1839) 2022-04-17 10:37:48 -07:00
Jason Robbins 552310000c
Revise field help for antipated_spec_changes. (#1835) 2022-04-14 11:12:58 -07:00
Jason Robbins 1ce851fa34
Add field for anticipated spec changes before i2s. (#1832) 2022-04-12 16:53:22 -07:00
Jason Robbins 3710ae1efd
Add fields for WebView OT milestones. (#1830) 2022-04-12 08:42:48 -07:00
Jason Robbins 988c11948e
Set up the new feature list page initially as a feature table. (#1821) 2022-04-07 17:40:39 -07:00
Jason Robbins 0aa2b3cfc9
Relabel owners from "Contact emails" to "Feature owners" (#1783) 2022-03-14 16:44:19 -07:00
Jason Robbins c5b4f276df
Remove obsolete pages: /schedule and /samples. (#1787) 2022-03-14 16:13:01 -07:00
Jason Robbins 761be2732a
Add field for webview_risks. (#1782)
* Add field for webview_risks.

* Update pages/guideforms.py

Co-authored-by: Chris Harrelson <chrishtr@gmail.com>

* Update guideforms.py

Fixed an existing spelling error.

Co-authored-by: Chris Harrelson <chrishtr@gmail.com>
2022-03-09 13:37:07 -08:00
Joe Medley e8c78ee13a
Improve help text for the summary. (#1759) 2022-02-24 11:47:32 -08:00
Daniel LaLiberte a3a2299825
Dlaliberte/django html validation (#1747)
* Add html validation for edit.html. Fix 2 html bugs

* Add html validation for guide, intentpreview, and metrics

* Add test of FeaturePopularityHandler

* Add roadmap_test.py and test of RoadmapHandler

* Fix uses of TEMPLATE_PATH. Add blink_handler_test.

* Add template tests for users.html

* Fix some more test class names.

* One more class name fix.

* Easy fixes.
2022-02-23 21:00:38 -05:00
Daniel LaLiberte 45f904e604
Add html validation for edit.html. Fix 2 html bugs (#1746) 2022-02-16 18:18:14 -05:00
Joseph Medley d682725522 Add clarifying instructions to help text. 2022-02-15 09:51:15 -08:00
Daniel LaLiberte 331f92f3d6 A couple more tests, and one html fix. 2022-02-10 23:09:03 +00:00
Daniel LaLiberte 32cff34cb9 Add html validation to more tests 2022-02-10 19:07:45 +00:00
Daniel LaLiberte bf5b352680 Add test that template renders valid html. 2022-02-05 01:35:03 +00:00
Jason Robbins f0a8733509
Redirect to feature detail page when feature ID is in URL. (#1713)
* Redirect to feature detail page when feature ID is in URL.

* Fix the arrow navigation from the feature detail page to the list.

* Updated unit test
2022-02-02 10:54:43 -08:00
Jason Robbins 317b98fced
Add motivation to the implementation stage for dev-facing changes. (#1703) 2022-01-26 17:14:28 -08:00
Jason Robbins 6aecdb1420
Resolve some more code scanning issues. (#1700)
* Resolve some more code scanning issues.

* Dont log secret prefix.

* Try to outsmart scanner
2022-01-25 16:40:00 -08:00
Johnny Stenback 8fad20e805
Fix DevTrial typo (#1688) 2022-01-19 09:47:06 -08:00
Jason Robbins 7ef9184080
Add non_oss_deps field to guide and intent email template. (#1679) 2022-01-14 14:12:34 -08:00
Jason Robbins fe3f910336
In py3 code, replace the separate mock lib with unittest.mock. (#1665) 2022-01-11 08:20:40 -08:00
Jason Robbins 9a20012660
Add navigational context for feature detail page back arrow. (#1640) 2021-12-08 07:57:37 -08:00
Jason Robbins a6704e72d7
Revert "Add a field for next_review_date. (#1617)" (#1621)
This reverts commit 946ecfbb2f.
2021-11-29 12:32:33 -08:00
Jason Robbins 946ecfbb2f
Add a field for next_review_date. (#1617)
* Add a field for next_review_date.

* Add check for next_review_date to unit test
2021-11-24 12:49:28 -08:00
Jason Robbins 16792ca436
Better intent parsing and add extend experiment link. (#1586)
* Better intent parsing and add extend experiment link.

* Update templates/blink/intent_to_implement.html

Co-authored-by: Kyle Ju <kyleju@google.com>

Co-authored-by: Kyle Ju <kyleju@google.com>
2021-10-19 16:02:46 -07:00
Jason Robbins c57f61680e
Remove Webview DT from the UI. (#1583) 2021-10-13 18:28:22 -07:00
Jason Robbins e9ae478b7d
Remove edge signals and add other signals. (#1581)
* Remove edge signals and add other signals.

* Revert unintented file change
2021-10-13 18:28:03 -07:00
Jason Robbins e77396a8cc
Make app deployable with py3. (#1559)
* Make app deployable with py3.

* Handle empty API posts
2021-09-24 15:19:17 -07:00
Jason Robbins 527c49abed
Move routing configuration to main.py. (#1552)
* Move routing configuration to main.py.

* inline_file works so we dont need this directive

* rebased

* Removed __future__s
2021-09-23 13:01:43 -07:00
Jason Robbins 548828aaa0
Some easy pylint fixes. (#1557) 2021-09-23 12:04:33 -07:00
Kyle Ju b6bb10195a
Run 2to3 to detect py2 to py3 changes (#1551)
* Run 2to3 -w -n .

* Update internals/fetchmetrics.py

* Update internals/models.py

* Update internals/notifier.py

* Update pages/blink_handler.py

* Update internals/fetchmetrics.py
2021-09-22 18:23:14 -07:00
Jason Robbins 940fa4440c
Fix tests in pages/ and internals/. (#1550) 2021-09-22 10:59:55 -07:00
Kyle Ju 06ce5bc8db
Run tests on py3 (#1534)
* 8 exceptions and 3 test failures
2021-09-21 15:49:40 -07:00