Граф коммитов

148 Коммитов

Автор SHA1 Сообщение Дата
Jason Robbins 8c3326728f
Fix display of feature updated-on and refactor date rendering. (#2814) 2023-03-10 18:12:33 -08:00
Jason Robbins 74d3fb881c
Fix missing ctx var in a couple of places. (#2810) 2023-03-10 09:30:00 -08:00
Yann Dago 61e6885473
Add Enterprise feature flow UI/UX changes (#2802)
* Hide edit button on feature page for enterprises
* After creating an enterprise feature go to the edit all page at the first rollout section
* Open all section on the feature page for enterprise by default
* Adding stage for enterprise features only adds rollout feature
* Remove the action of setting a stage in enterprise features
* Update scrolling behavior to scroll to the element from the hash if no form field is found
* Remove the edit icon from the feature page that navigates to the edit page
* Add an id to the "edit all" section headers to serve as an anchor for navigations
2023-03-09 16:18:20 -05:00
Daniel LaLiberte b710351601
Fix hash link scrolling and focus for guide pages (#2804)
* Hacky implementation of scroll to anchor for editall page.

* Generalized a bit and added to stage page.

* Move common code to utils.js, cleanup.
2023-03-09 11:08:43 -05:00
Jason Robbins faf3499262
Convert Adoption gate questionnaire into fields. (#2803) 2023-03-08 16:13:26 -08:00
Jason Robbins feff2882b3
Remove stamp icons. (#2790) 2023-03-06 10:52:20 -08:00
Daniel LaLiberte 5b5cb8725b
Add scrollIntoView to editall-page. Fix link to explainer-links. (#2789) 2023-03-06 12:46:55 -05:00
Daniel Smith 96090e027c
Comment/vote submit buttons disabled on request (#2784) 2023-03-02 10:57:31 -08:00
Daniel Smith 4a7324934d
Display metadata even without devrel val (#2783) 2023-03-02 10:46:17 -08:00
Daniel Smith a19fad825b
Display existing gates for approvals dialog (#2782)
* intent thread detection refactoring

* add gate info to verbose converter

* Display approvals dialog based on existing gates

* Display approvals sorted intuitively

* revert unrelated changes

* remove more unrelated changes

* code cleanup and comments

* small typo
2023-03-02 10:45:58 -08:00
Jason Robbins 06b0fc716f
Make the gate column open with regular click on a gate chip. (#2785) 2023-03-02 07:17:02 -08:00
Yann Dago ae90f406c5
Create new flow for creating enterprise features (#2775)
Remove the enterprise feature choice when creating a new feature.

Make enterprise feature creation accessible via url only.

Ensure only the enterprise fields are shown on the feature, edit and edit all pages for enterprise features.
2023-03-01 11:12:45 -05:00
Akash Upadhyay 99e00c801f
added hidepopup (#2774) 2023-02-24 11:58:19 -08:00
Kyle Ju 59745dacf1
Display devrel under the Metadata section (#2768)
* Display devrel under the Metadata section

* Remove devrel

* Fix test

* Add devrel to metadata edit page

* Update client-src/elements/chromedash-guide-metadata.js

---------

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-02-23 17:26:19 -08:00
Kyle Ju dd75d6668b
Add gate URL parm (#2739)
* Add gate URL parm

* Fix

---------

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-02-16 10:22:23 -08:00
Jason Robbins 51d4c0d3f6
Add preflight dialog when generating intent via gate column. (#2738) 2023-02-15 13:30:32 -08:00
Jason Robbins cf6b5fc8bf
Refactor the preflight dialog into its own element. (#2732)
* Refactor the preflight dialog into its own element.

* remove logging
2023-02-13 11:27:18 -08:00
Jason Robbins 9a8bf4b0d3
Add type="checkbox" because shoelace got more strict. (#2724) 2023-02-03 14:41:10 -08:00
Daniel LaLiberte 9a093f52dd
Update to shoelace-2.0.0 and fix validity test for textarea (#2721)
* Update to shoelace-2.0.0

* Replace el.invalid with el.checkValidity()
2023-02-02 18:28:36 -05:00
Jeffrey Yasskin 6e5b622c82
Fix a link fragment in help text. (#2714) 2023-02-01 12:18:35 -08:00
Kyle Ju cfea484b88
Migrate SetApprovals to SetVotes (#2706)
Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-02-01 11:33:47 -08:00
Jason Robbins 8e147a4e21
Add gates for enterprise, debuggability, testing, and adoption. (#2701) 2023-01-30 12:32:39 -08:00
Jason Robbins 07f4498ae5
Fix preflight Edit links to prior stages. (#2702) 2023-01-30 10:39:38 -08:00
Jason Robbins b8181e4de0
Convert most sl-menu-item to sl-option (#2699) 2023-01-27 16:00:11 -08:00
Kyle Ju 9a06962bac
Fix Vote API response (#2698)
Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-01-27 13:42:02 -08:00
Jason Robbins 5d90dcb53e
Define team gates for privacy and security (#2690)
* Progress on defining team gates.

* Not ready for testing gate yet.

* added tests

* Dont crash on unknown gates

* Keep up with changes to votes return value.

* Update internals/schema_migration.py

Co-authored-by: Kyle Ju <kyleju@google.com>

---------

Co-authored-by: Kyle Ju <kyleju@google.com>
2023-01-27 10:24:10 -08:00
Daniel LaLiberte d4f44f972c
Cleanup form field validation behavior and style (#2696)
* Don't reportValidity for textarea after every update. Add data-user-invalid style for input and textarea.

* Add missing semicolons
2023-01-26 20:29:32 -05:00
Jason Robbins c0b937b193
Stop showing "Saved" indicator when switching to a new gate. (#2691) 2023-01-26 11:28:06 -08:00
Kyle Ju 1fd4efb936
Phase out ApprovalsAPI Get (#2681)
* Phase out ApprovalsAPI Get

* Fix comments

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-01-24 12:39:50 -08:00
Daniel LaLiberte 032499e7f6
Update shoelace to 2.0.0-beta.88. Fix chromedash-textarea.js incompatibilities (#2685)
* Update shoelace to 2.0.0-beta.88.  Fix textarea problems.

* Upgrade lit-analyzer to 1.2.1.  Remove debug output.
2023-01-23 15:24:59 -05:00
Jason Robbins f2368a0c1d
Add attr hoist to the add-a-stage menu. (#2687) 2023-01-20 15:36:07 -08:00
Jason Robbins cd1285cd1f
Revise the wording of the blink gate questionnaire. (#2686) 2023-01-20 15:08:55 -08:00
Jason Robbins 223c3bef6f
Fix selected gate display. (#2682) 2023-01-20 09:13:24 -08:00
Jason Robbins 9f695349d1
Show stage short names in front of row of gate chips. (#2680) 2023-01-19 10:50:26 -08:00
Kyle Ju 1a25b98724
Highlight selected gates (#2676)
* Highlight selected gates

* Fix css

* Fix

* Renaming

* Fix comment

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-01-18 16:23:56 -08:00
Jason Robbins d60aedd0ce
Relabel "Add feature" button as "Create feature" (#2679) 2023-01-18 14:37:07 -08:00
Jason Robbins 4be21e5401
Add simple gate questionnaires and stage action buttons (#2677)
* progress on layout

* Show actions instead of default "request review" button.

* Add JS enums for gate types.

* Update client-src/elements/chromedash-gate-column.js

Co-authored-by: Kyle Ju <kyleju@google.com>

* Add semicolon to HTML entity.

Co-authored-by: Kyle Ju <kyleju@google.com>
2023-01-18 13:30:05 -08:00
Jason Robbins 908403a0db
Fix sidebar width on mobile. (#2678) 2023-01-18 08:41:17 -08:00
Akash Upadhyay 64fe467af3
updated scrollIntoView (#2671) 2023-01-17 18:28:47 -08:00
Daniel Smith df1732c2e7
Update form-field-specs.js (#2626) 2023-01-12 17:02:26 -08:00
Daniel Smith c68c496415
Confirm trial extension creation when an extension exists. (#2658)
* trial extensions displayed and edited with trials

* edit extension info on editall

Also, display trial info on detail page

* thorough commenting

* concat stageIds

* Add corner case cover

Display only extension info if it exists but the original trial extension information does not.

* Allow users to create trial extension stages

* fix test

* fix gates in test

* remove extension fields from dep trial stage

* Add confirmation msg if extension already exists
2023-01-12 14:32:20 -08:00
Daniel Smith 263f94cc25
Add small sentence to "Add stage" dialog (#2657) 2023-01-12 12:35:57 -08:00
Daniel Smith 820bb801dc
Add trial extensions (#2656)
* trial extensions displayed and edited with trials

* edit extension info on editall

Also, display trial info on detail page

* thorough commenting

* concat stageIds

* Add corner case cover

Display only extension info if it exists but the original trial extension information does not.

* Allow users to create trial extension stages

* fix test

* fix gates in test

* remove extension fields from dep trial stage
2023-01-12 12:35:10 -08:00
Daniel Smith 867fb75b7a
add motivation to deprecation plan stage (#2663) 2023-01-12 09:07:42 -08:00
Kyle Ju e8591b3da1
Clean up do_post in Comment APIs (#2653)
* Clean up do_post in Comment APIs

* Remove approval bit in Comment API

* Nit

* nit

* Renaming

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-01-11 17:20:31 -08:00
Daniel Smith 034eec4825
Support for multiple trial extension stages (#2655)
* trial extensions displayed and edited with trials

* edit extension info on editall

Also, display trial info on detail page

* thorough commenting

* concat stageIds

* Add corner case cover

Display only extension info if it exists but the original trial extension information does not.
2023-01-11 13:27:44 -08:00
Kyle Ju a0f9d57da8
Display correct comments for gate (#2644)
* Display correct comments for gatechip

* Update api/comments_api_test.py

* Add a test

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-01-10 17:11:49 -08:00
Daniel LaLiberte b2a35145c9
Add extra help for Explainer link(s) (#2566)
* Add extra help for Explainer link(s)

* Restructure text, move a couple lines to prototyping

* Changes as suggested.

* Update from comments.

* formatting
2023-01-10 12:29:00 -05:00
Daniel Smith ff8bdd0646
gate chips display a short name for the gate type (#2634) 2023-01-09 12:14:43 -08:00
Daniel Smith 677a7cc708
active stage checked by active_stage_id (#2633) 2023-01-06 13:54:30 -08:00