Граф коммитов

83 Коммитов

Автор SHA1 Сообщение Дата
Jason Robbins bd9e6999cf
Allow mock login to test accounts. (#3121) 2023-06-27 19:21:37 -07:00
Yann Dago 9ba8b16f14
Add creation date field to stages and backfill them to the feature creation date (#3107)
* Add creation date field to stages and backfill them to the feature creation date
2023-06-22 09:33:11 -04:00
Ping 03b0130563
Enhance feature link (#3075)
* Fix feature_links edge cases

* Add basic FeatureLinksAPI

* Add feature-link to enhance autolink and normal url in feature detail page

* Add tooltip to enhanceChromeStatusLink, polish styles

* Make featureLinks non blocking request

* Add closedTimestamp in enhanceChromeStatusLink

* Remove placeholder function

* Add back white-space: pre-wrap and fix CSS

* Use gray color badge for closed issue

* Rename fallback and change it to a lit-html object

* Move feature link summary into tooltip

* Support custom text in enhanceUrl
2023-06-16 23:07:48 +08:00
Jason Robbins 85c3c0d9c5
Implement a simple JSON report about overdue review gates. (#3086) 2023-06-15 17:12:28 -07:00
Jason Robbins c8fbdbe10f
Implement script to backfill gate.responded_on. (#3083)
* Implement script to backfill gate.responded_on.

* Made code more robust
2023-06-14 17:24:43 -07:00
Yann Dago 16de638280
Enterprise flow updates and fixes (#3067)
* Add screenshot links to the enterprise feature creation page
* Make enterprise pages that require sign in use an intermediate component when not signed in and redirect to the initial page when signed in
* Move Rollout steps help text to the edit all page
* Rename "Start feature rollout" to "Rollout Step"
* Rename "Rollout stages" to "Rollout steps"
* Fix editors not showing on the feature details page for all features
* Fix enterprise categories only using the first category chosen after creating a new feature
2023-06-09 13:38:57 -04:00
Jason Robbins 7c1bf8d2f3
Migrate ff_views values. (#3020) 2023-05-19 17:34:42 -07:00
Yann Dago 572397dc87
Restrict release note page access, add help text to enterprise rollout stages (#3003)
* /enterprise/releasenotes is now restricted to @google.com and @chromium.org accounts
* A new help text has been added at the rollout stage for enterprise features
2023-05-11 17:08:03 -04:00
Daniel Smith b0d5de41c3
POST request functionality for Features API (#2923)
* Post request functionality for Features API

* Create feature only accepts mutable fields

* Docstring and type hints
2023-05-04 13:15:02 -07:00
Kyle Ju 9f939866a4
Crate a standalone Activity Page (#2925)
* Crate an Activity Page

* Address comments

---------

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-04-21 13:08:15 -07:00
Daniel Smith ad9386cdb9
Remove the rest of old schema references (#2910)
* Remove the rest of old schema references

* Keep maintenance scripts

* move script Route
2023-04-12 22:46:41 -07:00
Yann Dago d51da1ae89
Create new enterprise release notes page (#2878)
This new page will show the enterprise release notes for a selected milestone.

The new page is available at /enterprise/releasenotes.
2023-03-30 14:15:56 -04:00
Daniel Smith fac048212f
Remove Approvals API (#2870)
* Remove approvals API

* remove Approval references from detect_intent

* Remove further references to Approval kind

* Add back Approvals tests in legacy_models_test
2023-03-27 18:21:46 -07:00
Jason Robbins 52328f8d90
Update werkzeug and stopusing routes with the same path. (#2861) 2023-03-27 13:54:05 -07:00
James C Scott III f33576a5f3
Migrate admin/blink.html to SPA [5/5] (#2743)
* Migrate admin/blink.html to SPA

Add implementations of the three new API routes
Remove old code for templated admin/blink.html

* Remove old handler and template

* start of tests

* fix tests

* temp

* separate into smaller elements

* add more python tests

* fix lint for optional values

* add tests

* fix lint error

* update model names

* use global

* fix test

* fix jsdoc from renaming

* address feedback
2023-03-24 18:25:18 -04:00
Kyle Ju 58e7f66808
Notify subscribers of a new comment (#2835)
* Notify subscribers of a new comment

* Add /tasks/email-comments notifier task

* Fix

---------

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-03-20 10:08:24 -07:00
Daniel Smith 7405abb2e6
Remove old migration scripts (#2843)
* remove old schema migration scripts

* delete test file
2023-03-20 02:26:06 -07:00
Kyle Ju 707fe9ad09
Lgtm fields migration (#2777)
* LGTM field migration script

* Fix

Address comments

---------

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-03-02 10:54:09 -08:00
Yann Dago ae90f406c5
Create new flow for creating enterprise features (#2775)
Remove the enterprise feature choice when creating a new feature.

Make enterprise feature creation accessible via url only.

Ensure only the enterprise fields are shown on the feature, edit and edit all pages for enterprise features.
2023-03-01 11:12:45 -05:00
Daniel Smith 2ad7a1dbbd
Migrate subject line fields to new schema (#2772)
* Add subject line fields to new schema

* mypy fix
2023-02-23 16:02:39 -08:00
Kyle Ju bf849c1c07
Reland Create /tasks/email-reviewers in notifier (#2720)
* Fix tests

* Create /tasks/email-reviewers in notifier

* nit

* Create a email task for review request

---------

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-02-13 21:51:52 -08:00
Kyle Ju b38745b157 Revert "Create /tasks/email-reviewers in notifier"
This reverts commit dc48d2d29c.
2023-02-01 17:15:49 -08:00
Kyle Ju dc48d2d29c Create /tasks/email-reviewers in notifier 2023-02-01 17:08:04 -08:00
Kyle Ju 1fd4efb936
Phase out ApprovalsAPI Get (#2681)
* Phase out ApprovalsAPI Get

* Fix comments

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-01-24 12:39:50 -08:00
Kyle Ju a0f9d57da8
Display correct comments for gate (#2644)
* Display correct comments for gatechip

* Update api/comments_api_test.py

* Add a test

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-01-10 17:11:49 -08:00
Daniel Smith 0c023117b9
script to create trial extension stages (#2625) 2023-01-05 16:02:45 -08:00
Daniel Smith 742a640a31
Edit metadata from the feature detail page (#2619)
* metadata field can be edited from feature-detail

* remove unused variables
2023-01-03 16:00:01 -08:00
Daniel Smith 6b3c5602fa
create new stages on the feature detail page (#2611)
* create new stages on the feature detail page

* comments and spacing

* remove unused import

* changes suggested by @jrobbins

* Update chromedash-feature-detail.js

* change capitalization
2023-01-03 10:42:23 -08:00
Daniel Smith cc3a46fa92
Use specific stage data for viewing and editing feature data (#2561)
* display and edit stages based on stage ID

* fix test

* defensive coding with intent stages

* new routes

* save active_stage_id in guide.py

This change is set to land in a separate PR.

* display active stage on detail page correctly

* remove "SHIPPED" stage types

* fix processes and tests

* add shipped form field to shipping form field

* Show matching process stages on process overview

* fix tests

* remove active_stage_id reference

* remove active_stage_id from test

* typo

* update url

* fix web test

* Consolidate "prepare to ship" and "ship"

* add small comment

* remove duplicated function

* clear up logic for writing to stages

* backwards-compatible urls and api

* Update tests
2022-12-20 10:07:18 -08:00
Jason Robbins 414f673af9
Implement votes_api and move some code around. (#2586) 2022-12-15 17:47:21 -08:00
Daniel Smith 45e7613992
Add routes for intent stage and stage ID to guide (#2555) 2022-12-07 14:14:00 -08:00
Daniel Smith 1896a17d60
script for creating missing gates (#2552)
* script for creating missing gates

* add comment

* trailing comma
2022-12-07 11:52:04 -08:00
Daniel Smith 69e5f86596
add active_stage_id field to FeatureEntry (#2551)
* add active_stage_id field to FeatureEntry

* changes suggested by @jrobbins

* trailing comma
2022-12-07 11:12:55 -08:00
Daniel Smith a58d2bda77
Create Stages API (#2535)
* Add new stages API

* add routes and mypy

* changes/fixes suggested by @jrobbins
2022-12-05 13:10:14 -08:00
Jason Robbins 3d8042bc58
Initial enterprise landing page (#2529)
* First draft

* Combined into one box

* Must use enum string vals

* Added JS unit tests

* Avoid unneeded quotes
2022-12-01 11:41:08 -08:00
Jason Robbins b04d2c941e
In pending-approval-by:me box, offer gate chips instead of the approval stamp icon (#2487)
* progress

* Basically working

* Put back editing pencil icon for now.

* Addressed review commetns
2022-11-18 17:19:11 -08:00
Daniel Smith bdf12e24d9
Add dev API to write and delete test data (#2475)
* Write and delete data for dev environments

* Add 2nd feature entry

* write old Feature entities as well

* More thorough commenting

* Make sure endpoints can only be used locally

* update return statements

* devtrial_instructions is a link

* changes suggested by @jrobbins

* comment change
2022-11-16 22:48:38 -08:00
Daniel Smith 2602d06d81
Update and handle deprecated views fields (#2484)
* Update and handle deprecated views fields

* value reference consistency

* changes suggested by @jrobbins
2022-11-16 16:09:14 -08:00
Daniel Smith df1059f044
Remove standard maturity backfill script (#2477)
* Remove standard maturity backfill script

* remove from cron.yaml
2022-11-15 11:17:11 -08:00
Daniel Smith d331c4540e
Add new route dataclass (#2456)
* Add new route dataclass

* add blank line
2022-11-09 10:06:59 -08:00
Daniel Smith deed5e0d78
Add default value to updated field (#2453)
* Add default value to updated field

* change name

* commas

* explicit dates in testing
2022-11-08 13:09:54 -08:00
Daniel Smith 583cff4df5
Move schema migration cron jobs to different url (#2403)
* Move schema migration cron jobs to different url

* remove test line
2022-10-26 14:01:28 -07:00
Jason Robbins 8586ace822
Implement simple full-text search using NDB (#2392)
* Progress

* Code complete

* Started writing tests

* local mypy

* Finished tests for now and fixed some defects
2022-10-26 12:09:01 -07:00
Daniel Smith 6bcc97ea9d
Migrate votes and set Gate state separately (#2374)
This change is to handle the timeout issues for the schema migration script.

It includes:
- Separating Vote migration into a separate script.
- Evaluating Gate state in a separate script.
- Removing convoluted entity count tracking from main script.
2022-10-24 16:54:05 -07:00
Jason Robbins e87c77ce8f
Show a message to anyone that visits /samples. (#2382)
* Show a message to anyone that visits /samples.

* fix test
2022-10-24 11:40:33 -07:00
Daniel Smith 49fb21595d
Run mypy in Github continuous integration checks (#2324)
* run mypy in CI

* more type hint fixing

* Update requirements.txt

* google.cloud import workaround

https://github.com/python/mypy/issues/10360

* Revert "google.cloud import workaround"

This reverts commit e03dbc7bbeb67acc81f57b9c5d905b9141952dbc.

* mypy google.cloud workaround

https://github.com/python/mypy/issues/12985

* fix regular tests

* remove --install-types flag

* last mypy fix

* type fixes for address_reasons

* move email lists creation

* update for newly merged changes

* Fix regular tests

* Changes suggested by @jrobbins

* Catch invalid requests

* small type hint

* Change methods to properly override

* revert to previous implementation

* revert test

* add back original validate request type method

* remove unused import and rearrange methods

* remove comment string casting; add test back

* add ndb ignore

* Update test_html_rendering.html

* mypy fix

* remove merge addition
2022-10-24 06:40:21 -07:00
Daniel Smith 7dc0dc12a0
Move most entities to single migration script (#2325)
* Move most entities to single migration

* comma typo

* Move additional entity writes into special handler
2022-10-13 09:09:53 +02:00
Daniel Smith c422b05881
Migrate Approval entities to Vote entities (#2279)
* migrate approvals to votes

* cron boilerplate

* refactor using generic function
2022-10-03 10:54:32 -07:00
Daniel Smith 2eab43d7af
Migrate Feature entities to FeatureEntry entities (#2275)
* migrate Feature entities to FeatureEntry entities

* fix test

* Handle cc_recipients and comments fields

* Check for already migrated features efficiently

* typo

* remove square brackets from comprehension

* remove spaces

* comments on renaming

* refactor for generic function use
2022-10-03 10:10:15 -07:00
Jason Robbins 84cbd9016a
Refactored reminders and added prepublication notice. (#2262)
* Refactored reminders and added prepublication notice.

* Added links to references

* Improved tests

* Update internals/reminders.py

Co-authored-by: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>

* Updated comment

Co-authored-by: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
2022-09-23 10:23:55 -07:00