Update README and CONTRIBUTING for Gerrit review
R=yusufo Bug: 766215 Change-Id: I4953ad35bfe8ccfc8be5e471c0b2473db45a33b6 Reviewed-on: https://chromium-review.googlesource.com/755515 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
This commit is contained in:
Родитель
9f57460050
Коммит
f7d39584f6
|
@ -26,13 +26,13 @@ organization's) name and contact info to the Chromium AUTHORS file.
|
||||||
|
|
||||||
## Contributing
|
## Contributing
|
||||||
All submissions, including submissions by project members, require review. We
|
All submissions, including submissions by project members, require review. We
|
||||||
use [Rietveld](http://codereview.chromium.org) instance for this purpose.
|
use [Gerrit](http://chromium-review.googlesource.com) for this purpose.
|
||||||
|
|
||||||
Install [depot_tools](https://www.chromium.org/developers/how-tos/install-depot-tools).
|
Install [depot_tools](https://www.chromium.org/developers/how-tos/install-depot-tools).
|
||||||
|
|
||||||
Then checkout the repo.
|
Then checkout the repo.
|
||||||
|
|
||||||
`git clone https://github.com/GoogleChrome/custom-tabs-client.git`
|
`git clone https://chromium.googlesource.com/custom-tabs-client`
|
||||||
|
|
||||||
You can then create a local branch, make and commit your change.
|
You can then create a local branch, make and commit your change.
|
||||||
|
|
||||||
|
@ -47,9 +47,9 @@ Once you're ready for a review do:
|
||||||
|
|
||||||
`git cl upload`
|
`git cl upload`
|
||||||
|
|
||||||
Once uploaded you can view the CL in Rietveld and request a review by clicking
|
Once uploaded you can view the CL in Gerrit and request a review by clicking
|
||||||
the 'publish & mail' link. The
|
the 'publish & mail' link. The
|
||||||
[OWNERS](https://github.com/GoogleChrome/custom-tabs-client/blob/master/OWNERS)
|
[OWNERS](https://chromium.googlesource.com/custom-tabs-client/+/master/OWNERS)
|
||||||
file suggests relevant reviewers, but does not have any real power, any Chromium
|
file suggests relevant reviewers, but does not have any real power, any Chromium
|
||||||
committer has the power to approve the change.
|
committer has the power to approve the change.
|
||||||
|
|
||||||
|
@ -69,38 +69,24 @@ git branch -D foo
|
||||||
## Contributing from a Chromium checkout
|
## Contributing from a Chromium checkout
|
||||||
|
|
||||||
If you already have this repo checked out as part of a Chromium checkout and want
|
If you already have this repo checked out as part of a Chromium checkout and want
|
||||||
to edit it in place (instead of having a separate clone of the repository), it
|
to edit it in place (instead of having a separate clone of the repository), you
|
||||||
will require a little more Git skills.
|
can use the exact same process as above.
|
||||||
|
|
||||||
Add another remote:
|
|
||||||
|
|
||||||
```
|
|
||||||
git remote add github https://github.com/GoogleChrome/custom-tabs-client.git
|
|
||||||
git fetch github
|
|
||||||
```
|
|
||||||
|
|
||||||
When branching, remember to branch from the right repo:
|
|
||||||
|
|
||||||
```
|
|
||||||
git checkout -b foo github/master
|
|
||||||
```
|
|
||||||
|
|
||||||
When doing `gclient sync` in the Chromium tree, remember to switch back to the
|
When doing `gclient sync` in the Chromium tree, remember to switch back to the
|
||||||
local branch `master`.
|
local branch `master`.
|
||||||
|
|
||||||
## Updating Custom Tabs Examples in the Chromium tree (rolling DEPS)
|
## Updating Custom Tabs Examples in the Chromium tree (rolling DEPS)
|
||||||
To get your commit to be tested as part of the Chromium tree in
|
To get your commit to be tested as part of the Chromium tree in
|
||||||
`src/third_party/custom_tabs_client`, find the git hash of your commit on the
|
`src/third_party/custom_tabs_client`, find the git hash of your landed commit
|
||||||
[mirror](https://chromium.googlesource.com/external/github.com/GoogleChrome/custom-tabs-client/).
|
in the [repo](https://chromium.googlesource.com/custom-tabs-client/+log/).
|
||||||
(Note: it may take a few minutes to be mirrored).
|
|
||||||
|
|
||||||
Then edit Chrome's [src/DEPS]
|
Then edit Chrome's
|
||||||
(https://code.google.com/p/chromium/codesearch#chromium/src/DEPS) file. Look for
|
[src/DEPS](https://chromium.googlesource.com/chromium/src/+/master/DEPS) file.
|
||||||
a line like:
|
Look for a line like:
|
||||||
|
|
||||||
```
|
```
|
||||||
'src/third_party/custom_tabs_client/src':
|
'src/third_party/custom_tabs_client/src':
|
||||||
Var('chromium_git') + '/external/github.com/GoogleChrome/custom-tabs-client.git' + '@' +
|
Var('chromium_git') + '/custom-tabs-client.git' + '@' +
|
||||||
'bbbf71f41e79b0cfe21199220f495cbd0a3a4ffb',
|
'bbbf71f41e79b0cfe21199220f495cbd0a3a4ffb',
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|
|
@ -8,7 +8,7 @@ performance of a complete web browser.
|
||||||
## Examples
|
## Examples
|
||||||
|
|
||||||
[Using Custom
|
[Using Custom
|
||||||
Tabs](https://github.com/GoogleChrome/custom-tabs-client/blob/master/Using.md)
|
Tabs](https://chromium.googlesource.com/custom-tabs-client/+/master/Using.md)
|
||||||
should be easy. This repository hosts examples and in-depth documentation. The
|
should be easy. This repository hosts examples and in-depth documentation. The
|
||||||
examples are importable as projects into the Android Studio.
|
examples are importable as projects into the Android Studio.
|
||||||
|
|
||||||
|
@ -27,4 +27,4 @@ place, we prefer the Chromium issue tracker at the moment.
|
||||||
## Contributing
|
## Contributing
|
||||||
|
|
||||||
We accept contributions to Custom Tabs examples and documentation. Please see
|
We accept contributions to Custom Tabs examples and documentation. Please see
|
||||||
[our contributor's guide](https://github.com/GoogleChrome/custom-tabs-client/blob/master/CONTRIBUTING.md).
|
[our contributor's guide](https://chromium.googlesource.com/custom-tabs-client/+/master/CONTRIBUTING.md).
|
||||||
|
|
Загрузка…
Ссылка в новой задаче