Merge pull request #377 from paullewis/mg-test

Adds manifest gather test

src/gatherers/manifest.js

@@ -21,6 +21,7 @@ const manifestParser = require('../lib/manifest-parser');
 
 /* global document, XMLHttpRequest, __returnResults */
 
+/* istanbul ignore next */
 function getManifestContent() {
   function post(response) {
     // __returnResults is magically inserted by driver.evaluateAsync
@@ -85,6 +86,9 @@ class Manifest extends Gather {
       } else {
         this.artifact = manifestParser(returnedValue.manifestContent);
       }
+    }, _ => {
+      this.artifact = Manifest._errorManifest('Unable to retrieve manifest');
+      return;
     });
   }
 }

test/src/gatherers/manifest.js

@@ -0,0 +1,91 @@
+/**
+ * Copyright 2016 Google Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+'use strict';
+
+/* eslint-env mocha */
+
+const GathererClass = require('../../../src/gatherers/manifest');
+const assert = require('assert');
+let Gatherer;
+
+const isExpectedOutput = artifact => {
+  return 'raw' in artifact && 'value' in artifact;
+};
+
+describe('Manifest gatherer', () => {
+  // Reset the Gatherer before each test.
+  beforeEach(() => {
+    Gatherer = new GathererClass();
+  });
+
+  it('returns an artifact', () => {
+    return Gatherer.postProfiling({
+      driver: {
+        evaluateAsync() {
+          return Promise.resolve('');
+        }
+      }
+    }).then(_ => {
+      assert.ok(typeof Gatherer.artifact === 'object');
+    });
+  });
+
+  it('handles driver failure', () => {
+    return Gatherer.postProfiling({
+      driver: {
+        evaluateAsync() {
+          return Promise.reject('such a fail');
+        }
+      }
+    }).then(_ => {
+      assert(false);
+    }).catch(_ => {
+      assert.ok(isExpectedOutput(Gatherer.artifact));
+    });
+  });
+
+  it('propagates error retrieving the manifest', () => {
+    const error = 'There was an error.';
+    return Gatherer.postProfiling({
+      driver: {
+        evaluateAsync() {
+          return Promise.resolve({
+            error
+          });
+        }
+      }
+    }).then(_ => {
+      assert.ok(Gatherer.artifact.debugString === error);
+    });
+  });
+
+  it('creates a manifest object for valid manifest content', () => {
+    const manifestContent = JSON.stringify({
+      name: 'App'
+    });
+    return Gatherer.postProfiling({
+      driver: {
+        evaluateAsync() {
+          return Promise.resolve({
+            manifestContent
+          });
+        }
+      }
+    }).then(_ => {
+      assert.ok(typeof Gatherer.artifact.value === 'object');
+    });
+  });
+});