From bf2c15d3bfebe358b270d792af680262a9d0a502 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Mon, 1 Nov 2021 13:09:26 -0700 Subject: [PATCH] core(config): use abbreviation for pwa category title (#13270) --- clients/extension/scripts/settings-controller.js | 2 +- lighthouse-cli/test/cli/__snapshots__/index-test.js.snap | 2 +- lighthouse-core/config/default-config.js | 2 +- lighthouse-core/test/results/sample_v2.json | 2 +- report/test/renderer/report-renderer-test.js | 2 +- shared/localization/locales/en-US.json | 2 +- shared/localization/locales/en-XL.json | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/clients/extension/scripts/settings-controller.js b/clients/extension/scripts/settings-controller.js index 45529d6de7..500cb04366 100644 --- a/clients/extension/scripts/settings-controller.js +++ b/clients/extension/scripts/settings-controller.js @@ -20,7 +20,7 @@ const DEFAULT_CATEGORIES = [{ title: 'SEO', }, { id: 'pwa', - title: 'Progressive Web App', + title: 'PWA', }]; /** @typedef {{selectedCategories: string[], device: string}} Settings */ diff --git a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap index fd327c311b..63980f2ba4 100644 --- a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap +++ b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap @@ -1210,7 +1210,7 @@ Object { "supportedModes": Array [ "navigation", ], - "title": "Progressive Web App", + "title": "PWA", }, "seo": Object { "auditRefs": Array [ diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js index d651a76121..6185d6bb85 100644 --- a/lighthouse-core/config/default-config.js +++ b/lighthouse-core/config/default-config.js @@ -96,7 +96,7 @@ const UIStrings = { /** Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website accessible to search engine crawlers. */ seoCrawlingGroupDescription: 'To appear in search results, crawlers need access to your app.', /** Title of the Progressive Web Application (PWA) category of audits. This is displayed at the top of a list of audits focused on topics related to whether or not a site is a progressive web app, e.g. responds offline, uses a service worker, is on https, etc. Also used as a label of a score gauge. */ - pwaCategoryTitle: 'Progressive Web App', + pwaCategoryTitle: 'PWA', /** Description of the Progressive Web Application (PWA) category. This is displayed at the top of a list of audits focused on topics related to whether or not a site is a progressive web app, e.g. responds offline, uses a service worker, is on https, etc. No character length limits. 'Learn More' becomes link text to additional documentation. */ pwaCategoryDescription: 'These checks validate the aspects of a Progressive Web App. ' + '[Learn more](https://developers.google.com/web/progressive-web-apps/checklist).', diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json index 037b2ec8c4..57a211c1f5 100644 --- a/lighthouse-core/test/results/sample_v2.json +++ b/lighthouse-core/test/results/sample_v2.json @@ -6767,7 +6767,7 @@ "score": 0.67 }, "pwa": { - "title": "Progressive Web App", + "title": "PWA", "description": "These checks validate the aspects of a Progressive Web App. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist).", "manualDescription": "These checks are required by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are not automatically checked by Lighthouse. They do not affect your score but it's important that you verify them manually.", "supportedModes": [ diff --git a/report/test/renderer/report-renderer-test.js b/report/test/renderer/report-renderer-test.js index 43f31bc957..1bdaff22d5 100644 --- a/report/test/renderer/report-renderer-test.js +++ b/report/test/renderer/report-renderer-test.js @@ -90,7 +90,7 @@ describe('ReportRenderer', () => { const output = renderer.renderReport(sampleResultsCopy, container); function isPWAGauge(el) { - return el.querySelector('.lh-gauge__label').textContent === 'Progressive Web App'; + return el.querySelector('.lh-gauge__label').textContent === 'PWA'; } function isPluginGauge(el) { return el.querySelector('.lh-gauge__label').textContent === 'Some Plugin'; diff --git a/shared/localization/locales/en-US.json b/shared/localization/locales/en-US.json index eacb6fb9fc..94e840870f 100644 --- a/shared/localization/locales/en-US.json +++ b/shared/localization/locales/en-US.json @@ -1776,7 +1776,7 @@ "message": "These checks are required by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are not automatically checked by Lighthouse. They do not affect your score but it's important that you verify them manually." }, "lighthouse-core/config/default-config.js | pwaCategoryTitle": { - "message": "Progressive Web App" + "message": "PWA" }, "lighthouse-core/config/default-config.js | pwaInstallableGroupTitle": { "message": "Installable" diff --git a/shared/localization/locales/en-XL.json b/shared/localization/locales/en-XL.json index acaae30586..803c3e972b 100644 --- a/shared/localization/locales/en-XL.json +++ b/shared/localization/locales/en-XL.json @@ -1776,7 +1776,7 @@ "message": "T̂h́êśê ćĥéĉḱŝ ár̂é r̂éq̂úîŕêd́ b̂ý t̂h́ê b́âśêĺîńê [ṔŴÁ Ĉh́êćk̂ĺîśt̂](https://developers.google.com/web/progressive-web-apps/checklist) b́ût́ âŕê ńôt́ âút̂óm̂át̂íĉál̂ĺŷ ćĥéĉḱêd́ b̂ý L̂íĝh́t̂h́ôúŝé. T̂h́êý d̂ó n̂ót̂ áf̂f́êćt̂ ýôúr̂ śĉór̂é b̂út̂ ít̂'ś îḿp̂ór̂t́âńt̂ t́ĥát̂ ýôú v̂ér̂íf̂ý t̂h́êḿ m̂án̂úâĺl̂ý." }, "lighthouse-core/config/default-config.js | pwaCategoryTitle": { - "message": "P̂ŕôǵr̂éŝśîv́ê Ẃêb́ Âṕp̂" + "message": "P̂ẂÂ" }, "lighthouse-core/config/default-config.js | pwaInstallableGroupTitle": { "message": "Îńŝt́âĺl̂áb̂ĺê"