From 16e88315e1ed643a2bde053930feb2bae149d34e Mon Sep 17 00:00:00 2001 From: kingces95 Date: Mon, 11 Apr 2016 16:56:07 -0700 Subject: [PATCH] Enable warnings 0649 and 0067 on UAP/WinRT (#73) --- Xamarin.Forms.Platform.UAP/MasterDetailPageRenderer.cs | 2 ++ Xamarin.Forms.Platform.UAP/Xamarin.Forms.Platform.UAP.csproj | 4 ++-- Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs | 2 +- Xamarin.Forms.Platform.WinRT/TextCellRenderer.cs | 2 ++ 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Xamarin.Forms.Platform.UAP/MasterDetailPageRenderer.cs b/Xamarin.Forms.Platform.UAP/MasterDetailPageRenderer.cs index c8c09789a..e2ccb3122 100644 --- a/Xamarin.Forms.Platform.UAP/MasterDetailPageRenderer.cs +++ b/Xamarin.Forms.Platform.UAP/MasterDetailPageRenderer.cs @@ -98,7 +98,9 @@ namespace Xamarin.Forms.Platform.UWP get { return Element; } } +#pragma warning disable 0067 // Revisit: Can't remove; required by interface public event EventHandler ElementChanged; +#pragma warning restore public SizeRequest GetDesiredSize(double widthConstraint, double heightConstraint) { diff --git a/Xamarin.Forms.Platform.UAP/Xamarin.Forms.Platform.UAP.csproj b/Xamarin.Forms.Platform.UAP/Xamarin.Forms.Platform.UAP.csproj index 88aef6faf..ff9775e64 100644 --- a/Xamarin.Forms.Platform.UAP/Xamarin.Forms.Platform.UAP.csproj +++ b/Xamarin.Forms.Platform.UAP/Xamarin.Forms.Platform.UAP.csproj @@ -27,7 +27,7 @@ prompt 4 true - 1998;0649;0169;0067 + 1998;0618;0169 AnyCPU @@ -38,7 +38,7 @@ prompt 4 true - 1998;0649;0169;0067 + 1998;0618;0169 ARM diff --git a/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs b/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs index 5c2317386..47ff326ef 100644 --- a/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs +++ b/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs @@ -628,7 +628,7 @@ namespace Xamarin.Forms.Platform.WinRT } #endif - bool _deferSelection; + bool _deferSelection = false; Tuple _deferredSelectedItemChangedEvent; } } \ No newline at end of file diff --git a/Xamarin.Forms.Platform.WinRT/TextCellRenderer.cs b/Xamarin.Forms.Platform.WinRT/TextCellRenderer.cs index 7adf009d2..4d04a5ee0 100644 --- a/Xamarin.Forms.Platform.WinRT/TextCellRenderer.cs +++ b/Xamarin.Forms.Platform.WinRT/TextCellRenderer.cs @@ -34,7 +34,9 @@ namespace Xamarin.Forms.Platform.WinRT return true; } +#pragma warning disable 0067 // Revisit: Can't remove; required by interface public event EventHandler CanExecuteChanged; +#pragma warning restore public void Execute(object parameter) {