Граф коммитов

188 Коммитов

Автор SHA1 Сообщение Дата
Frank A. Krueger e8660383b0 [All] Use IReflectableType when accessing the Registrar (#1006)
* [Core] Add GetHandlerForObject and GetHandlerTypeForObject to Registrar

These new methods first try to use IReflectableType in order to support
dynamic objects. If that fails, GetType is used.

* [Platforms] Switch to query the Registrar using GetHandlerForObject

This enables dynamic objects to be used as renderers and other
points of extensibility.

* Take into account dynamic type info when comparing cell renderers

* Fix null renderer object type

* Update Registrar`1.xml

* Update Registrar`1.xml
2017-09-28 16:35:28 +02:00
kingces95 d4480b2e48 Add iOS prototypical cell cache for LV RowHeight calcs (#1143) 2017-09-16 15:10:04 +01:00
Samantha Houts b47068a21e [iOS] Can activate ContextActions on ListViews reliably again (#1144)
* Add ContextActions test category

* Add repro for 58875

* [iOS] Null check for the Delegate; clear the static WeakRef on dispose
2017-09-15 18:52:24 -07:00
Stephane Delcroix 8ee62e827e [C, iOS, Android] LayoutCompression (#1136)
* [C, iOS, Android] LayoutCompression

* fix docs

* minor fixups
2017-09-13 11:18:59 +02:00
Rui Marinho 1676417323 [iOS] Make sure to include query path on generated url (#1119) 2017-09-01 16:26:03 +01:00
Samantha Houts 6b9730ee2b [iOS] Prevent ListView HasUnevenRows crash when template w/container Element is swapped (#1095)
* Add repro for 58645

* [iOS] Check for null before clearing element renderer

* [iOS] Remove unnecessary code

renderer.SetElement(null); == descendant.ClearValue(Platform.RendererProperty);

* [iOS] Clarify comment, use preferred method of clearing renderer from Element

* How about we make the test work?

Sounds like a good idea to me.
2017-08-15 16:50:59 +01:00
Marko B. Ludolph af404c5529 [macOS] Implements/Fixes Vertical Text Alignment in the Label Renderer (#1046) 2017-08-15 11:14:02 +01:00
Marko B. Ludolph 44c6ccdd6b [macOS] Autolayout Engine Exception Fix (#1048) 2017-08-10 23:23:46 +01:00
E.Z. Hart 0ff50e2418 Add support for backcompat hint flags (#1074)
* Add support for backcompat hint flags

* Making fast renderers internal and sealed while experimental
2017-08-10 19:08:18 +01:00
Rui Marinho c13edf4f7c [iOS] Clear state so we allow the SelectedItem to be set (#1073) 2017-08-07 19:34:55 +01:00
Rui Marinho 2d726831ce [iOS] Fix regression introduced on #520 (#1072) 2017-08-02 00:48:27 +01:00
David Ortinau e828fa6fa5 when closing the Picker by tapping outside or hitting done, verify the source selection index matches the UI control. When it is in spin, the animation completes offscreen and the next time it opens you see the wrong row selected. (#1054) 2017-07-24 17:00:20 -04:00
E.Z. Hart 7303d60ab6 Disallow scrolling in ScrollView when IsEnabled set to False (#1049)
* Repro and fix for iOS

* Automated tests

* Fix for Android

* Update issue number

* Alternate version of test which I hope will work on iOS 8

* trying yet another variation of the test which will hopefully work on iOS 8
2017-07-24 16:57:31 -04:00
Samantha Houts a9f6acb870 [iOS] ListView with UnevenRows and Cell Heights will no longer be slow to load (#994)
* Add repro for 56896

* [iOS] Cached defined row heights for estimation

* [iOS] Null check source
2017-06-23 11:37:00 +01:00
adrianknight89 6e7b2ee3c0 [iOS] Issue warning to console when MasterDetailPage is pushed onto NavigationPage (#1000)
* add warning

* change to Trace
2017-06-22 19:36:28 +01:00
Stephane Delcroix f6bdb76b0a [iOS] decoupling UpdateText() on LabelRenderer (#950)
* [iOS] decoupling UpdateText() on LabelRenderer

* [iOS] do not update font and color on formattedstrings
2017-06-22 10:49:41 +01:00
Samantha Houts 67bc2d5488 [iOS/Android] Fixes "jumping" when navigation to a page with a NavigationBar from a page without one (#962)
* Add repro

* [iOS] Set IgnoreContainerArea when no Nav Bar

* [Android] Layout bar and page at the same time

* Add custom renderer to turn off transitions

* Fix test case number

* Remove superfluous category set

* Fix test automation, add TabbedPage
2017-06-22 10:25:35 +01:00
E.Z. Hart c6f547b298 Allow multiple tap gestures to fire simultaneously on iOS (#964)
* Allow multiple tap gestures to fire simultaneously on iOS

* Verify that the tap came from the same UIView
2017-06-21 12:13:06 +01:00
Stephane Delcroix b7b0bf559a [iOS] workaround a weird iOS behavior. (#987) 2017-06-21 02:00:58 +01:00
David Ortinau 723cb80c6b [iOS] Proxy UITableViewCell SelectionStyle when wrapped (#1002)
* making sure the UITableViewCell SelectionStyle proxies up when wrapped in ContextActionCell and with recycling mode

* corrected coding style, tabs instead of spaces. Removed stub for UITest.
2017-06-20 14:12:17 -04:00
Samantha Houts ec75b998fa [iOS] Picker no longer allows arbitrary text to be typed with keyboard (#996)
* Add repro

* [iOS] Reset text on editing

* Add instructions, fix test case number
2017-06-20 19:11:40 +01:00
E.Z. Hart 99074753a0 Align Layout transparency behavior between Android, iOS, Windows (#935)
* Setting up repros

* Tests for all combos of opacity, background color, and InputTransparent

* Make InputTransparent work correctly for Layouts on Windows

* Prevent low opacity from making Layouts implicitly input transparent

* Real target values in TransparentOverlayTests

* Allow layouts with transparent backgrounds to be clickable

* Fix gesture bubbling behavior for layouts

* Fix spacing

* Remove dead code and usings

* Fix spacing

* Add missing using directive

* Adjust transparent overlay test to work with iOS quirks

* Fix spacing

* Fix bugs caused by not filtering ACTION_CANCEL in MotionEventHelper

* Attempting to fix the tests on iOS (where UI tests can't see the buttons)

* Remove extra lines

* Another attempt to get tests working on iOS

* Another attempt to get iOS UI tests working for transparent overlays
2017-06-20 16:40:07 +01:00
E.Z. Hart f7c943dc77 [iOS] Allow Forms gestures on custom renderers for controls which already have gestures (#990)
* Repro 57114 with UI test; fix for 57114 on iOS

* Repro/UI test for Windows

* Add helpful comment for posterity

* Remove stray TODO

* Only do ShouldReceiveTouch on mobile

* Explicitly require wrapped UIView to have gesture recognizers
2017-06-20 16:38:58 +01:00
kingces95 6f5d6ce8da Provide better exception for bad INotifyCollectionChanged index bounds (#948) 2017-06-14 16:14:08 -07:00
Rui Marinho ec5492cd0d [iOS,Android] Fix gap when setting Separator None and recycle element and on Android when using grouping (#949)
* [Controls] Add repo for bugzilla 39802

* [iOS] Make ContextCell hide the gap when we aren't using a separator

* [Controls] Update test

* [iOS] Only fix height if separator is hidden.

* [iOS] Only fix if it's a ListiView

* [Android] Fix separator showing when using Grouping

* Update Bugzilla39802.cs
2017-06-14 15:58:03 -07:00
Jimmy Garrido 88693cc316 Fix possible crash on iOS when using ContextActions (#973) 2017-06-13 20:11:10 +01:00
E.Z. Hart 3a0072029f Prevent double dimiss of modal view controller when webview opens image picker (#951) 2017-06-12 11:49:58 +01:00
kadiryazgan 0834d2d13f make OnShouldReturn protected (#906)
* make OnShouldReturn protected

There are situations where we don't want to dismiss the keyboard when return key is pressed.
Making OnShouldReturn protected will let custom renderers to disable ResignFirstResponder behaviour.

* added virtual keyword to OnShouldReturn
2017-05-26 12:41:51 +01:00
Rui Marinho 8f7b1f7f17 [iOS] Handle user popping pages out of order (#934)
* [iOS] Handle when user can call pop a page that was already disposed/removed

* [Controls] Fix bug number
2017-05-24 10:29:09 -07:00
Stephane Delcroix 9a443a8508 Fix animations with GLViews (#931)
* null guard _displayLink (bz42755)

* change NSRunLoop mode (fix bz41413)
2017-05-23 19:04:25 +01:00
Samantha Houts 4e83b8ee0f [All] Rename Accessibility -> AutomationProperties (#912)
* [All] Renamed Accessibility -> AutomationProperties

* Update docs

* Restore doc summaries

* Revert unintended csproj changes
2017-05-10 18:20:57 +01:00
Samantha Houts 20bfa5b503 [iOS] Null Element before disposing trial renderers in uneven ListViews (#894)
* Add repro for 55745

* [iOS] Null Element before disposing trial renderers
2017-05-02 16:18:05 -07:00
Matthias 6ee219ca1d Add check for instance of UITableView (#885) 2017-04-27 10:42:12 -04:00
E.Z. Hart cdc4055128 Better error handling for image loading errors on iOS/Android (#849)
* First run at removing async void image update methods

Consistent error logging and IsLoading on Android,iOS,UWP

Move error logging into image handlers for better messages

Add demo of custom ImageRenderer error handling

Update docs

Make the test smaller so the results don't get pushed offscreen

Fix namespace error

* Update error handling for fast image renderer

* Update 37625 test to use image we control

* Add java disposed check to avoid ObjectDisposedException in async operations

* Add disposed checks to legacy renderer; null check element before SetIsLoading

* Check disposed on GetDesiredSize for fast renderer
Use local disposed member where possible for disposed check

* Check for disposal after async handlers in iOS

* Add disposal checks after async methods in Windows

* Reset linker settings on project; reduce redundant casts in ImageViewExtensions
2017-04-25 19:16:25 +01:00
Samantha Houts 17c7d8ed5c [iOS] Prevent NRE in ListView OnItemSelected (#883)
* Add repro

* [iOS] Prevent NRE in ListView

* [Android] Prevent NRE in ListView

Not observed, but adding defensive check just in case
2017-04-25 11:14:16 -07:00
kingces95 093a4efa2d Implicit impl of controller ifaces (#807)
* Simplify ICtrl callsites

* Rebase fix
2017-04-11 19:02:06 +01:00
Samantha Houts 5f2796e160 [Internal] Normalize Obsolete attributes (#860)
* [All] Normalize Obsolete attributes.

Make sure we include the version in which the member was deprecated and
consistent instructions for working around the deprecation, if
applicable.

* Update docs
2017-04-07 09:47:33 +02:00
kingces95 45a6a80b4c Fix 52962; Cont refresh even when pullToRefresh is disabled (#810) 2017-04-06 22:47:12 +01:00
adrianknight89 6966dd6cc7 [iOS] ActivityIndicator should not disappear when used in a ViewCell (#495)
* preserve activity indicator state

* changed to using listviewrenderer

* remove whitespace

* moved message to constructor

* add sample code

* remove message sending

* changes

* remove curly braces
2017-04-06 19:25:47 +01:00
Jimmy Garrido b42611cdeb Hide alert window before setting result (#848) 2017-03-31 01:04:29 +01:00
Samantha Houts 1eae24b051 [iOS] Prevent NRE when page is switched on Appearing (#840) 2017-03-27 11:31:04 +01:00
adrianknight89 27de335bf1 [iOS] Platform specifics to control ScrollView content touch delay (#563)
* can delay content touches optionally

* revert bug fix

* add back _tapGesture

* remove extra declaration
2017-03-24 12:07:59 -07:00
Samantha Houts eea0bdcc6e [iOS] Don't skip row height estimation for grouped lists (#838)
* Nest bugzilla 51536 classes for less pollution

* Add repro for 53834

* [iOS] Don't skip row height estimation for grouped lists
2017-03-24 11:02:59 +00:00
Samantha Houts c65a9a8c57 [iOS/Win] Label will not unnecessarily expand (#827)
* Add repro for 53362

* [iOS] Label will not unnecessarily expand

* [Win] Label will not unnecessarily expand
2017-03-22 10:43:17 +00:00
James Clancey 4e9d99fea4 iOS renderers now properly look up the ImageSourceHandler for FileImageSource (#826) 2017-03-21 15:02:39 +00:00
adrianknight89 ea4673c8cb [iOS] Use UIButtonType.System for Button and utilize UIButton.Appearance (#554)
* Change button style and use UIButton appearance

* added sample code

* change references

* setting other properties

* add comment

* refactor proxy setter

* made control states array static

* remove category declaration

* changes

* add sample code

* changes

* Fix identation

* Update ButtonRenderer.cs
2017-03-20 15:53:54 +00:00
kingces95 ce06819328 Adopt iOS status bar visibility defaults (#822) 2017-03-18 18:55:40 +00:00
Daniel Williamson e36a02497a Set the transitioning delegate. (#819) 2017-03-16 21:58:42 +00:00
Vitaly Knyazev cf213891c9 Bug 51536, initial iOS cell layout is incorrect when cell has context actions … (#787)
* Bug 51536, initial height is incorrect when cell has context actions or ListView is in recycle mode

* Improved fix for iOS uneven height cell layout

* Fixed indentation and added test case for issue 44525

* Fixed indentation for test case

* Added 1px room, this will fix Bugzilla31330 test, renamed test case to 51536

* Updated shared project file
2017-03-14 09:22:21 -07:00
Samantha Houts e7f5a4188d [iOS] ViewCells will respond to ForceUpdateSize in RecycleElement mode (#809)
* Add reproduction for 44525

* Clean up gallery page

* [iOS] Get index path from Cell in RecycleElement

* Fix obsolete code
2017-03-14 10:30:22 +00:00