Граф коммитов

13 Коммитов

Автор SHA1 Сообщение Дата
Felipe Momm 3782a5d7df [Shell] Fail when trying to add a duplicated route (#6613) 2019-06-25 17:05:03 -06:00
Shane Neuville d857ce2679 fix up shell menu items, fix templates, fix bindings (#6117)
* fix up shell menu items, fix templates, fix bindings

* propagate bindingcontext changed on menu items

* address feedback
fixes #4399
fixes #5707
2019-05-09 20:58:04 -07:00
Shane Neuville 03e9a9fe43 Remove experimental flag for shell and change a few apis (#6086) fixes #2415
* api changes for shell official

* Update Xamarin.Forms.Core/Shell/Shell.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* Update Xamarin.Forms.Core/Shell/ShellItemCollection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* Update Xamarin.Forms.Core/Shell/ShellSection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* Update Xamarin.Forms.Core/Shell/ShellItem.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* fix compile errors

* fix ui test

* fix ui test

* removed some more properties

* remove a couple more
2019-05-09 14:18:04 -07:00
Shane Neuville 5210d5c1e6 [Shell] propagate css to logical child element (#6082) fixes #4683 fixes #5956
* create an actual logical child structure for page to use for propagation

* JustTheLogicalChildren

* only iterate over ActuallyLogicalChildren

* fix naming

* reuse ChildrenNotDrawnByThisElement

* testing

* fix unit test
2019-05-09 14:17:30 -07:00
Shane Neuville a1431ed9da remove route params from shell (#6081)
* remove route params from shell

* Update Xamarin.Forms.Core.UnitTests/ShellTests.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* fix unit test
2019-05-08 16:15:43 -07:00
Shane Neuville 18dc4ec13d [Shell] Add Tab bar and auto promote tabs to nearest TabBar (#6023)
* add tab bar and promote implicit tabs to same tabbar

* - remove parent

* remove tab bar from flyout

* Update Xamarin.Forms.Core/Shell/ShellItemCollection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
2019-05-08 16:15:18 -07:00
Shane Neuville 48606a5f1f
fix infinite loops and remove public apis (#5954)
* fix infinite loops and remove public apis

* - remove comments, fix location to not have implicit

* force uri to be relative on ios when no scheme specified

* address PR comments

* add error message

* reformat absolute uris

* additional suggestions

* Update Xamarin.Forms.Core/Shell/ShellNavigationState.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>

* Update Xamarin.Forms.Core/Shell/ShellUriHandler.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
2019-04-24 16:25:12 -06:00
Shane Neuville dbf4037a31 [Shell] Propagate Page bindings to TitleView and Shell Binding to Flyout (#5934) fixes #5650 fixes #5501
* propagate bindingcontext

* - add exception message and fix poorly named xaml file

* add ui test automation

* - fix unit test to represent new code

* - changed from ui test to unit test

* - propagate visual, parent, bc to titleview

* - style fixes
2019-04-18 16:25:31 +01:00
Shane Neuville 58662a10b4 [Shell] refactor of processing uris (#5852)
fixes #5790
2019-04-10 21:54:50 -07:00
Pavel Yakovlev e3360aa8c9 [Shell] fixes navigate to a relative URI (#4977) 2019-01-15 15:05:51 +01:00
Stephane Delcroix 47bd0cdeb8 [Shell] Allow queryParams navigation (#4615)
* [Shell] Allow queryParams navigation

Allow uri navigation with queryParams. queryParams can be applied
to:
- the ShellContent (if inherited)
- the Content (or inflated ContentTemplate) of the ShellContent
- the BindingContext of the Content

those 3 can inherit an interface and handle the queryParams, or
the types can be decorated with some [QueryProperty] attributes.
Attributes are handled on the 3 typesL ShellContent, actual content,
or bindingcontext.

- fixes #4596

* syntax errors

* Address formatting comments

* [Core] add check when setting BindingContext on page to self

* [Core] fix navigation for non templated item
2018-12-03 19:12:00 -08:00
Shane Neuville 8a61e2d870 [Core] remove code setting NavProxy to null (#4604) 2018-12-03 08:53:47 +01:00
Stephane Delcroix 78385f9fc1 [Shell] The glorious Shell (#4522)
* [Shell] The glorious Shell

* set the flag for the test

* remove the FastRenderer flag

* [Android] If we were disposed earlier Element can be null and Control was disposed

* [Controls] Seems part of #2520 was solved so we don't need this

* [iOS] Fix NRE on the ScrollviewTracker

* add missing constructor for RenderWith

* [Core] propagate visual/flow through shell

* use interlock increment

* hide IDataTemplateController

* [Android] Fix TableViewModelRenderer dispose

* [Core] propagate visual/flow direction through shell hierarchy

* [Android-Gallery] removed some left in settings changes that effect UI Tests

* [iOS,Droid,Core] Code formatting

* [iOS,Core] Last minute style refactoring
2018-11-29 20:22:51 -08:00