Pavel Yakovlev
5b291d7c00
[WPF] Fixes the order in which visual elements are transformed ( #3327 )
2018-08-06 17:59:09 +01:00
Vitaly Knyazev
02f006dfe0
[iOS] Prevent crash when a leaked cell has MenuItem with bindings ( #3288 )
...
* Prevent crash when a leaked cell in ListView with Recycle mode has MenuItem with bindings and framework like Xamarin.Forms sets BindingContext to null after leaving the page
* Made SetupSelection static
2018-08-06 17:57:45 +01:00
John VanSickle
a447b5b1af
Fix Entry Completed invocation logic for macOS ( #3201 ) fixes #1650
...
The Completed event should be invoked when the user presses the return key only. Using NSTextField DidEndEditing is not favorable because pressing the Tab key will cause this method as well
2018-08-06 17:54:54 +01:00
Rui Marinho
fa1df7bdcd
Merge branch '3.2.0'
2018-08-06 17:05:11 +01:00
Rui Marinho
ec65b05e5d
Merge branch '3.1.0' into 3.2.0
2018-08-06 16:59:19 +01:00
Pavel Yakovlev
1fe23fff8e
[UWP] Fixes of calculation of heights in the MasterDetailPage ( #2924 ) Fixes #1648
...
* [UWP] Fixes of calculation of heights in the MasterDetailPage
* addressing comments
2018-08-06 15:24:03 +01:00
Samantha Houts
a7b4a47396
[iOS] Implement `ForceUpdateSize` for `TableView` ( #3300 ) fixes #2842
...
* Add repro for #2842
* [iOS] Implement ForceUpdateSize for TableView
fixes #2842
* Revert changes to TableViewModelRenderer
2018-08-06 15:23:22 +01:00
Samantha Houts
4f696a3b6d
[Android] BoxView should fall back to BackgroundColor ( #3392 ) fixes #3342
...
* Add repro for #3342
* [Android] BoxView should fall back to BackgroundColor
* Fix test name
* Remove flaky test
2018-08-06 15:22:40 +01:00
Pavel Yakovlev
810ebac870
[UWP] Fixed freezing UI when scrolling the listview ( #3439 )
...
* [UWP] Fixed freezing UI when scrolling the listview
* fixes #3367
* added a comment in the UI test
2018-08-03 16:16:16 -06:00
Rob Lyndon
273d7c4de9
[Android]Fixing a NullReferenceException that happens when a page is closedd ( #3375 ) fixes #3373
2018-08-03 15:56:05 +01:00
Alan McGovern
03f8c9fdee
[Android] Fix a potential null reference ( #3476 )
...
Addresses https://devdiv.visualstudio.com/DevDiv/_workitems/edit/657472
2018-08-03 15:49:54 +01:00
Javier Suárez Ruiz
48ef2390ab
[WPF] Added option to register extra assemblies in WPF Forms initialization ( #3428 )
...
* Added option to register extra assemblies in WPF Forms initialization
* Fixed Build error
2018-08-03 15:47:39 +01:00
Samantha Houts
21b26ac860
[Android] Prevent duplicate events from SwipeGestureRecognizer ( #3443 ) fixes #3415
...
* Add repro for #3415
* [Core] Remove HasFlags from SwipeGestureRecognizer
* [Android] Prevent duplicate swipe events
fixes #3415
* Clean up test
2018-08-03 15:40:47 +01:00
Pavel Yakovlev
af55f1d2c0
[UWP] fixes image scale ( #3178 )
...
- fixes #3169
2018-08-02 23:37:58 -06:00
Stephane Delcroix
a9a68c6e60
[C] fix TargetNullValue Bindings ( #3468 )
...
Due to a flux in the matrix, Bindings with a TargetNullValue assigned
were always returning that value. It had the advantage of being right
sometimes, but the inconvenient for being wrong, most of the times.
By properly aligning the bits of the register with the sun at beer time,
we can avoid that side effect, and actually returns a value when the
binding is succesful, and the TargetNullValue whem the Binding returns
null.
- fixes #3467
2018-08-02 16:56:19 -07:00
adrianknight89
5a6f34970a
[Android] Add IsSmoothScrollEnabled platform specific to control tab change animation ( #2965 )
...
* add ability to control smooth scrolling
* added test case
* removed test case
* add test button
* EnableGesture should be controlled by another platform specific
2018-08-02 16:51:36 -07:00
ShaneN
1049a65056
Merge branch '3.2.0'
2018-08-02 15:55:15 -06:00
kingces95
1ee8e7d577
[iOS] WebView renderer that replaces UIWebView with WkWebView ( #3346 )
...
* wkwebview
* Remove default UITest
* PR changes
2018-08-01 22:45:49 -10:00
Samantha Houts
7045d80843
Add assembly version to XF.Core ( #3460 )
...
* Add assembly version to XF.Core
fixes #3354
* you know what helps? using statements.
2018-08-02 08:11:35 +02:00
John VanSickle
c9ef84345d
Fix mac os Editor transparent color handling ( #3218 )
2018-08-01 18:43:21 +01:00
Pavel Yakovlev
15fe14d88f
[Core] Fixed setting CornerRadius of button to 5 ( #3441 )
...
* [Core] Fixed setting CornerRadius of button to 5
* correction of typos
- fixes #3390
2018-08-01 09:08:07 +02:00
E.Z. Hart
3f9dca4758
[UWP] Remove Platform casts ( #3442 )
...
* Move back button handling directly to platform
* Make UWP platform statically accessible, cache instance on NavigationPageRenderer
2018-08-01 09:07:28 +02:00
Stephane Delcroix
6246b9020e
[C] abstract the Style property in an interface ( #3438 )
...
so it's ahsred between VisualElement and span, and retrieving the
property is easier.
- fixes #3314
2018-07-31 11:53:25 +02:00
Stephane Delcroix
2c65c03e99
[C, Xaml] add SizeTypeConverter ( #3381 )
...
Add a missing TypeConverter attribute to Size struct.
- fixes #3280
2018-07-31 10:26:34 +02:00
Stephane Delcroix
a2b836110b
[CSS] allow mapping css prop to multiple BPs ( #3437 )
...
To allow mapping a single CSS property to multiple controls, we so far
relied on extracting the BindableProperties to static helper classes,
and implementing an interface for accessors, and eventually change
handlers.
That extraction works well, and is actually a good pattern, as long as:
- the extracted BPs share the same PropertyName,
- default value, and
- return type, obiously
As the CSS `color` property has to map to both `TextColor` and `Color`
BPs, the property extraction wasn't possible.
This change adds the capability to map a single CSS property to
multiples BPS, when extraction isn't possible. Whenever the extraction
to an interface is possible, that behavior is strongly encouraged.
2018-07-31 09:18:54 +02:00
Pavel Yakovlev
2b5fad067d
[UWP] Fixes setting SelectedItem inside ItemSelected event ( #2984 )
...
* [UWP] Fixes #1469 setting SelectedItem inside ItemSelected event
* test improvement
2018-07-30 21:42:33 -06:00
Martin Zikmund
6031bbfb69
[UWP] Fix CornerRadius rendering on Frame ( #3239 ) fixes #2838
...
* Updated Frame renderer on UWP to handle CornerRadius properly
* Test page for issue 2838
* Fixed typo and removed UITEST directive
* Label was cut off, fixed
2018-07-30 17:54:24 +01:00
Jay Cho
d710f4b80d
[Tizen] Fix Page.IsBusy Appearance ( #3416 )
2018-07-30 17:11:56 +01:00
Javier Suárez Ruiz
8732962333
[GTK] Fixed wrong CurrentPage index in TabbedPage ( #3115 )
...
* Fixed wrong CurrentPage index in GTK TabbedPage
* Improved GTK TabbedPage CurrentPage logic
* Fixed strange text format
* Removed unnecesary "private" keywords
2018-07-30 16:56:38 +01:00
Neil McAlister
1a71035f51
[Core] Report binding failures ( #2911 ) fixes #2639
...
* Implemented debug LogListener according to feedback
* Added check to see if log listener is already contained before adding/removing
2018-07-30 16:55:49 +01:00
E.Z. Hart
11a1e70f72
Simplify subscription to context action closure messages ( #3365 )
2018-07-30 16:54:12 +01:00
Shane Neuville
b3f7c152d1
[UWP] #fixes #3333 ( #3347 )
...
-add null check to Listview layout update in case it's already been disposed
2018-07-30 16:52:20 +01:00
Stephane Delcroix
2535c2098c
Merge branch '3.2.0'
2018-07-30 10:39:42 +02:00
Stephane Delcroix
2b74434ba0
Merge branch '3.1.0' into 3.2.0
2018-07-30 10:39:09 +02:00
Shane Neuville
63ab975771
BackButtonTitleProperty isn't used by android ( #3345 )
2018-07-26 15:01:17 -06:00
E.Z. Hart
dfd7251101
[UWP] Add missing IToolBarForegroundBinder interface on TabbedPageRenderer ( #3363 )
...
* Implement missing IToolBarForegroundBinder interface on TabbedPageRenderer
* Make the tool bar foreground/background colors apply to new tabs
2018-07-26 13:51:40 -06:00
E.Z. Hart
457f4c0156
[iOS] Remove iOS Platform Casts ( #3361 )
...
* [iOS] Move dispose helpers to their own static class (and off Platform)
* Add null checks on Elements
2018-07-26 10:40:09 -06:00
E.Z. Hart
3a067272a9
Rejoin Platform and NavigationPageRenderer partial classes ( #3362 )
2018-07-26 11:27:57 +02:00
Stephane Delcroix
d675b3e47a
[Xaml] avoid GC'ing handlers in TypedBindings ( #3387 )
...
Keep a ref to OnPropertyChanged handlers to avoid garbage collection.
- fixes #1949
2018-07-26 11:27:04 +02:00
Stephane Delcroix
3878335d60
[XamlC] Resolve generic base type on GetProperty ( #3394 )
...
GetMethod, GetField, ... were already correctly resolving generic base
types. GetProperty or GetEvent were not, causing NRE later on.
- fixes #3260
2018-07-26 11:22:51 +02:00
Stephane Delcroix
7cf3725e9d
[XamlG] allow x:Name on types in using: xmlns ( #3395 )
...
- fixes #3393
2018-07-26 11:22:39 +02:00
Pavel Yakovlev
24be4ea745
[UWP] Fixes password Entry Copy/Paste/Insert/Remove behavior ( #3166 )
2018-07-25 18:06:32 -07:00
Francesco Bonacci
c5dd9f80d1
Add check for null _root flex item ( #3235 )
2018-07-25 14:34:22 +02:00
E.Z. Hart
4edb715f6d
Alternate version of ToolbarButtons_1_Exist to avoid possible race condition
2018-07-23 15:36:26 -06:00
Shane Neuville
72ad5cac3d
Remove math on scroll view container for RTL ( #3299 )
...
* fixes #3000 remove math on scroll view container for RTL
- setup RTL scrollviews to all start scrolled all the way to the right
* * formatting and renaming fixes
* - don't move scroll if not set to RTL
2018-07-23 11:11:01 -07:00
Samantha Houts
ab677420e3
Merge branch '3.2.0'
2018-07-23 10:34:19 -07:00
Samantha Houts
e365181f5c
Merge branch '3.1.0' into 3.2.0
2018-07-23 10:33:44 -07:00
John VanSickle
0250ce7e88
[macOS] Fix standard button events ( #3203 ) fixes #1776
...
* Fix mac os standard button events
Pressed, Released, Clicked, and Command all fire appropriately
* Rename / improve mac os button event pressed / released actions
2018-07-23 16:19:14 +01:00
BinaryCraX
b2a5d24456
[WPF] #fixes #3355 add Default-FontSize ( #3356 )
2018-07-23 16:33:33 +02:00
Alexander Houben
36a33676ef
*.swp: remove temporary vim file(s) ( #3377 )
...
* Remove temporary vim file, add *.swp to .gitignore
* Remove all *.swp instances found
2018-07-23 16:31:16 +02:00