Граф коммитов

389 Коммитов

Автор SHA1 Сообщение Дата
Samantha Houts e1cba2c8f1
[iOS] Add ability to turn off updates to native controls from another thread (#3774)
* [iOS] Add ability to turn off updates to native controls from another thread

* Flip evaluation order

fixes #1755
2018-10-04 14:58:34 -07:00
Andrei 07482a10f7 Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin… (#3842)
* Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin.Forms/issues/3840
- fixes #3840
* fixe formatting

* [UITest] added UI Test

* [Controls] adjusted UI Test button positions

* [UITEST]  simplify UI tests
2018-10-03 15:56:33 -06:00
Rui Marinho 31b8ad198d Merge branch '3.2.0' into 3.3.0 2018-10-02 23:34:32 +01:00
Shane Neuville 4c367911b9 Only set the Page Padding via SafeAreaInset on iOS (#3811)
* only set the Page Padding via SafeAreaInset on iOS
-fixes #3809

* [Controls] add waits for clicks in ui tests

* [Controls] remove wrong category

* [iOS] Move inset logic down into ios renderer
2018-10-02 09:43:53 +02:00
ShaneN f3f39f8022 Merge 3.2.0 into 3.3.0 2018-10-01 19:14:48 -06:00
Shane Neuville 379adeb380 [iOS] fix full width issues for TitleView (#3939)
* [iOS] fix full width issues for TitleView

* [iOS] simplified iOS 10

fixes #3881
fixes #3679
2018-10-01 10:53:47 -07:00
Rui Marinho 8bf897ac5d [iOS] Use UIApperance default color for UISwitch (#3819)
* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API
2018-09-19 14:06:37 -07:00
Rui Marinho 06fe1f2d45 Merge branch '3.2.0' into 3.3.0 2018-09-13 19:28:49 +01:00
Rui Marinho d23b48434d
[iOS] Fix NRE on ContextCell (#3714) fixes #3275
* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell
2018-09-13 19:25:17 +01:00
Pavel Yakovlev cceee9ded6 Add TabStop/TabIndex (#2795)
* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public
2018-09-12 21:20:46 -07:00
Rui Marinho ad8ac34d59
Fix tests (#3771)
* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool
2018-09-13 01:37:04 +01:00
Rui Marinho ddd914b7a1
Merge branch '3.2.0' 2018-09-11 17:38:29 +01:00
Pavel Yakovlev 9f97968334 [Android, iOS] Fixes layout compression causes (#3698) fixes #3624
* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully
2018-09-11 14:32:50 +01:00
Rui Marinho ec76761e3c [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)
* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule
2018-09-05 15:04:02 -07:00
Rui Marinho 181b1ae57d
Merge branch '3.2.0' 2018-09-03 12:28:59 +01:00
Rui Marinho 6c94e6e0c8
[iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139
* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139
2018-09-03 10:36:54 +01:00
Samantha Houts 7422cb8b17 Merge branch '3.2.0' 2018-08-31 14:19:27 -07:00
Samantha Houts a8260b0075 [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633
* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch
2018-08-31 18:20:30 +01:00
Shane Neuville 8f03f5ec5c [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)
* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null
2018-08-31 12:32:37 +01:00
Rui Marinho 4301017bf6
Merge branch '3.2.0' 2018-08-29 10:28:29 +01:00
Shane Neuville 0a34ef1b4d
[iOS] fixes #3525 - add epsilon for float compare (#3654)
* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private
2018-08-28 22:21:22 -06:00
Samantha Houts 11965c284c [iOS] iPad ActionSheet should always have a Cancel method (#3636)
* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049
2018-08-28 11:19:14 -06:00
Rui Marinho a94074463e
Merge branch '3.2.0' 2018-08-28 13:08:55 +01:00
Pavel Yakovlev 56d47a1469 [iOS] AutomationProperty support for cells (#3313) fixes #3296
* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery
2018-08-23 13:28:31 +01:00
kingces95 712361c366 Fix NRE; Ret 0 if Text null (#3594) fixes #3579 2018-08-21 11:22:58 +01:00
Gerald Versluis 203d4ffcf0 MaxLines property on Label (#3318)
* Implemented MaxLines on iOS, Mac OS, Android, UWP and WPF

Introduced new MaxLines property on Label

* Set default value to -1

* Implemented reverting to default value

* More improvements

Update measurement when MaxLines property value changes and updates to default values.

fixes #2060
fixes #1706
2018-08-16 07:25:47 +00:00
Rui Marinho 0610191b3d Merge branch '3.2.0' 2018-08-15 20:19:45 +01:00
Rui Marinho 689a0bb9bc
[iOS] Fix sizing issue on MDP (#3515) fixes #3458
* [iOS] Fix sizing of MDP when rotating

* [Controls]Add a NavigationPage to MDP FlowDirectionGallery so we can have the toggle button
2018-08-15 20:06:16 +01:00
Vitaly Knyazev 02f006dfe0 [iOS] Prevent crash when a leaked cell has MenuItem with bindings (#3288)
* Prevent crash when a leaked cell in ListView with Recycle mode has MenuItem with bindings and framework like Xamarin.Forms sets BindingContext to null after leaving the page

* Made SetupSelection static
2018-08-06 17:57:45 +01:00
Samantha Houts a7b4a47396 [iOS] Implement `ForceUpdateSize` for `TableView` (#3300) fixes #2842
* Add repro for #2842

* [iOS] Implement ForceUpdateSize for TableView

fixes #2842

* Revert changes to TableViewModelRenderer
2018-08-06 15:23:22 +01:00
kingces95 1ee8e7d577
[iOS] WebView renderer that replaces UIWebView with WkWebView (#3346)
* wkwebview

* Remove default UITest

* PR changes
2018-08-01 22:45:49 -10:00
Stephane Delcroix 2535c2098c Merge branch '3.2.0' 2018-07-30 10:39:42 +02:00
Stephane Delcroix 2b74434ba0 Merge branch '3.1.0' into 3.2.0 2018-07-30 10:39:09 +02:00
E.Z. Hart 457f4c0156
[iOS] Remove iOS Platform Casts (#3361)
* [iOS] Move dispose helpers to their own static class (and off Platform)

* Add null checks on Elements
2018-07-26 10:40:09 -06:00
Shane Neuville 72ad5cac3d Remove math on scroll view container for RTL (#3299)
* fixes #3000 remove math on scroll view container for RTL
- setup RTL scrollviews to all start scrolled all the way to the right

* * formatting and renaming fixes

* - don't move scroll if not set to RTL
2018-07-23 11:11:01 -07:00
Alan Grgic 97d2f30f6b [Enhancement] Allow underline and strikethrough text decorations on labels and spans (#2221)
* Fixes #1632

* Allow underline and strikethrought text decorations on labels and spans

* revert some files

* pr feedback adjustments

* remove docs

* rename interface

* reorder enum

* clean up whitespace

* adjust tizen renderer

* add gallery demo for setting both underline and strike

* allow multiple values of enum to be set in xaml/css

* use normal null check

* use nameof

* include paragraph style

* tab alignment

* rebase from upstream

* pass control to update method on UWP

* correct text decorations type converter

* reset run text instead of label text on UWP when spans are used

* add tests for text decoration converter
2018-07-20 17:57:11 -06:00
Gerald Versluis 271cb309a6 [Enhancement][iOS] Support UIModalPresentationStyle.FormSheet (#3119)
* First attempt at #1726

Implemented enum and hooked into modal presentation to set the right flag whenever a screen is presented modally on the iPad

* Added back to gallery button on sample app

* Moved setting UIModalPresentationStyle to ModalWrapper ctor

* Removed unused usings
2018-07-10 16:43:41 -06:00
Rui Marinho 57994e7d8d Merge branch '3.1.0' 2018-06-28 17:07:59 +01:00
Stephane Delcroix c79c77dbdf [build] Version and strongname the Build.Tasks (#3118) 2018-06-28 12:04:16 +01:00
Rui Marinho 5d14e5e945
[iOS] Fix layout lines on secondary items 2018-06-28 11:23:21 +01:00
Rui Marinho 508686bbbe
[iOS] Fix NRE when child wasn't added yet to NavigationPage (#3162)
* [Controls] Add test 15 and rename issues 1583_1

* [iOS] Do not try to layout if no child was added yet

* Update NavigationRenderer.cs
2018-06-27 22:33:12 +01:00
Rui Marinho b15de064fe
[iOS] Fix iOS WebView load url with port number (#3120) fixes #3073
* [Controls,iOS] Add repo for url with port

* [iOS] Use Url.Authority that contains domain and port

* [Controls] Try fix test 1583

* [iOS] Try fix test again
2018-06-27 17:21:50 +01:00
Rui Marinho 9073cf788d
[iOS] Try another fix for toolbar items layout (#3123) fixes #2798
* [Controls] Push new page on repo

* [iOS] Do not set the same frame on toolbaritem
2018-06-26 16:36:00 +01:00
Rui Marinho 9fe5372c1d Merge branch '3.1.0' 2018-06-26 15:10:42 +01:00
Samantha Houts 4d5a1f5482 TitleView (#2586)
* Stop crashing when I accidentally click on the Perf gallery

* [Core] Add TitleView to NavigationPage

- also add unit tests
- fixes #1716

* [Android] Add ClearRenderer static method to Platform

* [Android] Use Platform.ClearRenderer

it's a straight extract from this class

* [Android] Implement TitleView and TitleIcon on AppCompat backend

using lessons (and some duplicated code) from ListView header/footer views.

* [iOS] Implement TitleView

* [UWP] Implement TitleIcon and TitleView

* [Core] Add NavigationPage.BarHeight

* [Android] Use BarHeight

* NavigationBarGallery updates

* [Core] Add iOS HideNavigationBarSeparator Platform Specific

* [iOS] Implement HideNavigationBarSeparator Platform Specific

* sample search page

* Convert BarHeight to Android platform specific

* Reset BarHeight when leaving the gallery

* Add a sample TitleView xaml page

* VisualElement >> View

* Fix comment

* Improved SearchTitle sample page

* [Core] Set TitleView Parent on Changing instead of Changed

Changing is too late for the iOS layout

* [iOS] Fix layouts in iOS10

* [iOS] Stop content clipping

* Expanded test page

* [iOS] Fix HideNavigationBarSeparator for iOS<11

* [iOS] Layout TitleView with margins

* More tweaks to test page

* [UWP] Fix OnDetailPropertyChanged if/else

* [UWP] Comment empty setters

* Convert commented code to more useful comment.

* Adjust performance test async call
2018-06-25 13:00:03 +01:00
Shane Neuville d6810346d1 [iOS] If the UITableView hasn't rendered anything yet don't try to sync cells (#3090) fixes #1342 fixes #1542 fixes #1927
* [iOS] fixes #1342 - verify the UITableView has rendered cells before trying to synchronize to collection

* - let reset through on CollectionChanged
2018-06-22 16:08:56 +01:00
Samantha Houts ad2522354a [iOS] RecycleElement ListView should not crash when bound to ObservableCollection (ArgumentNullException & ArgumentException) (#3042) fixes #1900 fixes #3026
* [iOS] Default to TextCell in GetPrototypicalCell

fixes #3026

* [iOS] Don't throw exception when Index doesn't match in RecycleElement

fixes #1900

* Add repros for #1342, #1900, #1927

* errant space

* Remove repros for #1342 and #1927 (tbc in another branch)

* Update Issue1900.cs

* Revert exception type

did not mean to change that! yay for ui tests

* Update Issue1900.cs
2018-06-20 22:14:26 +01:00
Rui Marinho a8ec456ac0
Merge branch '3.1.0' 2018-06-16 01:00:51 +01:00
Stephane Delcroix 584846fe00 Fix broken 2499 test (#3037)
* Fix broken 2499 test

SelectedIndex being a BP, setting it's value might be delayed, and as
both ios and android PickerRenderer do not update on individual property
changes, but have a single UpdatePicker method, some properties might be
out-of-date, causing a crash.

This doesn't attemps to fix the renderers, but only prevents a crash to
happen.

* [Android] Apply fix to AppCompact picker

* [iOS] Enable linker for sdk

* [UITests] Better test for issue 2499
2018-06-15 19:01:21 +01:00
Rui Marinho a5bae7c47d Merge branch '3.0.0' to 3.1.0 2018-06-15 19:00:48 +01:00