Граф коммитов

11 Коммитов

Автор SHA1 Сообщение Дата
Rahul Amlekar fa0843c491
1.5 website schema explorer updates (#6550)
* Updating schema explorer properties

* adding tableCell to toc and attempting whitespace fix

* indentation fix

indentation fix

* Removing filtered prop

Removing filtered prop - it's auto generated in our build

Co-authored-by: RahulAmlekar <raamleka@microsoft.com>
2021-10-08 16:19:06 -07:00
Paul Campbell 36eb7f9d3a
[Schema] Add `mode` property to `Action`s (#6474)
Fixes #6467
2021-10-04 22:09:19 +00:00
Paul Campbell a9b3d991a9
[Schema] Add password masking to the 1.5 schema (#6376)
* [Schema] Add password masking to the 1.5 schema

Fixes #6339 and adds enum property versioning support.

* Updates to get spec generation working

* Updated specs

* fix tabs

* Updated specs

* Update schema README

* Fix broken markdown link

* clarify spec generation

* missed a tab

* Updated host-config.json again

* Updated generated markdown files

* Updated specs

* Fix up some generation stuff and fix root object definition

* Spec update

* Clean up resource strings

* Updated specs

* Move away from tabs (like our editorconfig states)

* RTL schema fixes

* Add table to root, fix up tabs, and regenerate strings

* Fix TableRow and TableCell parenting

Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
Co-authored-by: Paul Campbell <paulcam@paulcam-mac.local>
Co-authored-by: RebeccaAnne <rebecch@microsoft.com>
Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
2021-10-01 21:36:19 -07:00
RebeccaAnne a644c14f1a
[Schema] Update choices to be optional on choiceset (#5646)
* [Schema] Update choices to be optional on choiceset

* Updated specs

Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
2021-04-12 14:31:06 -07:00
Joseph Woo 2e7fd8d37e
Mobile Inconsistency Spec: first draft (#4737)
* first draft

* Updated specs

Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
2021-01-15 14:40:06 -08:00
RebeccaAnne 69b1a43030
Feature/associated inputs (#5155)
* [JS] Action.Submit.associatedInputs support (#5136)

* Action.Submit.associatedInputs support

* Remove unnecessary imports. Better README

* Remove unnecessary code

* [Shared] Add associatedInputs property to Action.Submit (#5139)

* Add property and re-swig

* Remove unused ignoreInputValidation, add tests

* Fix test, re-swig

* [UWP] Add support for associatedInputs none value (#5141)

* [UWP] Add support for associatedInputs none value

* Code review feedback

Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>

* [.NET] Add support for associatedInputs none value (#5137)

* [Schema] Add associatedInputs to the schema and docs (#5140)

* [Schema] Add associatedInputs to the schema and docs

* Add default to schema

* Implemented associated input (#5148)

* Implemented associated input

* addressed the review comments

* [Android] Support associatedInputs: none (#5152)

* AssociatedInputs.None Android

* Unintended change

* Delete xml doc files

Co-authored-by: David Claux <dclaux@users.noreply.github.com>
Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
Co-authored-by: Paul Campbell <paulcam@microsoft.com>
2020-12-10 12:40:43 -08:00
Joseph Woo d8a889b88f
Added Placeholder to ChoiceSet (#4811)
* Fixed the crash issue

* Fixed Bleeding Crash Issue

* finishing up changes for bleed update

* work in progress

* updated ChoiceSetInput.cpp

* ios change

* schema & uwp changes

* Updated specs

* Android Changes

* addressed review comments

* Updated specs

* Added placeholder text example to test cards

* added a new card

* added UWP test images

* Fixed bad merge

* updated schema

* Updated specs

Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
2020-09-29 12:46:34 -07:00
RebeccaAnne 86e3a64e7f
[Spec][InputEvolution]Update schema and documentation files to match the latest spec (#4255)
* Update schema and documentation files to match the latest spec

* Update to remove documentation of optional suffixes as they are not supported.

* Update with latest design decisions

* Regenerate the schema file
2020-07-22 16:11:38 -07:00
almedina-ms c1e9ad02ef
Feature/input evolution (#4005)
* Add classes for validation

* Add interfaces for input validation

* [UWP] Input Validation Prototype

* Second version of validation

* Update some stuff

* Add minor fixes and ur

* Add multitype label support

* Fix break

* Add support for card elements as labels

* Add automation properties

* Add fixes for accessibiloty

* Add host config support

* Fix accessibility for error messages

* Add host config options for validation behavior

* Modify host config to show enw options

* Add files to project

* Remove UWP specific code

* Remove Android specific code changes

* Update test files

* [TS] Input validation (#4197)

* Work in progress

* Code complete

* Now actually code complete

* Fix not all required inputs gathered from ShowCard

* Accessibility support

* Add aria-required, hide suffix from accessibility

* aria-required for Toggle and ChoiceSet

* Add sample

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
Co-authored-by: Paul Campbell <paulcam@microsoft.com>

* [Shared model] Update namings in host config (#4213)

* Remove validation behaviour from host config

* Update namings in hostconfig

* Fix build errors

* Fix some test json for bugbash

* Fix cards with errors

* Update long labels to be loooooooooooooooooooooong

* [DevSpec] Updates to input validation spec (#4190)

* Input Validation Spec Documents

* Fix casing on broken image links'

* Updates to document based on discussions and feedback

* Minor formatting change

Updated the "Start the documentation site" heading to be at the same level as the rest of the headings

* Removing instructions around explicit hexo install

* [Security] Bump handlebars in /source/nodejs/adaptivecards (#3692)

* Bump handlebars from 4.1.2 to 4.5.3 in /source/community/reactnative (#3694)

* [UWP] Fix null dereference in Media code path (#3669)

[UWP] Fix null dereference in Media code path

* [UWP] Fix RendererRegistration error handling and fix inheritance issue with WholeItemsPanel (#3710)

* updated the doc (#3706)

* updated the doc

* Updated specs

* updated the description

* Updated specs

* updated the doc to correct wrong info

* Updated specs

* [Accessibility] Fixing some color contrast issues in the website (#3698)

* Updating adaptivecards.io homepage's roadmap links to point to the updated productboard portal

* Fixes #3577 ; Fixes #3576:

* Fixing outlook.css since that is the style sheet that is being picked up by default when you hit the explorer page

* automatic package.json changes

* Fixing color syntax

* Site readme updates (#3699)

1. Including PreRequisite section around repo bootstrap linking to root readme
2. Cleaning up build commands to use lerna to be consistent with root readme and removing redundant steps

* added test to parse and render all sample cards (#3679)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* [UWP] Remove image comparison from unit tests (#3724)

* [UWP] Remove image comparison from unit tests

* Code review feedback

* Added MaxActions Limit Check (#3696)

* Added MaxActions limit check and replaced multiple of GetActions() call
That returns a structure by value

* added UnitTesting and Warning

* added UnitTesting and Warning

fixed comments

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Jwoo/ios telephony update (#3680)

* updating telephony detection for markdown link

* undo uneccesary changes

* updated RichTextBlockRenderer to detect Telephony link

* updated sample card

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* [Android] Fix scrolling behaviour in multiline Input.Text (#3714)

* Fix scrolling behaviour in multiline text input

* Add test files

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Fix vertical content alignment for elements in root (#3716)

* [SharedModel] Skip date/time tests outside of Pacific TZ (#3611)

* [SharedModel] Skip date/time tests outside of Pacific TZ

Fixes #3609

* Rename TEST_MODULE_INITIALIZE method

* Remove TEST_MODULE_INITIALIZE altogether

* Update macro name

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Create cortana-beta-light.json (#3729)

New HostConfig for Cortana Windows UWP beta, light mode. To be added to the drop down as: Cortana (Beta) - Light

* Create cortana-beta-dark.json (#3730)

Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com>

* [Android] Fix to have HH:mm in Input.Time elements (#3713)

* Fix to have short time format

* Change helper function

* Add unit tets

* Add sample test json

* Remove unnecessary test file

* Fixed #3741 (#3743)

* Updated Cover FillMode Behavior (#3725)

* Updated Cover FillMode Behavior

* Revew Comments Addresssed

* adding testing card

* Updated file

* Updated Handling of Preprocessed Text (#3727)

* Updated preprocessed text handling

* updated formatting

* Added Accesibility Tags

* updated accessibility

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* updated project file to expose media rendere (#3726)

* iOS new layout scheme (#3687)

* Updated iOS layout
* removed wrapper on TextBlock and RichTextBlock renderers
* updated layout views to use intrinsic contentsize
* updated property value for layout vies
* Added key value observation for hidden property to allow toggle
visibility and the new layout change to work together

* Updated views with toggle visibility to update its contentsize based on
their visibility changes
Updated padding priority for bleeding

* restores to working project file

* updated project file for xcode

* updated for CR comments

* Fixed for CR comments

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* updated the gradle property to handle error token (#3742)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* More feedback updates

* Add backwards compatibility section

* Update to labels spec to reflect the latest discussions

* Add an update to the label spec to cover the current state of discussions

* Update some open discussion and comments

* Update link

* Flesh out host config options

* Fix some comments

* Fix more comments

* Split original spec into two options

* Fix comment from discussion

* Get the general spec on track with the other two

* Add almost final version

* Move costing outside of appendix

* Add index to point to topics easier

* Add table of contents for validation

* Add WCA Guidelines

* Add requirements

* Update specs

* Remove markdown from v1

* Make small updates to input validation spec

* Add fixes for comments from last meeting

* Update host config structure

* Take options out of scope for associated inputs

* Add changes from 05/26 meeting

* Update requirements

* Update last details of spec

* [Android] Show all ActionSet's in column (#4181)

* Adjust ActionSet container height to fit contents

* Add test card

* Fix UWP build break after branch change and merge

* Revert no longer relevent changes in samples and schema

Co-authored-by: Rebecca Muraira <rebecch@microsoft.com>
Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com>
Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com>
Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>

* [UWP] Input Evolution (#4088)

* Re add everything related to UWP

* Remove validation behaviour from host config

* Remove references to validation behaviour

* Update input retrieval

* Add changes to respect label and error messages on custom inputs

* Remove comment and repeated code

* Update namings in hostconfig

* Update host config and fixes broken error message setting

* Fix first batch of comments in PR

* Remove render context from input value constructor

* Fix more comments from PR

* Fix more comments

* Fix text wrapping in error message and bug in time input validation

* Fix input retrieval bug

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* [Android] Input labels and errors support (#4039)

* First working android version for inputs and errors

* Clean up android tests

* Fix tests for other input types

* Update swig files

* Fix build error

* Remove validation behaviour from host config

* Remove validation behaviour references

* Working version n1 for visible views only

* Add more changes to respect basic properties as spacing

* Add fix to compress casting tasks

* Fix some behaviours and check that all inputs work

* Update host config

* Updsate object model file

* Readd legacy card import for testing purposes

* Fix android not rendering elements

* Fix issues found in bug bash'

* Fix test fieks

* Fix tests

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Fix casting issue

* Add missing file from previous commit

* [WPF] Input Evolution (#4172)

* Add NET shared model support and WPF rendering support for labels and error messages

* Fix validation bugs

* Fix some acessibility issues

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* [UWP] Fix inline actions not getting inputs (#4266)

* Fix inline actions not validating inputs

* Updated specs

Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>

* [UWP] Respect host config formatting for labels (#4289)

* Fix host config on labels

* Fix comments

* Fix crashes when no input exist in a card (#4316)

* [UWP] Sample custom input (#4282)

* Add sample input and changes the use of internal id for string id

* Fix commments from PR

* [WPF] Rename the input label host config property to match cpp shared model (#4308)

* Rename the input label host config properties

* Remove build files from git

* Remove invalid test cards and add new valid test cards

* Remove associated inputs from submit actions

* Fix failing tests

* Fix test errors

* Rename custom input to be the same as other renderers (#4328)

* Fix input visibility (#4306)

* Fix crash when clicking inline actin (#4290)

* Fix samples (#4347)

* Remove build files from git

* Add properties to hostconfig and fix duplicated id

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* [TS] Input accessibility + designer open sample dialog fixes (#4239)

* [JS] Input accessibility and designer fixes

* Fix Input.Number min/max not honored when set to 0

* Update package-lock.json

* Further package-lock.json updates

Co-authored-by: Paul Campbell (DEP) <paulcam@microsoft.com>
Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Ts/input label as label (#4354)

* [JS] Input label as <label>

* Fix typo

* Update package-lock.json

* Another package-lock update

* Small preview mode fix

Co-authored-by: Paul Campbell <paulcam@microsoft.com>

* [Android] fix focus on elements (#4321)

* Add custom input element to verify correct label rendering

* Fix Focus Visibility on choiceset elements

* Add missing file change

* Fix build error

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* work in progress

* completed input view

* completed input label & work in progress for inputvalidation

* [UWP] Fix crash when invoking show cards (#4370)

* Remove control validation (#4379)

* [Android] Fix suffix rendering in labels (#4372)

* Remove build files from git

* Fix label suffix

* [Android] Fix visual input cue to clean the state on instantiation (#4373)

* Remove build files from git

* Fix preloaded visual cue

* [Android] Fix empty date input (#4374)

* Remove build files from git

* Fix date input to allow being empty on start

* complted implementing input validation

* [JS] Regenerate package-lock files

* code complete

* Revert "Merge branch 'jwoo/ios-input-evolution' into feature/inputEvolution"

This reverts commit dda9109802, reversing
changes made to 609f25e465.

* Emit warning for required inputs without label (#4435)

* [UWP] Fix Input.Number validation logic to ensure value is a number (#4432)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* [WPF] Fix automation properties (#4371)

* Remove build files from git

* Fix AutomationProperties for Accessibility

* Fix comments from pr

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Add warnings for empty labels in required inputs (#4409)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Add warning for empty label in required input (#4454)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Add input retrieval to inlinr submit actions (#4453)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* [Android] Fix stretch textblock claiming all visible space (#4452)

* Fix elements taking the whole space

* Add sample files

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Sample updates (#4455)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Change choiceset returns from null to empty (#4458)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* ios input evolution (#4437)

* refactored and fixed bug bash bugs

* fixed merge error

* added warning messages when there is no error message is present when the input has the validations

* refactored code and fixed unit tests

* updated failed test card since bad card is fixed

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Fix label to make hint always have attention color (#4456)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>

* Fixing .NET CI tests for feature/inputEvolution (#4462)

* Ignoring default value for LabelConfig.inputspacing during serialization

* Updating API doc

* Fixing regression in WPF renderer processing v1.0 inputs

* Reverting changes to default launchSettings for the ImageRenderer sample

Co-authored-by: Rebecca Muraira <rebecch@microsoft.com>
Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Co-authored-by: David Claux <dclaux@users.noreply.github.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
Co-authored-by: jarusse <59999260+jarusse@users.noreply.github.com>
Co-authored-by: Matt Hidinger <matt.hidinger@gmail.com>
Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com>
2020-07-22 07:29:37 -07:00
RebeccaAnne 76c4fc5eab
Input Labels Spec Documents (#3618)
* Input Labels Spec Documents

* Updated with some feedback from design discussion meeting

* More review feedback upates

* Update schema and spec to have label on all inputs

* Update test app results for new sample
2019-12-04 16:09:28 -08:00
Andrew Leader a6383af354
Spec tooling and specs (#3068)
Added tooling so that we can generate specs from our schema, so that our spec'ing process starts with updating the schema first, leading to less errors and mistakes in the end :)

In `schemas\src`, add your new properties/elements to the schema

![UpdateSchema](https://user-images.githubusercontent.com/13246069/59529888-0fee6b80-8e97-11e9-8925-d29264c57b4d.gif)


### 3. Generate the updated spec

If you followed the setup instructions, simply save the file and the spec will be updated! Add any necessary rendering details to the spec.

![UpdatedSpec](https://user-images.githubusercontent.com/13246069/59530207-e2ee8880-8e97-11e9-8957-de92911c2935.gif)


## Review spec

Submit a pull request for your updated spec/schema. The proposed schema in the proposal becomes outdated and should be replaced with a link to the PR.

![image](https://user-images.githubusercontent.com/13246069/59530515-a8392000-8e98-11e9-8d25-62d40d550517.png)


I'll share more details about this at Monday's meeting. Lots of details about the new proposed spec'ing process are captured here: https://github.com/microsoft/AdaptiveCards/wiki/Project-Management

###### Microsoft Reviewers: [Open in CodeFlow](http://wpcp.azurewebsites.net/CodeFlowProtocolProxy2.php?pullrequest=https://github.com/microsoft/AdaptiveCards/pull/3068)
2019-06-18 10:45:07 -07:00