diff --git a/CHANGELOG.md b/CHANGELOG.md index 1f2acc6..2cefd75 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,8 @@ # Changelog -## Version develop +## Version 2.8.0-beta1 - [Fix: Add `IJavaScriptSnippet` service interface and update the `IServiceCollection` extension to register it for `JavaScriptSnippet`.](https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/890) +- [Fix - ApplicationInsights StartupFilter should not swallow exceptions from downstream ApplicationBuilder.](https://github.com/microsoft/ApplicationInsights-aspnetcore/issues/897) ## Version 2.7.0 - Updated Web/Base SDK version dependency to 2.10.0 diff --git a/src/Microsoft.ApplicationInsights.AspNetCore/Implementation/ApplicationInsightsStartupFilter.cs b/src/Microsoft.ApplicationInsights.AspNetCore/Implementation/ApplicationInsightsStartupFilter.cs index d8cc38b..d62ac00 100644 --- a/src/Microsoft.ApplicationInsights.AspNetCore/Implementation/ApplicationInsightsStartupFilter.cs +++ b/src/Microsoft.ApplicationInsights.AspNetCore/Implementation/ApplicationInsightsStartupFilter.cs @@ -23,12 +23,14 @@ // via class which triggers // initialization of TelemetryModules and construction of TelemetryProcessor pipeline. var tc = app.ApplicationServices.GetService(); - next(app); } catch (Exception ex) { AspNetCoreEventSource.Instance.LogWarning(ex.Message); } + + // Invoking next builder is not wrapped in try catch to ensure any exceptions gets propogated up. + next(app); }; } }