fix analyzers (#1927)

* testing fix for analyzers

* fix stylecop/fxcop violations

.props/Product.props

@@ -11,7 +11,7 @@
   <Import Project=".\_GlobalStaticVersion.props" />
   <Import Project=".\_Nupkg.props" />
 
-  <ItemGroup Condition=" $(OS) == 'Windows_NT' And $(Configuration) == 'Release'">
+  <ItemGroup Condition=" $(OS) == 'Windows_NT'">
     <!--Analyzers-->
     <PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
       <PrivateAssets>All</PrivateAssets>

BASE/src/ServerTelemetryChannel/Implementation/ApplicationFolderProvider.cs

@@ -38,7 +38,7 @@
                 throw new ArgumentNullException(nameof(environment));
             }
 
-            if(IsWindowsOperatingSystem())
+            if (IsWindowsOperatingSystem())
             {
                 this.identityProvider = new WindowsIdentityProvider();
                 this.ApplySecurityToDirectory = this.SetSecurityPermissionsToAdminAndCurrentUserWindows;
@@ -109,15 +109,6 @@
             return result;
         }
 
-        /// <summary>
-        /// Test hook to allow testing of non-windows scenario.
-        /// </summary>
-        /// <param name="applySecurityToDirectory">The method to be invoked to set directory access.</param>
-        internal void OverrideApplySecurityToDirectory(Func<DirectoryInfo, bool> applySecurityToDirectory)
-        {
-            this.ApplySecurityToDirectory = applySecurityToDirectory;
-        }
-
         internal static bool IsWindowsOperatingSystem()
         {
 #if NET45
@@ -134,6 +125,15 @@
 #endif
         }
 
+        /// <summary>
+        /// Test hook to allow testing of non-windows scenario.
+        /// </summary>
+        /// <param name="applySecurityToDirectory">The method to be invoked to set directory access.</param>
+        internal void OverrideApplySecurityToDirectory(Func<DirectoryInfo, bool> applySecurityToDirectory)
+        {
+            this.ApplySecurityToDirectory = applySecurityToDirectory;
+        }
+
         private static string GetPathAccessFailureErrorMessage(Exception exp, string path)
         {
             return "Path: " + path + "; Error: " + exp.Message + Environment.NewLine;

Directory.Build.props

@@ -34,7 +34,10 @@
     <PackagesDir>$([System.IO.Path]::GetFullPath( $(PackagesDir) ))</PackagesDir>
 
     <RelativeOutputPathBase>$(MSBuildProjectDirectory.Substring($(EnlistmentRoot.Length)))</RelativeOutputPathBase>
-    <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
+    <Configuration Condition=" '$(Configuration)' == '' ">Release</Configuration>
+
+    <!--This is to disable code analysis while devs are working. Default is true.-->
+    <RunAnalyzers Condition=" '$(Configuration)' == 'Debug' ">false</RunAnalyzers>
 
     <OutputPath>$(BinRoot)\$(Configuration)\test\$(MSBuildProjectName)</OutputPath>
     <OutputPath>$([System.IO.Path]::GetFullPath( $(OutputPath) ))\</OutputPath>