[.NET Core] Remove more DISABLE_FEATURE constants (#319)

- remove define constants:
  - DISABLE_FEATURE_HTTPEXCEPTION
  - DISABLE_FEATURE_SECURITY_ATTRIBUTES

AB#1521781

Public/Sdk/SelfHost/BuildXL/BuildXLSdk.dsc

@@ -379,9 +379,7 @@ function processArguments(args: Arguments, targetType: Csc.TargetType) : Argumen
                 ...addIf(isDotNetCoreBuild,
                     "FEATURE_CORECLR",
                     "FEATURE_SAFE_PROCESS_HANDLE",
-                    "DISABLE_FEATURE_HTTPEXCEPTION",
                     "DISABLE_FEATURE_VSEXTENSION_INSTALL_CHECK",
-                    "DISABLE_FEATURE_SECURITY_ATTRIBUTES",
                     "DISABLE_FEATURE_HTMLWRITER",
                     "DISABLE_FEATURE_FILES_SYSTEM_RIGHTS",
                     "DISABLE_FEATURE_EXTENDED_ENCODING"

Public/Src/Engine/Dll/Visualization/ValueNotAvailableException.cs

@@ -3,9 +3,7 @@
 
 using System;
 using System.Runtime.Serialization;
-#if !DISABLE_FEATURE_SECURITY_ATTRIBUTES
 using System.Security.Permissions;
-#endif
 
 namespace BuildXL.Engine.Visualization
 {
@@ -61,9 +59,7 @@ namespace BuildXL.Engine.Visualization
         /// </summary>
         /// <param name="info">Serialization info</param>
         /// <param name="context">Streaming context</param>
-#if !DISABLE_FEATURE_SECURITY_ATTRIBUTES
         [SecurityPermission(SecurityAction.Demand, SerializationFormatter = true)]
-#endif
         public override void GetObjectData(SerializationInfo info, StreamingContext context)
         {
             base.GetObjectData(info, context);

Public/Src/Engine/Processes/Internal/SafeNullHandle.cs

@@ -7,9 +7,7 @@ using Microsoft.Win32.SafeHandles;
 
 namespace BuildXL.Processes.Internal
 {
-#if !DISABLE_FEATURE_SECURITY_ATTRIBUTES
     [SuppressUnmanagedCodeSecurity]
-#endif
     internal sealed class SafeNullHandle : SafeHandleZeroOrMinusOneIsInvalid
     {
         private SafeNullHandle()

Public/Src/FrontEnd/Core/FrontEndHostController.Nuget.cs

@@ -723,16 +723,7 @@ namespace BuildXL.FrontEnd.Core
                 {
                     return LogAndReturnDownloadFailure(e);
                 }
-#if !DISABLE_FEATURE_HTTPEXCEPTION
-                catch (HttpException e)
-                {
-                    return LogAndReturnDownloadFailure(e);
-                }
                 catch (HttpRequestException e)
-#else
-                // Catch all exceptions since we can't do any better when HttpException is not available
-                catch (Exception e)
-#endif
                 {
                     return LogAndReturnDownloadFailure(e);
                 }

Public/Src/Utilities/Interop/Windows/SafeProcessHandle.cs

@@ -11,9 +11,7 @@ using Microsoft.Win32.SafeHandles;
 namespace BuildXL.Interop.Windows
 {
     /// <nodoc />
-#if !DISABLE_FEATURE_SECURITY_ATTRIBUTES
     [SuppressUnmanagedCodeSecurity]
-#endif
     public sealed class SafeProcessHandle : SafeHandleZeroOrMinusOneIsInvalid
     {
         [DllImport(BuildXL.Interop.Libraries.WindowsKernel32, SetLastError = true)]

Public/Src/Utilities/Native/IO/Windows/SafeIOCompletionPortHandle.cs

@@ -10,9 +10,7 @@ namespace BuildXL.Native.IO.Windows
     /// <summary>
     /// Handle for an IO completion port as created by <see cref="FileSystemWin.CreateIOCompletionPort"/>.
     /// </summary>
-#if !DISABLE_FEATURE_SECURITY_ATTRIBUTES
     [SuppressUnmanagedCodeSecurity]
-#endif
     public sealed class SafeIOCompletionPortHandle : SafeHandleZeroOrMinusOneIsInvalid
     {
         /// <summary>

Public/Src/Utilities/Native/Processes/SafeThreadHandle.cs

@@ -7,9 +7,7 @@ using Microsoft.Win32.SafeHandles;
 namespace BuildXL.Native.Processes
 {
     /// <nodoc />
-#if !DISABLE_FEATURE_SECURITY_ATTRIBUTES
     [SuppressUnmanagedCodeSecurity]
-#endif
     public sealed class SafeThreadHandle : SafeHandleZeroOrMinusOneIsInvalid
     {
         // constructor get's called by pinvoke

RunCheckInTests.cmd

@@ -72,7 +72,7 @@ if EXIST %ENLISTMENTROOT%\Out\frontend\Nuget\specs (
 set start=%time%
 set stepName=Building 'debug\net472' and 'debug\win-x64' using Lkg and deploying to RunCheckinTests
 call :StatusMessage %stepName%
-    call :RunBxl -Use LKG -Deploy RunCheckinTests /q:DebugNet472 /q:DebugDotNetCore /f:output='%ENLISTMENTROOT%\Out\Bin\debug\net472\*'oroutput='%ENLISTMENTROOT%\Out\Bin\debug\win-x64\*'oroutput='%ENLISTMENTROOT%\Out\Bin\tests\debug\*' %BUILDXL_ARGS% /enableLazyOutputs- /TraceInfo:RunCheckinTests=LKG /useCustomPipDescriptionOnConsole-
+    call :RunBxl -Use LKG -Deploy RunCheckinTests -DeployRuntime net472 /q:DebugNet472 /q:DebugDotNetCore /f:output='%ENLISTMENTROOT%\Out\Bin\debug\net472\*'oroutput='%ENLISTMENTROOT%\Out\Bin\debug\win-x64\*'oroutput='%ENLISTMENTROOT%\Out\Bin\tests\debug\*' %BUILDXL_ARGS% /enableLazyOutputs- /TraceInfo:RunCheckinTests=LKG /useCustomPipDescriptionOnConsole-
     if %ERRORLEVEL% NEQ 0 goto BadLKGMessage
 call :RecordStep "%stepName%" %start%