Merged PR 788328: Fix CacheDump Analyzer Crashes when Trying to Dump a Failed Strong Fingerprint

In order to use the `D4` formatstring the argument needs to be an int, see [this precedent](https://dev.azure.com/mseng/Domino/_git/BuildXL.Internal?path=/Public/Src/App/Bxl/BuildXLApp.cs&version=GC37d0ca68b1fb20cf158073807008332394071d93&line=2664&lineEnd=2665&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents)

I ran the repro without and with this change and validated it worked.

Related work items: #2185385
This commit is contained in:
Ben Witman 2024-06-05 16:13:48 +00:00
Родитель ae9f2c5348
Коммит 399856aa3c
1 изменённых файлов: 1 добавлений и 1 удалений

Просмотреть файл

@ -243,7 +243,7 @@ namespace BuildXL.Execution.Analyzer
if (!info.StrongFingerprintComputation.Succeeded)
{
var dxCodesOfInterest = I($"DX{LogEventId.DisallowedFileAccessInTopOnlySourceSealedDirectory:D4}, DX{LogEventId.DisallowedFileAccessInSealedDirectory:D4}, DX{LogEventId.PathSetValidationTargetFailedAccessCheck:D4}");
var dxCodesOfInterest = I($"DX{(int)LogEventId.DisallowedFileAccessInTopOnlySourceSealedDirectory:D4}, DX{(int)LogEventId.DisallowedFileAccessInSealedDirectory:D4}, DX{(int)LogEventId.PathSetValidationTargetFailedAccessCheck:D4}");
writer.WriteLine("Strong fingerprint computation failed.");
writer.WriteLine($" This occurs if graph/policy was changed such that pip is no longer allowed to access");
writer.WriteLine($" a path contained in the prior observed inputs (e.g., dependent seal directory contents");