Merged PR 778080: Fix perf smell message for uncachable pips

Fix perf smell message for uncachable pips
This commit is contained in:
Iman Narasamdya 2024-04-10 01:16:41 +00:00
Родитель 12e39eb417
Коммит 74ce9fe119
2 изменённых файлов: 4 добавлений и 3 удалений

Просмотреть файл

@ -2661,7 +2661,8 @@ namespace BuildXL
if (schedulerInfo.ProcessPipsUncacheable > 0)
{
LogPerfSmell(context, () => Logger.Log.ProcessPipsUncacheable(context, schedulerInfo.ProcessPipsUncacheable));
string relatedDxCodes = $"DX{(int)ProcessesLogEventId.PipProcessDisallowedFileAccessAllowlistedNonCacheable:D4} or DX{(int)SchedulerLogEventId.ProcessNotStoredToCachedDueToItsInherentUncacheability:D4}";
LogPerfSmell(context, () => Logger.Log.ProcessPipsUncacheable(context, schedulerInfo.ProcessPipsUncacheable, relatedDxCodes));
}
// Make sure there were some misses since a complete noop with incremental scheduling shouldn't cause this to trigger

Просмотреть файл

@ -427,9 +427,9 @@ namespace BuildXL.App.Tracing
EventGenerators = EventGenerators.LocalOnly,
EventLevel = Level.Verbose,
EventTask = (ushort)Tasks.HostApplication,
Message = "Uncacheable Pips: This build had {count} pips that are not cacheable and will be unconditionally run. See related DX0269 messages earlier in the log for details.",
Message = "Uncacheable Pips: This build had {count} pips that are not cacheable and will be unconditionally run. See related {relatedDxCodes} messages earlier in the log for details.",
Keywords = (int)Keywords.UserMessage)]
public abstract void ProcessPipsUncacheable(LoggingContext context, long count);
public abstract void ProcessPipsUncacheable(LoggingContext context, long count, string relatedDxCodes);
[GeneratedEvent(
(ushort)LogEventId.NoCriticalPathTableHits,