Build Fixup (#22)

* Add Directory.Build.rps

Better defaults when just running MSBuild.exe within the repo.

* Disable warning for preview SDK

If you have a preview installed you get a warning without this.

* Convert 2 Fact tests to a Theory

Apparently there's an analyzer for this pattern that produces a warning.

* Remove missing Content file.

* Suppress warnings for conflicting types

Directory.Build.props

@@ -10,5 +10,6 @@
     <LangVersion>7.2</LangVersion>
     <SignAssembly>true</SignAssembly>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
+    <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
   </PropertyGroup>
 </Project>

Directory.Build.rsp

@@ -0,0 +1,4 @@
+/verbosity:minimal
+/maxcpucount
+/restore
+/consoleloggerparameters:Summary

src/Engine/UnitTests/Processes.Detours/PipExecutorDetoursTest.cs

@@ -3778,18 +3778,9 @@ namespace Test.BuildXL.Processes.Detours
             }
         }
 
-        [Fact]
-        public Task TimestampsNormalize()
-        {
-            return Timestamps(normalize: true);
-        }
-
-        [Fact]
-        public Task TimestampsNoNormalize()
-        {
-            return Timestamps(normalize: false);
-        }
-
+        [Theory]
+        [InlineData(true)]
+        [InlineData(false)]
         public async Task Timestamps(bool normalize)
         {
             var context = BuildXLContext.CreateInstanceForTesting();

src/Utilities/Collections/BuildXL.Utilities.Collections.csproj

@@ -7,7 +7,4 @@
   <ItemGroup>
     <PackageReference Include="RuntimeContracts " Version="0.1.7.2" />
   </ItemGroup>
-  <ItemGroup>
-    <Content Include="Microsoft.OneBuild.Collections.dsc" />
-  </ItemGroup>
 </Project>

src/Utilities/System.FormattableString/FormattableStringFactory.cs

@@ -8,11 +8,13 @@ namespace System.Runtime.CompilerServices
     /// </summary>
     public static class FormattableStringFactory
     {
+#pragma warning disable CS0436 // Type conflicts with imported type
         /// <summary>
         /// Create a <see cref="FormattableString"/> from a composite format string and object
         /// array containing zero or more objects to format.
         /// </summary>
         public static FormattableString Create(string format, params object[] arguments)
+#pragma warning restore CS0436 // Type conflicts with imported type
         {
             if (format == null)
             {
@@ -24,7 +26,9 @@ namespace System.Runtime.CompilerServices
                 throw new ArgumentNullException(nameof(arguments));
             }
 
+#pragma warning disable CS0436 // Type conflicts with imported type
             return new FormattableString(format, arguments);
+#pragma warning restore CS0436 // Type conflicts with imported type
         }
     }
 }