From ae103812d2495f4fc8fc70ef05c34f7a6cbba390 Mon Sep 17 00:00:00 2001 From: Michael Pysson Date: Fri, 6 Sep 2024 23:13:36 +0000 Subject: [PATCH] Merged PR 804024: Disable support for console hyperlinks Something in Office's dev build process tree may be intercepting and rendering the escape characters used by terminal hyperlink support. Reverting this until it can be debugged further to avoid ugly characters from showing up on the console Related work items: #2211824 --- Public/Src/App/Bxl/BuildXLApp.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Public/Src/App/Bxl/BuildXLApp.cs b/Public/Src/App/Bxl/BuildXLApp.cs index 909f38ad8..3707478c8 100644 --- a/Public/Src/App/Bxl/BuildXLApp.cs +++ b/Public/Src/App/Bxl/BuildXLApp.cs @@ -2863,6 +2863,9 @@ namespace BuildXL { path = translator?.Translate(path) ?? path; + WriteLineToConsole(path); + + /* TODO - BUG 2211824. Hyperlinks aren't rendering correctly in office dev builds. Disabling hyperlink functionality for now // Don't make the path a hyperlink if running in an SSH session since that link won't // be opened reasonably on the client of that SSH session. if (m_configuration.Infra == Infra.Developer && m_configuration.Logging.FancyConsole && !s_isSShSession.Value) @@ -2873,7 +2876,7 @@ namespace BuildXL else { WriteLineToConsole(path); - } + }*/ } private void WriteLineToConsole(string format, params object[] args)