Merged PR 710186: Temporarily skip sign nuget packages

Temporarily skip sign nuget packages
This commit is contained in:
Qi Wang 2023-03-30 21:11:24 +00:00
Родитель b176f46cbd
Коммит bb7e85ad56
2 изменённых файлов: 12 добавлений и 10 удалений

Просмотреть файл

@ -135,11 +135,11 @@ export function downloadPackage(args: Arguments) : PartialStaticContentDirectory
// If current host is windowns, esrp sign configuration and sign tool path is configured, sign the dll binary files.
if (Context.getCurrentHost().os === "win" && args.esrpSignConfiguration !== undefined) {
const signedFilesDirectoryName = `${args.id}.${args.version}.signed`;
const signedDir = d`${downloadDirectory.combine(signedFilesDirectoryName)}`;
const signedFilesDirectoryName = `${args.id}.${args.version}.signed`;
const signedDir = d`${downloadDirectory.combine(signedFilesDirectoryName)}`;
let signFiles = BinarySigner.signDirectory(args.esrpSignConfiguration, resultDir, signedDir);
return Transformer.sealPartialDirectory(signedDir, signFiles);
let signFiles = BinarySigner.signDirectory(args.esrpSignConfiguration, resultDir, signedDir);
return Transformer.sealPartialDirectory(signedDir, signFiles);
}
return resultDir;

Просмотреть файл

@ -47,12 +47,14 @@ config({
hash: "VSO0:17E8C8C0CDCCA3A6D1EE49836847148C4623ACEA5E6E36E10B691DA7FDC4C39200"
},
esrpSignConfiguration : Context.getCurrentHost().os === "win" && Environment.getFlag("ENABLE_ESRP") ? {
signToolPath: p`${Environment.expandEnvironmentVariablesInString(Environment.getStringValue("SIGN_TOOL_PATH"))}`,
signToolConfiguration: Environment.getPathValue("ESRP_SESSION_CONFIG"),
signToolEsrpPolicy: Environment.getPathValue("ESRP_POLICY_CONFIG"),
signToolAadAuth: p`${Context.getMount("SourceRoot").path}/Secrets/CodeSign/EsrpAuthentication.json`,
} : undefined,
// Temporarily skip sign nuget packages.
// Todo: Enable sign after adding configuration to selectively sign nuget packages
// esrpSignConfiguration : Context.getCurrentHost().os === "win" && Environment.getFlag("ENABLE_ESRP") ? {
// signToolPath: p`${Environment.expandEnvironmentVariablesInString(Environment.getStringValue("SIGN_TOOL_PATH"))}`,
// signToolConfiguration: Environment.getPathValue("ESRP_SESSION_CONFIG"),
// signToolEsrpPolicy: Environment.getPathValue("ESRP_POLICY_CONFIG"),
// signToolAadAuth: p`${Context.getMount("SourceRoot").path}/Secrets/CodeSign/EsrpAuthentication.json`,
// } : undefined,
repositories: importFile(f`config.microsoftInternal.dsc`).isMicrosoftInternal
? {