Looks like we only care about O_NOFOLLOW and we hardcode it ourselves most of the time, we are not really using whatever 'mode' is specified in the different system calls. So instead of making it part of the 'event' and using the OS const values (like NOFOLLOW) we should just use an enum
Related work items: #2171798
Make us resolve all paths that we report back to the sandbox (except the explicit cases where we don't want to follow the last symlink, like readlinks or stats). Also makes our intermediate symlink resolution logic preserve errno to not mess with callers.
Additionally, make the SandboxEvent immutable after constructing a report, so we don't accidentally rely on changing something insde it that would be inconsistent with the report we then create
Also added some tests for it.
Related work items: #2179576
Kyra encountered an issue where:
Drop downloads using a local cache. The local cache has a file that:
- Has the correct hash as file name
- Has the correct size as file size
- But is actually empty
This smells like this code caused the issue.
Reapply the original Net7 removal commit `4c5cc753`. The issue that we initially saw after it was merged was not caused by the commit. The commit forced a cache miss for a couple of pip and it uncovered the issue with vctip/lib.exe.
Must be merged after !784653
Related work items: #2174274
We now use different stores in different platforms. To simplify the things on the consumer, infra and the commandline side, I now lookup the given certificate name in both CurrentUser and LocalMachine stores.
There are a handful of isolated crashes on linux and codespaces where an IOException is thrown on Console.CursorLeft. It's unclear what's causing this. This change takes the approach of encapsulating all of the complicated console behavior for updating the same lines in place. If an exception is thrown anywhere inside of that, it will stop attempting that more complicated functionality and fall back on a simple Console.WriteLine for all subsequent messages. This should give a much better chance of the build being able to continue when something odd happens.
Related work items: #2138734
After net7 removal the minimal build fails in CB with 'child process survived' error.
Revert "Merged PR 784187: Remove net7 qualifier
Remove net7 qualifier and move msbuild to net8.
Related work items: #2174274"
Reverted commit `4c5cc753`.
Related work items: #2174274
Some instances of ValidateSuccessMatches errors on workers are related to this following scenario:
- Worker early-released and we call FinishAsync by capturing 'buildFailure' as null because HasFailed is false.
- We wait for worker to drain its pips
- Internal error occurs on the orchestrator
- Orchestrator terminates and tries to exit each worker.
- For early-released workers, there is already a pending FinishAsync due to the early release and the second 'FinishAsync' with the error message is ignored.
- Worker receives Exit message with no failure. ValidateSuccess condition fails because we expect the build to succeed, but there are errors logged due to pending/terminated pips on the worker itself.
Related work items: #2172783
Part of the sandbox cleanup. Root jail is not used by our customers, and the need for it for process remoting is not there now that AnyBuild is gone
Related work items: #2111125
Remove macOS sandbox / kernel extension code and examples. Trying to only remove dead code here, some refactoring is still possible to improve code structure but I will leave it for future PRs.
- Debugging some ptrace failures on 1JS
- Also disables report cache on fork/clone calls to fix a unit test that failed due to missed reports.
Related work items: #2171844
Soften build manifest warning when missing HistoricMetadataCache. With BlobL3 e2e build times are looking better than CASaaS in spite of this suboptimal behavior. Don't warn users when we plan on moving forward with this topology.
office decide to put source file into symbol drop so that source file can be retrieved from symbol store by a custom key. This will simply the implementation of the source link for office.
currently, symbolmetadata file which contains the debugentryData (including the clientKey to label the file and used for retrieving from sym store) is generated by buildxl before sending the symbol request. The key is generated based on the metadata of file by `SymstoreUtil`.
When office wants to index source files to symbol drop, source file extension may not be compatible with symstoreUtil nor do it meet requirements that key for downloading from symbolStore should be irrirelevant to content.
Office wants that `clientKey` is only relevant to path, commit or version that build can easily to compose download url for each indexed source file in symbol drop.
To do, office needs to control the generation of symbolMetaDataFile instead of letting bxl to do it.
Use a new common pool BuildXL-DevOpsAgents-Selfhost for both Windows and Linux runs. This is a pre-requisite step to be able to enable network isolation and use a common firewall for all runs.
The break is the change in StandardConsole.cs. That condition needs to be run any time the previous line was overwriteable to blank out the previously written text and move the cursor back to the appropriate position. The change was conditionalizing it when both the previous line was overwriteable and when the current line is.
I'm reverting the entire commit instead of just that one part because the error handling changes in the other files are related.
Related work items: #2138734, #2174322
BuildXL-Pipelines
Michael Pysson
Marcelo Lynch 🧉
Qi Wang
Julian Bayardo
Serge Mera
Oleksii Kononenko
Sahiti Chandramouli
Semih Okur
Pasindu Gunasekara 🍣
Kai Chen