#Issue
- office needs to specify client keys for index source in symbol drop. Since same file path will be indexed many times in different build, to avoid the key collision, we will need to specify the client key to be unique enough. However, this introduces unwanted cache miss to build if we put it as argument or environment to build graph.
- can't pass custom client key for each file under directory when calling `addDirectoryToSymbol`
- There is no filer to filter out files when calling `addDirectoryToSymbol`
#solution
- new argument `clientKeyPrefixForSymbolEnv` for symbol daemon, to specify the env name and env's value will be used for prepending to the passed custom client key before sending to symbol drop. The values is constantly changing overbuild, but it is only passed to ipc pip (always run) and doesn't impact non-ipc pip. This is best way that I could think of to avoid uncessary cache miss
- new argument `directoryContentFilter` for `addDirectoryToSymbol` to filter the files under the directory to be sent to symboldrop
- new argument `directoryPathToClientKey` for `addDirectoryToSymbol` to specify the client key by replacing the directory path with this value and each file's client key under that directory
will be composed as: `<directoryPathToClientKey>/<relative path under the directory>`
CaSaaS is currently on Net7 and it might need updated bxl bits while it's moving to Net8. This PR re-adds net7 qualifier. It's essentially a revert of `0a4d5b272900cfb6ad2c13795650e269500f9d17` and `5380d614bb98bfebb5a63900bb617ff51e93e56e`.
7.0.18 has a vulnerability, so this PR also includes a change that updates net7 bits to 7.0.19 to make the CG happy.
note: MsBuild is back to net7 (net7->net8 for msbuild was a part of net7 removal)
Reapply the original Net7 removal commit `4c5cc753`. The issue that we initially saw after it was merged was not caused by the commit. The commit forced a cache miss for a couple of pip and it uncovered the issue with vctip/lib.exe.
Must be merged after !784653
Related work items: #2174274
After net7 removal the minimal build fails in CB with 'child process survived' error.
Revert "Merged PR 784187: Remove net7 qualifier
Remove net7 qualifier and move msbuild to net8.
Related work items: #2174274"
Reverted commit `4c5cc753`.
Related work items: #2174274
The step to publish the external npm package has been removed already. This PR removes the external package from our sources (the publish step was pointing to it).
Related work items: #2168692
Adding this script in the external stage of the pipeline to extarct the .nupkg files from the Bin/Release folder. Need to do this since BInSkim only supports .dll or .exe formats and fails to detect nupkg files .
Tested this in this pipeline.
Look for buildxl-external.pkgs.0.1.0-20240403.1
The .nupkg packages are converted to .zip format and then extracted to extractedPackages folder within the same directory.
Doing this avoids BinSkim from scanning the whole of the Out folder for binaries(.dll and .exe).
https://dev.azure.com/mseng/Domino/_build/results?buildId=27610984&view=artifacts&pathAsName=false&type=publishedArtifacts
Related work items: #2166618
BuildXL-Pipelines
Michael Pysson
Oleksii Kononenko
Camille Bruckmann
Semih Okur
Kai Chen
Qi Wang
Marcelo Lynch 🧉
Serge Mera
Iman Narasamdya
CloudDev Build Account
Pasindu Gunasekara 🍣
Sahiti Chandramouli